fix: set default max-width: 40ch on the tooltip overlay #4833
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
I noticed now, as the screenshot has two lines, that we should reduce the line height in Lumo. I changed that in #4837 |
Co-authored-by: Serhii Kulykov <[email protected]>
| @@ -10,6 +10,10 @@ import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themab | |||
| registerStyles( | |||
| 'vaadin-tooltip-overlay', | |||
| css` | |||
| [part='overlay'] { | |||
| max-width: 40ch; | |||
There was a problem hiding this comment.
I'm probably really pedantic but should there be some upper bound as well to make sure it doesn't have the full width on mobile / smaller / zoomed view ports? Like using 90% as well like Rolf had in his original idea?
There was a problem hiding this comment.
I assume the re is a "safe area" around the overlay already, so there shouldn't be a need to limit the width, as it will never be 100% wide.
There was a problem hiding this comment.
Quick test on the sample in docs (without this max-width) does seem to indicate that, yes
Description
Fixes #4815
Type of change