Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use small line height for Tooltip (Lumo) #4837

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

jouni
Copy link
Member

@jouni jouni commented Oct 25, 2022

Add missing import for typography.js.

@sissbruecker
Copy link
Contributor

Updated screenshots for visual tests.

@sissbruecker sissbruecker force-pushed the lumo-tooltip-line-height branch from e84b6fb to 95cad45 Compare October 25, 2022 14:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker merged commit d3d0b22 into master Oct 25, 2022
@sissbruecker sissbruecker deleted the lumo-tooltip-line-height branch October 25, 2022 14:16
vaadin-bot pushed a commit that referenced this pull request Oct 25, 2022
* fix: use small line height for Tooltip (Lumo)

* update baseline screenshots

* update baseline screenshots for avatar package

* update baseline screenshots

Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker added a commit that referenced this pull request Oct 25, 2022
* fix: use small line height for Tooltip (Lumo)

* update baseline screenshots

* update baseline screenshots for avatar package

* update baseline screenshots

Co-authored-by: Sascha Ißbrücker <[email protected]>

Co-authored-by: Jouni Koivuviita <[email protected]>
Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants