Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serverless-offline hook #45

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Fix serverless-offline hook #45

merged 3 commits into from
Apr 8, 2021

Conversation

jay-snyder
Copy link
Contributor

@jay-snyder jay-snyder commented Apr 8, 2021

Issue

#46

What

The baker was being ran when using the command serverless offline start but not serverless offline. Fixed the hook so both commands trigger the baker.

Test

  • serverless offline start and confirm Serverless Secrets begins packaging process
  • serverless offline and confirm Serverless Secrets begins packaging process

Checks

  • Has the version number been incremented in package.json and package-lock.json

@jay-snyder jay-snyder marked this pull request as ready for review April 8, 2021 20:34
@cruisercohen
Copy link
Contributor

Looks great!

cruisercohen
cruisercohen previously approved these changes Apr 8, 2021
@jay-snyder
Copy link
Contributor Author

Looks like the build CI step is failing, not sure why at this moment. Any insight?

@cruisercohen
Copy link
Contributor

Looks like the build CI step is failing, not sure why at this moment. Any insight?

Looks like test reporter (code climate test coverage reporting) is failing

Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag
Usage:
cc-test-reporter after-build [flags]

Here's some documentation on that flag https://docs.codeclimate.com/docs/codeship-ci-test-coverage-example

@cruisercohen
Copy link
Contributor

The full output is viewable in the Details link of the failing step

@cruisercohen
Copy link
Contributor

the env variable does seem to exist in the circle ci config for this project, not sure why that didn't work, maybe a retry as the this step worked just a couple days ago?

Copy link
Contributor

@piohhmy piohhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing! 💯

@piohhmy piohhmy merged commit 57f4622 into vacasaoss:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants