Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/replication.md has a few naming/terminology issues #130

Closed
stockholmux opened this issue May 30, 2024 · 2 comments · Fixed by #153
Closed

/topics/replication.md has a few naming/terminology issues #130

stockholmux opened this issue May 30, 2024 · 2 comments · Fixed by #153

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91), I found the following issue on /topics/replication.md

Since Redis OSS 4.0, all the sub-replicas will receive exactly the same replication stream from the master.

and

Before version 4.0, writable replicas were incapable of expiring keys with a time to live set.

We can remove the old versions.

We also need to update the language to use 'primary'.

@zuiderkwast
Copy link
Contributor

zuiderkwast commented May 30, 2024

We have just taken the decision to change master to primary. Until now, "master" is used consistently in the docs and in logging, error message, etc. from Valkey. I think we should do this change as a separate effort.

@zuiderkwast
Copy link
Contributor

Removing the references to 4.0. For "master", refer to #148

zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants