Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change terminology "master" to "primary" #148

Closed
zuiderkwast opened this issue Jun 19, 2024 · 1 comment · Fixed by #177
Closed

Change terminology "master" to "primary" #148

zuiderkwast opened this issue Jun 19, 2024 · 1 comment · Fixed by #177
Assignees
@nastena1606
Labels
help wanted Extra attention is needed

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Jun 19, 2024 •
edited
Loading

Many pages to update.

Note that Redis official terminology is still master/replica. We're right now adding some aliases to allow the use of "primary" as an alias of "master" in various command parameters, etc., but this work is just being started.

The pages with very many occurrences:

  • topics/replication.md
  • topics/sentinel.md

The note about the word slave found in some pages needs to be updated to instead mention that the master/slave terminology is replaced by primary/replica.
This was referenced Jun 19, 2024
Closed
Closed
Closed
Closed
@zuiderkwast zuiderkwast added the help wanted Extra attention is needed label Sep 22, 2024
@nastena1606
Copy link
Collaborator

I'll take this one

nastena1606 added a commit to nastena1606/valkey-doc that referenced this issue Sep 27, 2024
@nastena1606
valkey-io#148 Replaced Master and Slave with Primary and Replica wher…
6eb4bf7 
…e applicable

The labels, commands and command outputs keep master and slave.
Added a note about using master and slave to replication page

Signed-off-by: Anastasia Alexadrova <[email protected]>
@madolson madolson linked a pull request Sep 29, 2024 that will close this issue
#148 Replaced Master and Slave with Primary and Replica where applicable #177
Merged
nastena1606 added a commit to nastena1606/valkey-doc that referenced this issue Sep 30, 2024
@nastena1606
valkey-io#148 Replaced Master and Slave with Primary and Replica wher…
af26d5f 
…e applicable

The labels, commands and command outputs keep master and slave.
Added a note about using master and slave to replication page

Signed-off-by: Anastasia Alexadrova <[email protected]>
madolson added a commit that referenced this issue Oct 12, 2024
@nastena1606 @madolson
#148 Replaced Master and Slave with Primary and Replica where applica…
77de0ff 
…ble (#177)

The labels, commands and command outputs keep master and slave. Added a
note about using master and slave to replication page.

---------

Signed-off-by: Anastasia Alexadrova <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nastena1606 nastena1606

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#148 Replaced Master and Slave with Primary and Replica where applicable nastena1606/valkey-doc
2 participants
@zuiderkwast @nastena1606