-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for Backport from 7_6_X: ttbar event categorizer, miniAOD jet flavour improvements #229
Conversation
update main
update main
update main
…et flavour improvements
Thank you for update. Just for a confirmation - is the code in cmssw same to yours? |
I used the recipe in the link. And, if we have to go cmss76x, we need to update few-things. |
Event categorizer가 74X에 백포팅 될 예정이예요. 현재 PR이 올라가 있는데, 이게 나중에 merge되고 나면 plugin이 중복되기 때문에 미리 cattools에서 제거하고, 대신 현재 올라간 PR을 git-cms-merge-topic 하도록 installation recipe을 업데이트 하면 됩니다. 여기서 확인하고 싶은 것은 현재 74X backporting 으로 올라간 categorizer와 영권이형이 catTools에 포함시킨 categrizer가 같은 코드인지 확인했으면 합니다. |
…et flavour improvements
…et flavour improvements
…et flavour improvements
categorizer가 같지는 않습니다. w to b, w to c를 count할수 있도록 업데이트가 더 되어 있습니다.
앞으로 recipe. |
could you update this on the twiki please |
Updated instruction. git-cms-merge-topic 11559
# git cms-merge-topic YoungKwonJo:NewGenHFHadronMatcher_cmssw747p2 |
shall we merge this now? |
+1 |
Will merge after unit test. |
Some messages during testing. @YoungKwonJo can we simply ignore it?
|
Deleted comment about JetPartonMap stuff because it is not related w/ this PR. |
This PR does nothing to the message from JetFlavourClustering, it is 100% due to the main CMSSW codes. |
Merging this PR as the recipe already updated. |
update for Backport from 7_6_X: ttbar event categorizer, miniAOD jet flavour improvements
update it for "Backport from 7_6_X: ttbar event categorizer, miniAOD jet flavour improvements"
#226
added three lines in line 304 as like in the link.
https://github.com/YoungKwonJo/cmssw/blob/NewGenHFHadronMatcher_cmssw747p2/PhysicsTools/JetMCAlgos/plugins/JetFlavourClustering.cc#L304
However, we need to remove it(CatProducer/plugins/GenTtbarCategorizer.cc) after merged cms-sw/cmssw#11559.
I have tested the code by using a command in CATTools/CatProducer/prod.