Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for Backport from 7_6_X: ttbar event categorizer, miniAOD jet flavour improvements #229

Merged
merged 8 commits into from
Oct 2, 2015

Conversation

YoungKwonJo
Copy link
Contributor

update it for "Backport from 7_6_X: ttbar event categorizer, miniAOD jet flavour improvements"
#226

added three lines in line 304 as like in the link.
https://github.com/YoungKwonJo/cmssw/blob/NewGenHFHadronMatcher_cmssw747p2/PhysicsTools/JetMCAlgos/plugins/JetFlavourClustering.cc#L304

However, we need to remove it(CatProducer/plugins/GenTtbarCategorizer.cc) after merged cms-sw/cmssw#11559.

I have tested the code by using a command in CATTools/CatProducer/prod.

cmsRun PAT2CAT_cfg.py runOnRelVal=True useMiniAOD=True runGenTop=True

@jhgoh
Copy link
Contributor

jhgoh commented Sep 30, 2015

Thank you for update. Just for a confirmation - is the code in cmssw same to yours?

@YoungKwonJo
Copy link
Contributor Author

I used the recipe in the link.
https://www.cms-kr.org/twiki/bin/view/Computing/CATTools/DataSets/WebHome#2015 September v7-4-2
So I used CMSSW_7_4_12_patch4.
However I used the CaTTools as pull request version.

And, if we have to go cmss76x, we need to update few-things.
https://github.com/YoungKwonJo/CATTools/blob/cat75x/CatProducer/python/catGenHFHadronMatching_cff.py#L57
remove comment(#) in L57
remove CatProducer/plugins/GenTtbarCategorizer.cc
add comment(#) in L59

@jhgoh
Copy link
Contributor

jhgoh commented Sep 30, 2015

Event categorizer가 74X에 백포팅 될 예정이예요. 현재 PR이 올라가 있는데, 이게 나중에 merge되고 나면 plugin이 중복되기 때문에 미리 cattools에서 제거하고, 대신 현재 올라간 PR을 git-cms-merge-topic 하도록 installation recipe을 업데이트 하면 됩니다.

여기서 확인하고 싶은 것은 현재 74X backporting 으로 올라간 categorizer와 영권이형이 catTools에 포함시킨 categrizer가 같은 코드인지 확인했으면 합니다.

@YoungKwonJo
Copy link
Contributor Author

categorizer가 같지는 않습니다. w to b, w to c를 count할수 있도록 업데이트가 더 되어 있습니다.
아래와같은 설명이 추가가 되었습니다.

  • Then, b jets from W are identified, i.e. jets containing a b hadron from W->b decay
    
  • They are encoded in the ID as numberOfBjetsFromW*1000, i.e.
    
  • 0xxx: no b jets from W in acceptance
    
  • 1xxx: 1 b jet from W in acceptance
    
  • 2xxx: 2 b jets from W in acceptance
    
  • Then, c jets from W are identified, i.e. jets containing a c hadron from W->c decay, but no b hadrons
    
  • They are encoded in the ID as numberOfCjetsFromW*10000, i.e.
    
  • 0xxxx: no c jets from W in acceptance
    
  • 1xxxx: 1 c jet from W in acceptance
    
  • 2xxxx: 2 c jets from W in acceptance
    

앞으로 recipe.
remove > git cms-merge-topic YoungKwonJo:NewGenHFHadronMatcher_cmssw747p2
add > git cms-merge-topic bartosik-desy:CMSSSW_7_4_X_GenTtbarCategorizer

@jshlee
Copy link
Contributor

jshlee commented Oct 1, 2015

could you update this on the twiki please

@jhgoh
Copy link
Contributor

jhgoh commented Oct 1, 2015

Updated instruction.

git-cms-merge-topic 11559
# git cms-merge-topic YoungKwonJo:NewGenHFHadronMatcher_cmssw747p2

@jshlee
Copy link
Contributor

jshlee commented Oct 1, 2015

shall we merge this now?

@jhgoh
Copy link
Contributor

jhgoh commented Oct 1, 2015

+1

@jhgoh
Copy link
Contributor

jhgoh commented Oct 1, 2015

Will merge after unit test.

@jhgoh
Copy link
Contributor

jhgoh commented Oct 1, 2015

Some messages during testing. @YoungKwonJo can we simply ignore it?

In extremely rare instances the mismatch could be caused by a difference in the machine precision in which case make sure the original jet collection is produced and reclustering is performed in the same job.
%MSG
%MSG-w NullTransverseMomentum:  JetFlavourClustering:genJetFlavourInfos  01-Oct-2015 19:47:47 CEST Run: 1 Event: 1579
dropping input candidate with pt=0
%MSG
%MSG-e JetPtMismatch:  JetFlavourClustering:genJetFlavourInfos  01-Oct-2015 19:47:48 CEST Run: 1 Event: 1589
The reclustered and original jet 0 have different Pt's (72.0359 vs 72.6514 GeV, respectively).
Please check that the jet algorithm and jet size match those used for the original jet collection and also make sure the original jets are uncorrected. In addition, make sure you are not using CaloJets which are presently not supported.

@jhgoh
Copy link
Contributor

jhgoh commented Oct 1, 2015

Deleted comment about JetPartonMap stuff because it is not related w/ this PR.

@jhgoh
Copy link
Contributor

jhgoh commented Oct 1, 2015

This PR does nothing to the message from JetFlavourClustering, it is 100% due to the main CMSSW codes.
I think this PR can be merged, ready to go.

@jhgoh
Copy link
Contributor

jhgoh commented Oct 2, 2015

Merging this PR as the recipe already updated.

jhgoh added a commit that referenced this pull request Oct 2, 2015
update for Backport from 7_6_X: ttbar event categorizer, miniAOD jet flavour improvements
@jhgoh jhgoh merged commit edfa565 into vallot:cat75x Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants