fix(Backup/FileRestore): hide unsupported S3 backups (#6116)

Fixes https://xcp-ng.org/forum/post/46166
vatesfr · Feb 18, 2022 · 3842f5b · 3842f5b
1 parent 1dad6b3
commit 3842f5b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -13,6 +13,7 @@
 
 - [Self service] Change identifiers used for VM templates to avoid them from being removed on XCP-ng upgrade
 - [Proxy] Always connect to XAPI via [backup network if defined](https://xen-orchestra.com/blog/xen-orchestra-5-64/#backupmigrationnetwork)
+- [Backup/File restore] Do not list backups on non-compatible remotes (S3) (PR [#6116](https://github.com/vatesfr/xen-orchestra/pull/6116))
 
 ### Packages to release
 
@@ -39,3 +40,4 @@
 - @xen-orchestra/proxy patch
 - xo-cli minor
 - xo-server minor
+- xo-web patch
diff --git a/packages/xo-web/src/xo-app/backup/file-restore/index.js b/packages/xo-web/src/xo-app/backup/file-restore/index.js
@@ -86,7 +86,10 @@ export default class Restore extends Component {
   }
 
   _refreshBackupList = async (_remotes = this.props.remotes, jobs = this.props.jobs) => {
-    const remotes = keyBy(filter(_remotes, 'enabled'), 'id')
+    const remotes = keyBy(
+      filter(_remotes, remote => remote.enabled && remote.supportFileRestore),
+      'id'
+    )
     const backupsByRemote = await listVmBackups(toArray(remotes))
 
     const backupDataByVm = {}