Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Backup/FileRestore): does not take into consideration S3 backups #6116

Merged
merged 8 commits into from
Feb 18, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 10, 2022

See xcp-forum#5486

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Feb 10, 2022
@MathieuRA MathieuRA changed the title fix(Backup/FileRestore): does not take into consideration S3 backup fix(Backup/FileRestore): does not take into consideration S3 backups Feb 10, 2022
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add.

julien-f added a commit that referenced this pull request Feb 14, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <[email protected]>
@pdonias
Copy link
Member

pdonias commented Feb 17, 2022

Nothing to add after Julien's comment.

@MathieuRA MathieuRA requested a review from julien-f February 18, 2022 09:06
@julien-f julien-f merged commit 3842f5b into master Feb 18, 2022
@julien-f julien-f deleted the s3RestoreUI branch February 18, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants