-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(xapi/VDI_exportContent): can export from NBD #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
feat_nbd_vhd
branch
6 times, most recently
from
March 14, 2023 14:14
7c6bb83
to
de3ff25
Compare
fbeauchamp
changed the title
refactor(vhd-lib): read vhd from stream and nbd, create vhd directory
refactor(vhd-lib): read vhd from stream and nbd
Mar 14, 2023
fbeauchamp
force-pushed
the
feat_nbd_vhd
branch
5 times, most recently
from
March 15, 2023 14:58
35b4ee2
to
9d6ec88
Compare
fbeauchamp
force-pushed
the
feat_nbd_vhd
branch
from
March 16, 2023 13:12
9d6ec88
to
4602cb3
Compare
julien-f
reviewed
Mar 16, 2023
fbeauchamp
commented
Mar 16, 2023
fbeauchamp
commented
Mar 16, 2023
julien-f
reviewed
Mar 16, 2023
fbeauchamp
commented
Mar 16, 2023
julien-f
reviewed
Mar 16, 2023
fbeauchamp
force-pushed
the
feat_nbd_vhd
branch
3 times, most recently
from
March 17, 2023 15:38
d80ea0e
to
692e03f
Compare
julien-f
reviewed
Mar 19, 2023
julien-f
reviewed
Mar 19, 2023
julien-f
reviewed
Mar 19, 2023
julien-f
reviewed
Mar 19, 2023
julien-f
reviewed
Mar 19, 2023
julien-f
reviewed
Mar 19, 2023
julien-f
reviewed
Mar 19, 2023
fbeauchamp
force-pushed
the
feat_nbd_vhd
branch
from
March 27, 2023 18:29
eefadc9
to
952bf22
Compare
julien-f
reviewed
Mar 29, 2023
fbeauchamp
force-pushed
the
feat_nbd_vhd
branch
from
March 30, 2023 07:26
a61218a
to
232a80e
Compare
Co-authored-by: Julien Fontanet <[email protected]>
julien-f
changed the title
refactor(vhd-lib): read vhd from stream and nbd
refactor(xapi/VDI_exportContent): can export from NBD
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
use NBD wherever it's possible . Today, NBD is only used for delta backup on vhd block storage. In this case, the blocks are read in parallel, but this reading process is completly separated from other reading neeeding for other remotes or for continuous replication.
Impacts
NBD is used for
It is not used for
NBD block reading is done sequentially. It reads block only once even with multiple target of a backup job.
NBD is enabled as a xapi option : if a NBD network is present and is accessible between the VM and XO, it will be used.
NBD server is choosen at random between the available one. That means that if the VM use a shared storage, all the host of the pool can be used.
No more visible task during export , need to implement the new task system + UX
futures
review by commit
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: