-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: renderComponentContent lose slot props data #5466
Conversation
|
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1)
332-339
: LGTM! The fix properly preserves slot props data.The changes correctly ensure that both the slot's scope (
renderSlotProps
) and form context ($formContext
) are passed to theVbenRenderContent
component, fixing the slot props data loss issue.Consider adding JSDoc comments to document the props being passed to
VbenRenderContent
:<template v-for="name in renderContentKey" :key="name" #[name]="renderSlotProps" > + <!-- @prop renderSlotProps - Props from the dynamic slot's scope --> + <!-- @prop $formContext - Form context containing field state and helpers --> <VbenRenderContent :content="customContentRender[name]" v-bind="{ ...renderSlotProps, $formContext: slotProps }" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: post-update (windows-latest)
* 修复FormItem传递插槽时丢失插槽props的问题
Description
修复表单的renderComponentContent传递插槽时,会丢失插槽数据的问题。
formField渲染自定义组件的内部插槽时,没有正确传递原本的props。
fix #5464
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit