Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(influxdb_logs): encode influx line when no tags present #17029

Merged
merged 4 commits into from
Apr 14, 2023
Merged

fix(influxdb_logs): encode influx line when no tags present #17029

merged 4 commits into from
Apr 14, 2023

Conversation

juvenn
Copy link
Contributor

@juvenn juvenn commented Apr 1, 2023

When trying to sink log without tags into influxdb, influxdb will error out expected tag key after comma. Which means the comma , should be omitted if there are no tags.

logs, message="hello world" # current behavior, which is invalid
logs message="hello world"  # expected behavior

Close #17020

@juvenn juvenn requested a review from a team April 1, 2023 10:41
@netlify
Copy link

netlify bot commented Apr 1, 2023 •
edited
Loading

✅ Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 3fab407
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/642ce22bbc7fc90008c1cd66

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Apr 1, 2023
juvenn
juvenn commented Apr 1, 2023
View reviewed changes
src/sinks/influxdb/logs.rs Show resolved Hide resolved
src/sinks/influxdb/logs.rs Outdated
let mut encoder = sink.build_encoder();

let bytes = encoder.encode_event(event).unwrap();
let string = std::str::from_utf8(&bytes).unwrap();
let line = std::str::from_utf8(&bytes).unwrap();
assert!(line.starts_with("vector "));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have no comma after measurement.

src/sinks/influxdb/logs.rs Outdated
assert_eq!("vector", line_protocol.0);
assert_eq!("metric_type=logs", line_protocol.1);
assert_eq!("", line_protocol.1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tags present

src/sinks/influxdb/mod.rs

(measurement, split[0], split[1].to_string(), split[2])
(measurement, tags, fields.to_string(), ts)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tags and timestamp are optional.

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Regression Detector Results

Run ID: 40f29498-91f3-4ed0-843b-cc97110fe6c5
Baseline: 00c0316
Comparison: 0d804dd
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics ingress throughput 68.33KiB/CPU-s 1.84 100.00% 3.62MiB/CPU-s 427.95KiB/CPU-s 5.27KiB/CPU-s 0.0 0.115487 3.69MiB/CPU-s 408.56KiB/CPU-s 5.03KiB/CPU-s 0.0 0.108258 True True
syslog_log2metric_humio_metrics ingress throughput 64.93KiB/CPU-s 1.04 100.00% 6.09MiB/CPU-s 358.11KiB/CPU-s 4.41KiB/CPU-s 0.0 0.057381 6.16MiB/CPU-s 377.76KiB/CPU-s 4.65KiB/CPU-s 0.0 0.059907 False False
otlp_grpc_to_blackhole ingress throughput 10.0KiB/CPU-s 0.96 100.00% 1.01MiB/CPU-s 49.92KiB/CPU-s 629.04B/CPU-s 0.0 0.048075 1.02MiB/CPU-s 46.39KiB/CPU-s 584.56B/CPU-s 0.0 0.044245 False False
datadog_agent_remap_datadog_logs ingress throughput 55.8KiB/CPU-s 0.17 99.99% 32.68MiB/CPU-s 701.46KiB/CPU-s 8.63KiB/CPU-s 0.0 0.02096 32.73MiB/CPU-s 900.84KiB/CPU-s 11.09KiB/CPU-s 0.0 0.026873 False False
datadog_agent_remap_datadog_logs_acks ingress throughput 20.1KiB/CPU-s 0.06 63.28% 32.16MiB/CPU-s 1.53MiB/CPU-s 19.26KiB/CPU-s 0.0 0.047543 32.18MiB/CPU-s 911.5KiB/CPU-s 11.22KiB/CPU-s 0.0 0.027663 False False
http_to_http_noack ingress throughput 7.5KiB/CPU-s 0.05 79.35% 13.61MiB/CPU-s 377.87KiB/CPU-s 4.65KiB/CPU-s 0.0 0.027116 13.61MiB/CPU-s 299.87KiB/CPU-s 3.69KiB/CPU-s 0.0 0.021508 False False
http_to_http_json ingress throughput 927.62B/CPU-s 0.01 17.97% 13.62MiB/CPU-s 230.58KiB/CPU-s 2.84KiB/CPU-s 0.0 0.016531 13.62MiB/CPU-s 227.87KiB/CPU-s 2.8KiB/CPU-s 0.0 0.016335 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 377.15B/CPU-s 0.00 4.77% 13.61MiB/CPU-s 355.56KiB/CPU-s 4.37KiB/CPU-s 0.0 0.025504 13.61MiB/CPU-s 352.92KiB/CPU-s 4.34KiB/CPU-s 0.0 0.025314 False False
splunk_hec_indexer_ack_blackhole ingress throughput -105.32B/CPU-s -0.00 1.79% 13.61MiB/CPU-s 264.67KiB/CPU-s 3.26KiB/CPU-s 0.0 0.018983 13.61MiB/CPU-s 262.22KiB/CPU-s 3.23KiB/CPU-s 0.0 0.018808 False False
enterprise_http_to_http ingress throughput -262.19B/CPU-s -0.00 6.21% 13.62MiB/CPU-s 188.73KiB/CPU-s 2.32KiB/CPU-s 0.0 0.013528 13.62MiB/CPU-s 188.95KiB/CPU-s 2.33KiB/CPU-s 0.0 0.013544 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -994.08B/CPU-s -0.01 16.18% 13.61MiB/CPU-s 271.26KiB/CPU-s 3.34KiB/CPU-s 0.0 0.019456 13.61MiB/CPU-s 275.33KiB/CPU-s 3.39KiB/CPU-s 0.0 0.019749 False False
fluent_elasticsearch ingress throughput -9.73KiB/CPU-s -0.02 82.67% 45.41MiB/CPU-s 30.59KiB/CPU-s 381.21B/CPU-s 0.0 0.000658 45.41MiB/CPU-s 586.14KiB/CPU-s 7.14KiB/CPU-s 0.0 0.012606 False False
syslog_loki ingress throughput -31.48KiB/CPU-s -0.37 100.00% 8.39MiB/CPU-s 260.42KiB/CPU-s 3.2KiB/CPU-s 0.0 0.030299 8.36MiB/CPU-s 214.57KiB/CPU-s 2.64KiB/CPU-s 0.0 0.025056 False False
datadog_agent_remap_blackhole_acks ingress throughput -118.57KiB/CPU-s -0.37 100.00% 30.93MiB/CPU-s 890.58KiB/CPU-s 10.96KiB/CPU-s 0.0 0.028118 30.81MiB/CPU-s 682.21KiB/CPU-s 8.4KiB/CPU-s 0.0 0.02162 False False
syslog_humio_logs ingress throughput -40.15KiB/CPU-s -0.43 100.00% 9.08MiB/CPU-s 198.29KiB/CPU-s 2.44KiB/CPU-s 0.0 0.021316 9.04MiB/CPU-s 264.14KiB/CPU-s 3.25KiB/CPU-s 0.0 0.028519 False False
datadog_agent_remap_blackhole ingress throughput -160.62KiB/CPU-s -0.51 100.00% 31.06MiB/CPU-s 979.4KiB/CPU-s 12.05KiB/CPU-s 0.0 0.030795 30.9MiB/CPU-s 897.67KiB/CPU-s 11.05KiB/CPU-s 0.0 0.028368 False False
socket_to_socket_blackhole ingress throughput -82.23KiB/CPU-s -0.61 100.00% 13.14MiB/CPU-s 422.83KiB/CPU-s 5.2KiB/CPU-s 0.0 0.031432 13.06MiB/CPU-s 254.11KiB/CPU-s 3.13KiB/CPU-s 0.0 0.019006 False False
splunk_hec_route_s3 ingress throughput -77.75KiB/CPU-s -0.65 100.00% 11.7MiB/CPU-s 543.53KiB/CPU-s 6.69KiB/CPU-s 0.0 0.045376 11.62MiB/CPU-s 531.96KiB/CPU-s 6.55KiB/CPU-s 0.0 0.044701 False False
http_to_http_acks ingress throughput -48.14KiB/CPU-s -0.89 67.99% 5.26MiB/CPU-s 2.73MiB/CPU-s 34.41KiB/CPU-s 0.0 0.51899 5.21MiB/CPU-s 2.7MiB/CPU-s 34.06KiB/CPU-s 0.0 0.518288 True False
syslog_splunk_hec_logs ingress throughput -89.32KiB/CPU-s -0.97 100.00% 9.0MiB/CPU-s 239.08KiB/CPU-s 2.94KiB/CPU-s 0.0 0.025928 8.92MiB/CPU-s 262.72KiB/CPU-s 3.23KiB/CPU-s 0.0 0.028771 False False
otlp_http_to_blackhole ingress throughput -17.21KiB/CPU-s -1.09 100.00% 1.54MiB/CPU-s 118.83KiB/CPU-s 1.46KiB/CPU-s 0.0 0.075183 1.53MiB/CPU-s 120.77KiB/CPU-s 1.49KiB/CPU-s 0.0 0.077249 False False
http_text_to_http_json ingress throughput -282.5KiB/CPU-s -1.16 100.00% 23.79MiB/CPU-s 521.51KiB/CPU-s 6.42KiB/CPU-s 0.0 0.021404 23.52MiB/CPU-s 790.01KiB/CPU-s 9.72KiB/CPU-s 0.0 0.032804 False False
syslog_log2metric_splunk_hec_metrics ingress throughput -175.43KiB/CPU-s -1.83 100.00% 9.35MiB/CPU-s 227.51KiB/CPU-s 2.8KiB/CPU-s 0.0 0.023762 9.18MiB/CPU-s 269.75KiB/CPU-s 3.32KiB/CPU-s 0.0 0.0287 False False
file_to_blackhole egress throughput -847.29KiB/CPU-s -12.24 100.00% 6.76MiB/CPU-s 4.3MiB/CPU-s 131.3KiB/CPU-s 2.758007 0.63542 5.94MiB/CPU-s 4.41MiB/CPU-s 122.01KiB/CPU-s 0.0 0.742502 True True

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Regression Detector Results

Run ID: 000f63ee-b391-4b48-b548-65be494a5e70
Baseline: 00c0316
Comparison: bb560db
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs ingress throughput 598.72KiB/CPU-s 1.81 100.00% 32.22MiB/CPU-s 1.45MiB/CPU-s 18.25KiB/CPU-s 0.0 0.044952 32.81MiB/CPU-s 971.11KiB/CPU-s 11.95KiB/CPU-s 0.0 0.028904 False False
syslog_regex_logs2metric_ddmetrics ingress throughput 44.96KiB/CPU-s 1.23 100.00% 3.56MiB/CPU-s 313.61KiB/CPU-s 3.86KiB/CPU-s 0.0 0.086042 3.6MiB/CPU-s 411.89KiB/CPU-s 5.07KiB/CPU-s 0.0 0.111628 True True
http_to_http_acks ingress throughput 43.05KiB/CPU-s 0.80 62.99% 5.23MiB/CPU-s 2.69MiB/CPU-s 33.92KiB/CPU-s 0.0 0.514497 5.27MiB/CPU-s 2.7MiB/CPU-s 34.01KiB/CPU-s 0.0 0.511738 True False
otlp_grpc_to_blackhole ingress throughput 6.72KiB/CPU-s 0.65 100.00% 1.01MiB/CPU-s 58.3KiB/CPU-s 734.48B/CPU-s 0.0 0.056466 1.01MiB/CPU-s 47.26KiB/CPU-s 595.51B/CPU-s 0.0 0.045473 False False
datadog_agent_remap_blackhole_acks ingress throughput 194.57KiB/CPU-s 0.62 100.00% 30.58MiB/CPU-s 1.2MiB/CPU-s 15.15KiB/CPU-s 0.0 0.039325 30.77MiB/CPU-s 1.13MiB/CPU-s 14.3KiB/CPU-s 0.0 0.036858 False False
splunk_hec_route_s3 ingress throughput 56.94KiB/CPU-s 0.48 100.00% 11.52MiB/CPU-s 574.81KiB/CPU-s 7.07KiB/CPU-s 0.0 0.048702 11.58MiB/CPU-s 555.28KiB/CPU-s 6.83KiB/CPU-s 0.0 0.046822 False False
http_to_http_json ingress throughput 51.45KiB/CPU-s 0.37 100.00% 13.57MiB/CPU-s 304.63KiB/CPU-s 3.75KiB/CPU-s 0.0 0.021918 13.62MiB/CPU-s 224.04KiB/CPU-s 2.76KiB/CPU-s 0.0 0.016061 False False
datadog_agent_remap_datadog_logs_acks ingress throughput 117.7KiB/CPU-s 0.36 100.00% 32.15MiB/CPU-s 940.87KiB/CPU-s 11.58KiB/CPU-s 0.0 0.028578 32.26MiB/CPU-s 777.87KiB/CPU-s 9.57KiB/CPU-s 0.0 0.023543 False False
syslog_splunk_hec_logs ingress throughput 11.73KiB/CPU-s 0.13 99.40% 8.91MiB/CPU-s 247.66KiB/CPU-s 3.05KiB/CPU-s 0.0 0.02714 8.92MiB/CPU-s 243.28KiB/CPU-s 2.99KiB/CPU-s 0.0 0.026625 False False
syslog_humio_logs ingress throughput 11.34KiB/CPU-s 0.12 96.69% 8.97MiB/CPU-s 338.11KiB/CPU-s 4.16KiB/CPU-s 0.0 0.036791 8.98MiB/CPU-s 269.71KiB/CPU-s 3.32KiB/CPU-s 0.0 0.029313 False False
enterprise_http_to_http ingress throughput 3.8KiB/CPU-s 0.03 67.64% 13.62MiB/CPU-s 248.15KiB/CPU-s 3.05KiB/CPU-s 0.0 0.017793 13.62MiB/CPU-s 190.4KiB/CPU-s 2.34KiB/CPU-s 0.0 0.013649 False False
splunk_hec_indexer_ack_blackhole ingress throughput 2.48KiB/CPU-s 0.02 41.65% 13.61MiB/CPU-s 265.54KiB/CPU-s 3.27KiB/CPU-s 0.0 0.019046 13.62MiB/CPU-s 254.44KiB/CPU-s 3.13KiB/CPU-s 0.0 0.018247 False False
http_to_http_noack ingress throughput 1.63KiB/CPU-s 0.01 20.25% 13.61MiB/CPU-s 371.44KiB/CPU-s 4.57KiB/CPU-s 0.0 0.026654 13.61MiB/CPU-s 357.93KiB/CPU-s 4.4KiB/CPU-s 0.0 0.025682 False False
fluent_elasticsearch ingress throughput -340.82B/CPU-s -0.00 47.92% 45.41MiB/CPU-s 29.96KiB/CPU-s 373.44B/CPU-s 0.0 0.000644 45.41MiB/CPU-s 30.27KiB/CPU-s 377.25B/CPU-s 0.0 0.000651 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 644.49B/CPU-s 0.00 7.87% 13.61MiB/CPU-s 370.53KiB/CPU-s 4.56KiB/CPU-s 0.0 0.026577 13.61MiB/CPU-s 362.08KiB/CPU-s 4.45KiB/CPU-s 0.0 0.02597 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -1.95KiB/CPU-s -0.01 34.01% 13.62MiB/CPU-s 249.74KiB/CPU-s 3.07KiB/CPU-s 0.0 0.017908 13.62MiB/CPU-s 259.11KiB/CPU-s 3.19KiB/CPU-s 0.0 0.018582 False False
datadog_agent_remap_blackhole ingress throughput -32.83KiB/CPU-s -0.10 95.54% 31.08MiB/CPU-s 1.04MiB/CPU-s 13.04KiB/CPU-s 0.0 0.033309 31.05MiB/CPU-s 800.14KiB/CPU-s 9.85KiB/CPU-s 0.0 0.025167 False False
file_to_blackhole egress throughput -17.62KiB/CPU-s -0.25 7.81% 6.9MiB/CPU-s 4.2MiB/CPU-s 127.0KiB/CPU-s 5.657093 0.609341 6.88MiB/CPU-s 4.34MiB/CPU-s 127.08KiB/CPU-s 0.326531 0.631186 True True
socket_to_socket_blackhole ingress throughput -69.39KiB/CPU-s -0.52 100.00% 12.97MiB/CPU-s 349.43KiB/CPU-s 4.3KiB/CPU-s 0.0 0.026302 12.91MiB/CPU-s 342.18KiB/CPU-s 4.21KiB/CPU-s 0.0 0.025892 False False
syslog_loki ingress throughput -62.04KiB/CPU-s -0.72 100.00% 8.41MiB/CPU-s 220.73KiB/CPU-s 2.71KiB/CPU-s 0.0 0.025623 8.35MiB/CPU-s 215.63KiB/CPU-s 2.78KiB/CPU-s 0.0 0.025212 False False
syslog_log2metric_humio_metrics ingress throughput -50.14KiB/CPU-s -0.80 100.00% 6.13MiB/CPU-s 155.42KiB/CPU-s 1.91KiB/CPU-s 0.0 0.024774 6.08MiB/CPU-s 248.7KiB/CPU-s 3.06KiB/CPU-s 0.0 0.039963 False False
otlp_http_to_blackhole ingress throughput -18.42KiB/CPU-s -1.17 100.00% 1.54MiB/CPU-s 116.2KiB/CPU-s 1.43KiB/CPU-s 0.0 0.07386 1.52MiB/CPU-s 119.92KiB/CPU-s 1.48KiB/CPU-s 0.0 0.077132 False False
http_text_to_http_json ingress throughput -296.71KiB/CPU-s -1.22 100.00% 23.73MiB/CPU-s 536.53KiB/CPU-s 6.6KiB/CPU-s 0.0 0.022081 23.44MiB/CPU-s 618.25KiB/CPU-s 7.61KiB/CPU-s 0.0 0.025759 False False
syslog_log2metric_splunk_hec_metrics ingress throughput -165.63KiB/CPU-s -1.73 100.00% 9.35MiB/CPU-s 187.14KiB/CPU-s 2.42KiB/CPU-s 0.0 0.019548 9.19MiB/CPU-s 260.95KiB/CPU-s 3.21KiB/CPU-s 0.0 0.027738 False False

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Regression Detector Results

Run ID: c9cd90ae-8359-421e-badc-16ab51fe30c4
Baseline: 00c0316
Comparison: 8e6118b
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics ingress throughput 80.34KiB/CPU-s 2.17 100.00% 3.62MiB/CPU-s 362.58KiB/CPU-s 4.46KiB/CPU-s 0.0 0.097916 3.69MiB/CPU-s 415.71KiB/CPU-s 5.12KiB/CPU-s 0.0 0.10988 True True
syslog_log2metric_humio_metrics ingress throughput 104.52KiB/CPU-s 1.66 100.00% 6.14MiB/CPU-s 213.69KiB/CPU-s 2.63KiB/CPU-s 0.0 0.034 6.24MiB/CPU-s 152.23KiB/CPU-s 1.87KiB/CPU-s 0.0 0.023824 False False
http_to_http_acks ingress throughput 83.42KiB/CPU-s 1.57 91.13% 5.19MiB/CPU-s 2.72MiB/CPU-s 34.28KiB/CPU-s 0.0 0.523578 5.28MiB/CPU-s 2.78MiB/CPU-s 35.02KiB/CPU-s 0.0 0.526803 True False
datadog_agent_remap_datadog_logs_acks ingress throughput 500.66KiB/CPU-s 1.53 100.00% 31.89MiB/CPU-s 1.08MiB/CPU-s 13.6KiB/CPU-s 0.0 0.033848 32.37MiB/CPU-s 893.1KiB/CPU-s 10.99KiB/CPU-s 0.0 0.026938 False False
syslog_humio_logs ingress throughput 25.53KiB/CPU-s 0.27 100.00% 9.07MiB/CPU-s 244.82KiB/CPU-s 3.01KiB/CPU-s 0.0 0.026363 9.09MiB/CPU-s 216.54KiB/CPU-s 2.66KiB/CPU-s 0.0 0.023254 False False
http_to_http_json ingress throughput 18.98KiB/CPU-s 0.14 99.97% 13.56MiB/CPU-s 311.09KiB/CPU-s 3.83KiB/CPU-s 0.0 0.022403 13.58MiB/CPU-s 293.96KiB/CPU-s 3.62KiB/CPU-s 0.0 0.021141 False False
datadog_agent_remap_datadog_logs ingress throughput 29.15KiB/CPU-s 0.09 85.50% 32.37MiB/CPU-s 966.78KiB/CPU-s 11.9KiB/CPU-s 0.0 0.029163 32.4MiB/CPU-s 1.28MiB/CPU-s 16.08KiB/CPU-s 0.0 0.039398 False False
enterprise_http_to_http ingress throughput 1.9KiB/CPU-s 0.01 40.30% 13.62MiB/CPU-s 222.35KiB/CPU-s 2.74KiB/CPU-s 0.0 0.015941 13.62MiB/CPU-s 189.88KiB/CPU-s 2.34KiB/CPU-s 0.0 0.013611 False False
fluent_elasticsearch ingress throughput 125.49B/CPU-s 0.00 18.66% 45.41MiB/CPU-s 30.36KiB/CPU-s 378.37B/CPU-s 0.0 0.000653 45.41MiB/CPU-s 29.98KiB/CPU-s 373.63B/CPU-s 0.0 0.000645 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 344.26B/CPU-s 0.00 4.25% 13.61MiB/CPU-s 344.42KiB/CPU-s 4.24KiB/CPU-s 0.0 0.024705 13.61MiB/CPU-s 379.43KiB/CPU-s 4.67KiB/CPU-s 0.0 0.027216 False False
splunk_hec_indexer_ack_blackhole ingress throughput -687.57B/CPU-s -0.00 11.95% 13.62MiB/CPU-s 254.5KiB/CPU-s 3.13KiB/CPU-s 0.0 0.018251 13.62MiB/CPU-s 259.09KiB/CPU-s 3.19KiB/CPU-s 0.0 0.018581 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -3.34KiB/CPU-s -0.02 53.00% 13.62MiB/CPU-s 254.48KiB/CPU-s 3.13KiB/CPU-s 0.0 0.018249 13.61MiB/CPU-s 276.11KiB/CPU-s 3.4KiB/CPU-s 0.0 0.019805 False False
http_to_http_noack ingress throughput -3.75KiB/CPU-s -0.03 45.02% 13.61MiB/CPU-s 341.07KiB/CPU-s 4.2KiB/CPU-s 0.0 0.024469 13.61MiB/CPU-s 377.87KiB/CPU-s 4.65KiB/CPU-s 0.0 0.027116 False False
otlp_http_to_blackhole ingress throughput -4.69KiB/CPU-s -0.30 97.62% 1.53MiB/CPU-s 121.34KiB/CPU-s 1.49KiB/CPU-s 0.0 0.07731 1.53MiB/CPU-s 117.24KiB/CPU-s 1.44KiB/CPU-s 0.0 0.074922 False False
http_text_to_http_json ingress throughput -108.69KiB/CPU-s -0.45 100.00% 23.54MiB/CPU-s 579.75KiB/CPU-s 7.13KiB/CPU-s 0.0 0.024045 23.44MiB/CPU-s 636.06KiB/CPU-s 7.83KiB/CPU-s 0.0 0.0265 False False
syslog_loki ingress throughput -49.86KiB/CPU-s -0.58 100.00% 8.34MiB/CPU-s 301.29KiB/CPU-s 3.71KiB/CPU-s 0.0 0.035271 8.29MiB/CPU-s 325.31KiB/CPU-s 4.0KiB/CPU-s 0.0 0.038306 False False
otlp_grpc_to_blackhole ingress throughput -7.92KiB/CPU-s -0.76 100.00% 1.02MiB/CPU-s 46.07KiB/CPU-s 580.49B/CPU-s 0.0 0.044047 1.01MiB/CPU-s 48.16KiB/CPU-s 606.8B/CPU-s 0.0 0.046394 False False
splunk_hec_route_s3 ingress throughput -92.59KiB/CPU-s -0.78 100.00% 11.64MiB/CPU-s 528.99KiB/CPU-s 6.51KiB/CPU-s 0.0 0.044396 11.54MiB/CPU-s 561.5KiB/CPU-s 6.91KiB/CPU-s 0.0 0.047494 False False
datadog_agent_remap_blackhole ingress throughput -278.48KiB/CPU-s -0.88 100.00% 30.75MiB/CPU-s 1.04MiB/CPU-s 13.05KiB/CPU-s 0.0 0.033688 30.48MiB/CPU-s 875.38KiB/CPU-s 10.77KiB/CPU-s 0.0 0.028047 False False
syslog_splunk_hec_logs ingress throughput -89.37KiB/CPU-s -0.97 100.00% 9.0MiB/CPU-s 223.81KiB/CPU-s 2.75KiB/CPU-s 0.0 0.024274 8.92MiB/CPU-s 204.08KiB/CPU-s 2.51KiB/CPU-s 0.0 0.022352 False False
socket_to_socket_blackhole ingress throughput -150.55KiB/CPU-s -1.12 100.00% 13.11MiB/CPU-s 252.69KiB/CPU-s 3.11KiB/CPU-s 0.0 0.018816 12.97MiB/CPU-s 269.25KiB/CPU-s 3.31KiB/CPU-s 0.0 0.020276 False False
datadog_agent_remap_blackhole_acks ingress throughput -373.46KiB/CPU-s -1.18 100.00% 30.89MiB/CPU-s 1.11MiB/CPU-s 13.93KiB/CPU-s 0.0 0.035803 30.52MiB/CPU-s 1.15MiB/CPU-s 14.55KiB/CPU-s 0.0 0.037807 False False
syslog_log2metric_splunk_hec_metrics ingress throughput -162.79KiB/CPU-s -1.70 100.00% 9.33MiB/CPU-s 177.79KiB/CPU-s 2.19KiB/CPU-s 0.0 0.01861 9.17MiB/CPU-s 322.3KiB/CPU-s 3.97KiB/CPU-s 0.0 0.034322 False False
file_to_blackhole egress throughput -1.21MiB/CPU-s -16.69 100.00% 7.27MiB/CPU-s 3.98MiB/CPU-s 134.0KiB/CPU-s 0.0 0.546211 6.06MiB/CPU-s 4.52MiB/CPU-s 123.55KiB/CPU-s 0.0 0.745403 True True

spencergilbert
spencergilbert approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

bruceg
bruceg approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct and the testing is great, particularly with the explanations. I have a couple of non-blocking suggestions below.

src/sinks/influxdb/mod.rs Outdated
Comment on lines 250 to 256
if unwrapped_tags.is_empty() {
line_protocol.put_u8(b' ');
} else {
line_protocol.put_u8(b',');
encode_tags(unwrapped_tags, line_protocol);
line_protocol.put_u8(b' ');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could technically de-duplicate this trailing put:

Suggested change
if unwrapped_tags.is_empty() {
line_protocol.put_u8(b' ');
} else {
line_protocol.put_u8(b',');
encode_tags(unwrapped_tags, line_protocol);
line_protocol.put_u8(b' ');
}
if !unwrapped_tags.is_empty() {
line_protocol.put_u8(b',');
encode_tags(unwrapped_tags, line_protocol);
}
line_protocol.put_u8(b' ');

src/sinks/influxdb/mod.rs Outdated
Comment on lines 449 to 452
// tags and ts may not be present
let parts: Vec<&str> = line_protocol.splitn(2, ' ').collect();
let (measurement, tags) = parts[0].split_once(',').unwrap_or((parts[0], ""));
let (fields, ts) = parts[1].split_once(' ').unwrap_or((parts[1], ""));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to use split_once instead of splitn(2) here, as it doesn't need to allocate a new Vec for the results. However, as a test it doesn't really matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bruceg , they are all nice suggestions, and I'm learning from it. I'll update them soon.

src/sinks/influxdb/logs.rs Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Apr 5, 2023 •
edited
Loading

✅ Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 3fab407
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/642ce22b249ad80008eeb745

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Regression Detector Results

Run ID: 919119c8-30bf-4982-96f1-6c789da1f67e
Baseline: 5074d82
Comparison: 3fab407
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole ingress throughput 674.47KiB/CPU-s 2.15 100.00% 30.62MiB/CPU-s 1.23MiB/CPU-s 15.5KiB/CPU-s 0.0 0.040191 31.28MiB/CPU-s 934.96KiB/CPU-s 11.5KiB/CPU-s 0.0 0.029187 False False
syslog_log2metric_splunk_hec_metrics ingress throughput 65.0KiB/CPU-s 0.69 100.00% 9.17MiB/CPU-s 295.77KiB/CPU-s 3.64KiB/CPU-s 0.0 0.031504 9.23MiB/CPU-s 317.99KiB/CPU-s 3.91KiB/CPU-s 0.0 0.033637 False False
syslog_splunk_hec_logs ingress throughput 22.48KiB/CPU-s 0.25 100.00% 8.91MiB/CPU-s 258.58KiB/CPU-s 3.18KiB/CPU-s 0.0 0.028353 8.93MiB/CPU-s 224.55KiB/CPU-s 2.76KiB/CPU-s 0.0 0.024561 False False
enterprise_http_to_http ingress throughput 5.69KiB/CPU-s 0.04 83.25% 13.62MiB/CPU-s 275.16KiB/CPU-s 3.39KiB/CPU-s 0.0 0.019732 13.62MiB/CPU-s 190.86KiB/CPU-s 2.35KiB/CPU-s 0.0 0.013681 False False
splunk_hec_indexer_ack_blackhole ingress throughput 1.96KiB/CPU-s 0.01 32.91% 13.61MiB/CPU-s 268.71KiB/CPU-s 3.3KiB/CPU-s 0.0 0.019274 13.62MiB/CPU-s 260.49KiB/CPU-s 3.2KiB/CPU-s 0.0 0.018682 False False
fluent_elasticsearch ingress throughput -169.21B/CPU-s -0.00 24.89% 45.41MiB/CPU-s 29.87KiB/CPU-s 372.39B/CPU-s 0.0 0.000642 45.41MiB/CPU-s 30.64KiB/CPU-s 381.92B/CPU-s 0.0 0.000659 False False
http_to_http_noack ingress throughput -25.67B/CPU-s -0.00 0.32% 13.61MiB/CPU-s 356.44KiB/CPU-s 4.38KiB/CPU-s 0.0 0.025574 13.61MiB/CPU-s 355.92KiB/CPU-s 4.38KiB/CPU-s 0.0 0.025537 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 284.01B/CPU-s 0.00 3.55% 13.61MiB/CPU-s 355.66KiB/CPU-s 4.37KiB/CPU-s 0.0 0.025511 13.61MiB/CPU-s 360.72KiB/CPU-s 4.44KiB/CPU-s 0.0 0.025873 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -54.0B/CPU-s -0.00 0.90% 13.61MiB/CPU-s 269.72KiB/CPU-s 3.32KiB/CPU-s 0.0 0.019345 13.61MiB/CPU-s 268.58KiB/CPU-s 3.3KiB/CPU-s 0.0 0.019263 False False
datadog_agent_remap_datadog_logs_acks ingress throughput -7.65KiB/CPU-s -0.02 26.57% 32.02MiB/CPU-s 1.45MiB/CPU-s 18.31KiB/CPU-s 0.0 0.045385 32.02MiB/CPU-s 1.04MiB/CPU-s 13.16KiB/CPU-s 0.0 0.032615 False False
http_to_http_acks ingress throughput -2.03KiB/CPU-s -0.04 3.33% 5.19MiB/CPU-s 2.71MiB/CPU-s 34.15KiB/CPU-s 0.0 0.522645 5.18MiB/CPU-s 2.74MiB/CPU-s 34.53KiB/CPU-s 0.0 0.528751 True False
syslog_humio_logs ingress throughput -18.45KiB/CPU-s -0.20 99.88% 8.95MiB/CPU-s 343.2KiB/CPU-s 4.22KiB/CPU-s 0.0 0.037435 8.93MiB/CPU-s 311.47KiB/CPU-s 3.83KiB/CPU-s 0.0 0.034043 False False
splunk_hec_route_s3 ingress throughput -47.81KiB/CPU-s -0.40 100.00% 11.65MiB/CPU-s 540.31KiB/CPU-s 6.65KiB/CPU-s 0.0 0.045284 11.6MiB/CPU-s 624.16KiB/CPU-s 7.68KiB/CPU-s 0.0 0.052522 False False
http_to_http_json ingress throughput -95.78KiB/CPU-s -0.69 100.00% 13.62MiB/CPU-s 228.22KiB/CPU-s 2.81KiB/CPU-s 0.0 0.016361 13.53MiB/CPU-s 349.16KiB/CPU-s 4.29KiB/CPU-s 0.0 0.025205 False False
syslog_loki ingress throughput -77.87KiB/CPU-s -0.90 100.00% 8.5MiB/CPU-s 233.29KiB/CPU-s 2.87KiB/CPU-s 0.0 0.026815 8.42MiB/CPU-s 226.74KiB/CPU-s 2.79KiB/CPU-s 0.0 0.026297 False False
syslog_regex_logs2metric_ddmetrics ingress throughput -37.68KiB/CPU-s -1.03 100.00% 3.57MiB/CPU-s 374.03KiB/CPU-s 4.6KiB/CPU-s 0.0 0.102348 3.53MiB/CPU-s 380.31KiB/CPU-s 4.68KiB/CPU-s 0.0 0.105149 True True
datadog_agent_remap_blackhole_acks ingress throughput -499.77KiB/CPU-s -1.57 100.00% 31.11MiB/CPU-s 1.34MiB/CPU-s 16.87KiB/CPU-s 0.0 0.04303 30.62MiB/CPU-s 942.0KiB/CPU-s 11.59KiB/CPU-s 0.0 0.030039 False False
datadog_agent_remap_datadog_logs ingress throughput -599.44KiB/CPU-s -1.78 100.00% 32.89MiB/CPU-s 772.13KiB/CPU-s 9.5KiB/CPU-s 0.0 0.022926 32.3MiB/CPU-s 1.07MiB/CPU-s 13.44KiB/CPU-s 0.0 0.033027 False False
syslog_log2metric_humio_metrics ingress throughput -167.8KiB/CPU-s -2.60 100.00% 6.3MiB/CPU-s 155.5KiB/CPU-s 1.91KiB/CPU-s 0.0 0.024106 6.13MiB/CPU-s 373.24KiB/CPU-s 4.59KiB/CPU-s 0.0 0.059407 False False
socket_to_socket_blackhole ingress throughput -436.36KiB/CPU-s -3.17 100.00% 13.46MiB/CPU-s 254.12KiB/CPU-s 3.13KiB/CPU-s 0.0 0.018433 13.04MiB/CPU-s 254.64KiB/CPU-s 3.13KiB/CPU-s 0.0 0.019075 False False
http_text_to_http_json ingress throughput -887.2KiB/CPU-s -3.55 100.00% 24.4MiB/CPU-s 815.43KiB/CPU-s 10.03KiB/CPU-s 0.0 0.032628 23.54MiB/CPU-s 588.81KiB/CPU-s 7.25KiB/CPU-s 0.0 0.024427 False False
otlp_grpc_to_blackhole ingress throughput -43.54KiB/CPU-s -4.01 100.00% 1.06MiB/CPU-s 49.89KiB/CPU-s 628.54B/CPU-s 0.0 0.045943 1.02MiB/CPU-s 46.56KiB/CPU-s 586.74B/CPU-s 0.0 0.044665 False False
otlp_http_to_blackhole ingress throughput -69.2KiB/CPU-s -4.26 100.00% 1.59MiB/CPU-s 101.56KiB/CPU-s 1.25KiB/CPU-s 0.0 0.062522 1.52MiB/CPU-s 123.16KiB/CPU-s 1.52KiB/CPU-s 0.0 0.079193 False False
file_to_blackhole egress throughput -825.17KiB/CPU-s -12.66 100.00% 6.36MiB/CPU-s 4.46MiB/CPU-s 123.57KiB/CPU-s 0.0 0.699971 5.56MiB/CPU-s 4.6MiB/CPU-s 116.76KiB/CPU-s 0.0 0.827075 True True

@juvenn
Copy link
Contributor Author

juvenn commented Apr 10, 2023

Hi @bruceg , please take another look.

@spencergilbert
Copy link
Contributor

Looks good, thanks @juvenn!

@spencergilbert spencergilbert merged commit c3aa14f into vectordotdev:master Apr 14, 2023
@juvenn juvenn deleted the fix/influx-tags branch April 14, 2023 15:32
aholmberg pushed a commit to aholmberg/vector that referenced this pull request Feb 14, 2024
@logdnabot
chore(release): 1.13.0 [skip ci]
098e7ba 
# [1.13.0](answerbook/vector@v1.12.1...v1.13.0) (2023-09-13)

### Bug Fixes

* **appsignal sink**: Add TLS config option (vectordotdev#17122) [198068c](answerbook/vector@198068c) - GitHub
* **buffers**: correctly handle partial writes in reader seek during initialization (vectordotdev#17099) [a791595](answerbook/vector@a791595) - GitHub
* **config**: recurse through schema refs when determining eligibility for unevaluated properties (vectordotdev#17150) [71d1bf6](answerbook/vector@71d1bf6) - GitHub
* **docker_logs source**: Support tcp schema [e1c0c02](answerbook/vector@e1c0c02) - GitHub
* **elasticsearch sink**:  Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (vectordotdev#17226) (vectordotdev#17227) [9b6ef24](answerbook/vector@9b6ef24) - GitHub
* **gcp_stackdriver_metrics sink**: Call function to regenerate auth token (vectordotdev#17297) [bf7904b](answerbook/vector@bf7904b) - GitHub
* **influxdb_logs**: encode influx line when no tags present (vectordotdev#17029) [c3aa14f](answerbook/vector@c3aa14f) - GitHub
* **reduce transform**: Revert flushing on interval change to `expire_metrics_ms` (vectordotdev#17084) [e86b155](answerbook/vector@e86b155) - GitHub
* **releasing**: Fix globbing of release artifacts for GitHub (vectordotdev#17114) [7fe089c](answerbook/vector@7fe089c) - GitHub
* **schemas**: Dont panic with non object field kinds (vectordotdev#17140) [1e43208](answerbook/vector@1e43208) - GitHub

### Chores

* (syslog source): add source_ip to some syslog tests (vectordotdev#17235) [29c34c0](answerbook/vector@29c34c0) - GitHub
* add note to DEVELOPING.md re panics (vectordotdev#17277) [03e905e](answerbook/vector@03e905e) - GitHub
* Add UX note about encoding of log_schema keys (vectordotdev#17266) [dc6e54c](answerbook/vector@dc6e54c) - GitHub
* **administration**: add `appsignal` to codeowners (vectordotdev#17127) [7b15d19](answerbook/vector@7b15d19) - GitHub
* **buffer**: tidy up some of the module level docs for `disk_v2` (vectordotdev#17093) [edaa612](answerbook/vector@edaa612) - GitHub
* **ci**: bump docker/metadata-action from 4.3.0 to 4.4.0 (vectordotdev#17170) [854d71e](answerbook/vector@854d71e) - GitHub
* **ci**: Disable `appsignal` integration test until CA issues are resolved (vectordotdev#17109) [f3b5d42](answerbook/vector@f3b5d42) - GitHub
* **ci**: Disable scheduled runs of Baseline Timings workflow (vectordotdev#17281) [4335b0a](answerbook/vector@4335b0a) - GitHub
* **ci**: Fix event assertions for `aws_ec2_metadata` transform (vectordotdev#17413) [da36fb6](answerbook/vector@da36fb6) - GitHub
* **ci**: Increase timeout for integration tests (vectordotdev#17326) [e1f125a](answerbook/vector@e1f125a) - GitHub
* **ci**: Increase timeout for integration tests to 30m (vectordotdev#17350) [5d3f619](answerbook/vector@5d3f619) - GitHub
* **ci**: re-enable `appsignal` integration test (vectordotdev#17111) [48fc574](answerbook/vector@48fc574) - GitHub
* **ci**: Remove ci-sweep tasks (vectordotdev#17415) [5c33f99](answerbook/vector@5c33f99) - GitHub
* **ci**: remove unnecessary dep install (vectordotdev#17128) [f56d1ef](answerbook/vector@f56d1ef) - GitHub
* **ci**: Try to fix apt retries (vectordotdev#17393) [6b3db04](answerbook/vector@6b3db04) - GitHub
* **ci**: update unsupported ubuntu version runners (vectordotdev#17113) [e7c4815](answerbook/vector@e7c4815) - GitHub
* **ci**: use python v3.8 in ubuntu 20.04 runner (vectordotdev#17116) [7a40c81](answerbook/vector@7a40c81) - GitHub
* **config**: begin laying out primitives for programmatically querying schema (vectordotdev#17130) [aad8115](answerbook/vector@aad8115) - GitHub
* **config**: emit human-friendly version of enum variant/property names in schema (vectordotdev#17171) [3b38ba8](answerbook/vector@3b38ba8) - GitHub
* **config**: improve config schema output with more precise `unevaluatedProperties` + schema ref flattening (vectordotdev#17026) [2d72f82](answerbook/vector@2d72f82) - GitHub
* **deps**: Add 3rd party license file and CI checks (vectordotdev#17344) [7350e1a](answerbook/vector@7350e1a) - GitHub
* **deps**: bump anyhow from 1.0.70 to 1.0.71 (vectordotdev#17300) [6a5af3b](answerbook/vector@6a5af3b) - GitHub
* **deps**: bump assert_cmd from 2.0.10 to 2.0.11 (vectordotdev#17290) [c4784fd](answerbook/vector@c4784fd) - GitHub
* **deps**: bump async-compression from 0.3.15 to 0.4.0 (vectordotdev#17365) [b9aac47](answerbook/vector@b9aac47) - GitHub
* **deps**: bump async-graphql from 5.0.7 to 5.0.8 (vectordotdev#17357) [05a4f17](answerbook/vector@05a4f17) - GitHub
* **deps**: bump async-graphql-warp from 5.0.7 to 5.0.8 (vectordotdev#17367) [693584e](answerbook/vector@693584e) - GitHub
* **deps**: bump async-stream from 0.3.4 to 0.3.5 (vectordotdev#17076) [c29c817](answerbook/vector@c29c817) - GitHub
* **deps**: bump aws-sigv4 from 0.55.0 to 0.55.1 (vectordotdev#17138) [dbb3f25](answerbook/vector@dbb3f25) - GitHub
* **deps**: bump axum from 0.6.12 to 0.6.18 (vectordotdev#17257) [41ac76e](answerbook/vector@41ac76e) - GitHub
* **deps**: bump cached from 0.42.0 to 0.43.0 (vectordotdev#17118) [f90b3b3](answerbook/vector@f90b3b3) - GitHub
* **deps**: bump chrono-tz from 0.8.1 to 0.8.2 (vectordotdev#17088) [623b838](answerbook/vector@623b838) - GitHub
* **deps**: bump clap_complete from 4.2.0 to 4.2.1 (vectordotdev#17229) [d286d16](answerbook/vector@d286d16) - GitHub
* **deps**: bump clap_complete from 4.2.1 to 4.2.2 (vectordotdev#17359) [565668e](answerbook/vector@565668e) - GitHub
* **deps**: bump clap_complete from 4.2.2 to 4.2.3 (vectordotdev#17383) [111cd07](answerbook/vector@111cd07) - GitHub
* **deps**: bump console-subscriber from 0.1.8 to 0.1.9 (vectordotdev#17358) [97b862c](answerbook/vector@97b862c) - GitHub
* **deps**: bump directories from 5.0.0 to 5.0.1 (vectordotdev#17271) [be69f5f](answerbook/vector@be69f5f) - GitHub
* **deps**: bump dunce from 1.0.3 to 1.0.4 (vectordotdev#17244) [cfc387d](answerbook/vector@cfc387d) - GitHub
* **deps**: bump enumflags2 from 0.7.5 to 0.7.6 (vectordotdev#17079) [cbc17be](answerbook/vector@cbc17be) - GitHub
* **deps**: bump enumflags2 from 0.7.6 to 0.7.7 (vectordotdev#17206) [c80c5eb](answerbook/vector@c80c5eb) - GitHub
* **deps**: bump flate2 from 1.0.25 to 1.0.26 (vectordotdev#17320) [ef13370](answerbook/vector@ef13370) - GitHub
* **deps**: bump getrandom from 0.2.8 to 0.2.9 (vectordotdev#17101) [d53240b](answerbook/vector@d53240b) - GitHub
* **deps**: bump h2 from 0.3.18 to 0.3.19 (vectordotdev#17388) [6088abd](answerbook/vector@6088abd) - GitHub
* **deps**: bump hashlink from 0.8.1 to 0.8.2 (vectordotdev#17419) [01b3cd7](answerbook/vector@01b3cd7) - GitHub
* **deps**: bump hyper from 0.14.25 to 0.14.26 (vectordotdev#17347) [c43dcfd](answerbook/vector@c43dcfd) - GitHub
* **deps**: bump inventory from 0.3.5 to 0.3.6 (vectordotdev#17401) [5b5ad16](answerbook/vector@5b5ad16) - GitHub
* **deps**: bump libc from 0.2.140 to 0.2.141 (vectordotdev#17104) [dd9608a](answerbook/vector@dd9608a) - GitHub
* **deps**: bump libc from 0.2.141 to 0.2.142 (vectordotdev#17273) [bc618a2](answerbook/vector@bc618a2) - GitHub
* **deps**: bump libc from 0.2.142 to 0.2.143 (vectordotdev#17338) [6afe206](answerbook/vector@6afe206) - GitHub
* **deps**: bump libc from 0.2.143 to 0.2.144 (vectordotdev#17346) [99b8dc1](answerbook/vector@99b8dc1) - GitHub
* **deps**: bump memmap2 from 0.5.10 to 0.6.0 (vectordotdev#17355) [dae0c6a](answerbook/vector@dae0c6a) - GitHub
* **deps**: bump memmap2 from 0.6.0 to 0.6.1 (vectordotdev#17364) [58ba741](answerbook/vector@58ba741) - GitHub
* **deps**: bump metrics, metrics-tracing-context, metrics-util (vectordotdev#17336) [9a723e3](answerbook/vector@9a723e3) - GitHub
* **deps**: bump mlua from 0.8.8 to 0.8.9 (vectordotdev#17423) [57f8bd4](answerbook/vector@57f8bd4) - GitHub
* **deps**: bump mock_instant from 0.2.1 to 0.3.0 (vectordotdev#17210) [40c9afc](answerbook/vector@40c9afc) - GitHub
* **deps**: bump mongodb from 2.4.0 to 2.5.0 (vectordotdev#17337) [64f4f69](answerbook/vector@64f4f69) - GitHub
* **deps**: bump nkeys from 0.2.0 to 0.3.0 (vectordotdev#17421) [3320eda](answerbook/vector@3320eda) - GitHub
* **deps**: bump notify from 5.1.0 to 6.0.0 (vectordotdev#17422) [58603b9](answerbook/vector@58603b9) - GitHub
* **deps**: bump num_enum from 0.5.11 to 0.6.0 (vectordotdev#17106) [42f298b](answerbook/vector@42f298b) - GitHub
* **deps**: bump num_enum from 0.6.0 to 0.6.1 (vectordotdev#17272) [f696e7b](answerbook/vector@f696e7b) - GitHub
* **deps**: bump opendal from 0.30.5 to 0.31.0 (vectordotdev#17119) [8762563](answerbook/vector@8762563) - GitHub
* **deps**: bump opendal from 0.31.0 to 0.33.2 (vectordotdev#17286) [3d41931](answerbook/vector@3d41931) - GitHub
* **deps**: bump opendal from 0.33.2 to 0.34.0 (vectordotdev#17354) [ae602da](answerbook/vector@ae602da) - GitHub
* **deps**: bump openssl from 0.10.48 to 0.10.50 (vectordotdev#17087) [9a56ed8](answerbook/vector@9a56ed8) - GitHub
* **deps**: bump openssl from 0.10.50 to 0.10.52 (vectordotdev#17299) [0ecceb3](answerbook/vector@0ecceb3) - GitHub
* **deps**: bump pin-project from 1.0.12 to 1.1.0 (vectordotdev#17385) [e8d3002](answerbook/vector@e8d3002) - GitHub
* **deps**: bump prettydiff from 0.6.2 to 0.6.4 (vectordotdev#17089) [e090610](answerbook/vector@e090610) - GitHub
* **deps**: bump prettydiff from 0.6.2 to 0.6.4 (vectordotdev#17315) [a1ec68d](answerbook/vector@a1ec68d) - GitHub
* **deps**: bump proc-macro2 from 1.0.55 to 1.0.56 (vectordotdev#17103) [6f74523](answerbook/vector@6f74523) - GitHub
* **deps**: bump proc-macro2 from 1.0.56 to 1.0.57 (vectordotdev#17400) [a6e1ae7](answerbook/vector@a6e1ae7) - GitHub
* **deps**: bump prost-build from 0.11.8 to 0.11.9 (vectordotdev#17260) [a88aba4](answerbook/vector@a88aba4) - GitHub
* **deps**: bump quote from 1.0.26 to 1.0.27 (vectordotdev#17348) [f81ff18](answerbook/vector@f81ff18) - GitHub
* **deps**: bump rdkafka from 0.29.0 to 0.30.0 (vectordotdev#17387) [9703188](answerbook/vector@9703188) - GitHub
* **deps**: bump regex from 1.7.3 to 1.8.1 (vectordotdev#17222) [410aa3c](answerbook/vector@410aa3c) - GitHub
* **deps**: bump reqwest from 0.11.16 to 0.11.17 (vectordotdev#17316) [09176ec](answerbook/vector@09176ec) - GitHub
* **deps**: bump security-framework from 2.8.2 to 2.9.0 (vectordotdev#17386) [1287168](answerbook/vector@1287168) - GitHub
* **deps**: bump serde from 1.0.159 to 1.0.160 (vectordotdev#17270) [036ad4a](answerbook/vector@036ad4a) - GitHub
* **deps**: bump serde from 1.0.160 to 1.0.162 (vectordotdev#17317) [79e97a2](answerbook/vector@79e97a2) - GitHub
* **deps**: bump serde from 1.0.162 to 1.0.163 (vectordotdev#17366) [9852c17](answerbook/vector@9852c17) - GitHub
* **deps**: bump serde_json from 1.0.95 to 1.0.96 (vectordotdev#17258) [7570bb3](answerbook/vector@7570bb3) - GitHub
* **deps**: bump serde_with from 2.3.1 to 2.3.2 (vectordotdev#17090) [adbf4d5](answerbook/vector@adbf4d5) - GitHub
* **deps**: bump serde_yaml from 0.9.19 to 0.9.21 (vectordotdev#17120) [d6f2625](answerbook/vector@d6f2625) - GitHub
* **deps**: bump socket2 from 0.4.7 to 0.5.2 (vectordotdev#17121) [db39d83](answerbook/vector@db39d83) - GitHub
* **deps**: bump socket2 from 0.5.2 to 0.5.3 (vectordotdev#17384) [ac51b8a](answerbook/vector@ac51b8a) - GitHub
* **deps**: bump syslog from 6.0.1 to 6.1.0 (vectordotdev#17301) [61e6154](answerbook/vector@61e6154) - GitHub
* **deps**: bump tokio from 1.27.0 to 1.28.0 (vectordotdev#17231) [8067f84](answerbook/vector@8067f84) - GitHub
* **deps**: bump tokio from 1.28.0 to 1.28.1 (vectordotdev#17368) [ae6a51b](answerbook/vector@ae6a51b) - GitHub
* **deps**: bump tokio-stream from 0.1.12 to 0.1.14 (vectordotdev#17339) [80c8247](answerbook/vector@80c8247) - GitHub
* **deps**: bump tokio-tungstenite from 0.18.0 to 0.19.0 (vectordotdev#17404) [ae1dd6e](answerbook/vector@ae1dd6e) - GitHub
* **deps**: bump tonic from 0.8.3 to 0.9.1 (vectordotdev#17077) [eafba69](answerbook/vector@eafba69) - GitHub
* **deps**: bump tonic from 0.9.1 to 0.9.2 (vectordotdev#17221) [aa9cbd0](answerbook/vector@aa9cbd0) - GitHub
* **deps**: bump tonic-build from 0.8.4 to 0.9.2 (vectordotdev#17274) [e0a07c6](answerbook/vector@e0a07c6) - GitHub
* **deps**: bump tracing-subscriber from 0.3.16 to 0.3.17 (vectordotdev#17268) [1406c08](answerbook/vector@1406c08) - GitHub
* **deps**: bump typetag from 0.2.7 to 0.2.8 (vectordotdev#17302) [c8e0e5f](answerbook/vector@c8e0e5f) - GitHub
* **deps**: bump uuid from 1.3.0 to 1.3.1 (vectordotdev#17091) [9cc2f1d](answerbook/vector@9cc2f1d) - GitHub
* **deps**: bump uuid from 1.3.0 to 1.3.2 (vectordotdev#17256) [bc6f7fd](answerbook/vector@bc6f7fd) - GitHub
* **deps**: bump uuid from 1.3.2 to 1.3.3 (vectordotdev#17403) [3a3fe63](answerbook/vector@3a3fe63) - GitHub
* **deps**: bump warp from 0.3.4 to 0.3.5 (vectordotdev#17288) [d8c1f12](answerbook/vector@d8c1f12) - GitHub
* **deps**: bump wasm-bindgen from 0.2.84 to 0.2.85 (vectordotdev#17356) [ea24b4d](answerbook/vector@ea24b4d) - GitHub
* **deps**: bump wasm-bindgen from 0.2.85 to 0.2.86 (vectordotdev#17402) [0518176](answerbook/vector@0518176) - GitHub
* **deps**: bump wiremock from 0.5.17 to 0.5.18 (vectordotdev#17092) [51312aa](answerbook/vector@51312aa) - GitHub
* **deps**: Fix up missing license (vectordotdev#17379) [a2b8903](answerbook/vector@a2b8903) - GitHub
* **deps**: Reset dependencies bumped by a61dea1 (vectordotdev#17100) [887d6d7](answerbook/vector@887d6d7) - GitHub
* **deps**: true up cargo.lock (vectordotdev#17149) [10fce65](answerbook/vector@10fce65) - GitHub
* **deps**: Update h2 (vectordotdev#17189) [a2882f3](answerbook/vector@a2882f3) - GitHub
* **deps**: Upgrade cue to 0.5.0 (vectordotdev#17204) [d396320](answerbook/vector@d396320) - GitHub
* **deps**: Upgrade Debian to bullseye for distroless image (vectordotdev#17160) [c304a8c](answerbook/vector@c304a8c) - GitHub
* **deps**: Upgrade rust to 1.69.0 (vectordotdev#17194) [ef15696](answerbook/vector@ef15696) - GitHub
* **dev**: Add note about generating licenses to CONTRIBUTING.md (vectordotdev#17410) [539f379](answerbook/vector@539f379) - GitHub
* **dev**: ignore `.helix` dir (vectordotdev#17203) [32a935b](answerbook/vector@32a935b) - GitHub
* **dev**: Install the correct `mold` based on CPU architecture (vectordotdev#17248) [4b80c71](answerbook/vector@4b80c71) - GitHub
* **dev**: remove editors from gitignore (vectordotdev#17267) [61c0d76](answerbook/vector@61c0d76) - GitHub
* **docs**: Add Enterprise link and update Support link (vectordotdev#17408) [5184d50](answerbook/vector@5184d50) - GitHub
* **docs**: Add missing 0.28.2 version [38607cd](answerbook/vector@38607cd) - Jesse Szwedko
* **docs**: Clarify `key_field` for `sample` and `throttle` transforms (vectordotdev#17372) [d1e5588](answerbook/vector@d1e5588) - GitHub
* **docs**: Document event type conditions (vectordotdev#17311) [a9c8dc8](answerbook/vector@a9c8dc8) - GitHub
* **docs**: make doc style edits (vectordotdev#17155) [65a8856](answerbook/vector@65a8856) - GitHub
* **docs**: Remove trailing, unmatched quote (vectordotdev#17163) [3c92556](answerbook/vector@3c92556) - GitHub
* **docs**: Remove unneeded `yaml` dependency from website (vectordotdev#17215) [752d424](answerbook/vector@752d424) - GitHub
* **docs**: Update component statuses 2023Q2 (vectordotdev#17362) [22cda94](answerbook/vector@22cda94) - GitHub
* **docs**: update the `v0.28.0` upgrade guide with note about `datadog_logs` sink `hostname` key (vectordotdev#17156) [c169131](answerbook/vector@c169131) - GitHub
* **external docs**: correctly mark some sinks as stateful (vectordotdev#17085) [64d560d](answerbook/vector@64d560d) - GitHub
* **loki sink**: warn on label expansions and collisions (vectordotdev#17052) [f06692b](answerbook/vector@f06692b) - GitHub
* **pulsar**: pulsar-rs bump to v5.1.1 (vectordotdev#17159) [68b54a9](answerbook/vector@68b54a9) - GitHub
* Re-add transform definitions (vectordotdev#17152) [9031d0f](answerbook/vector@9031d0f) - GitHub
* Regen docs for sample and throttle (vectordotdev#17390) [6c57ca0](answerbook/vector@6c57ca0) - GitHub
* **releasing**: Add known issues fixed by 0.29.1 (vectordotdev#17218) [40d543a](answerbook/vector@40d543a) - GitHub
* **releasing**: Bump Vector version to 0.30.0 (vectordotdev#17134) [3834612](answerbook/vector@3834612) - GitHub
* **releasing**: Fix homebrew release script (vectordotdev#17131) [cfbf233](answerbook/vector@cfbf233) - Jesse Szwedko
* **releasing**: Fix release channels (vectordotdev#17133) [58b44e8](answerbook/vector@58b44e8) - Jesse Szwedko
* **releasing**: Prepare v0.28.2 release [a61dea1](answerbook/vector@a61dea1) - Jesse Szwedko
* **releasing**: Prepare v0.29.0 release [4bf6805](answerbook/vector@4bf6805) - Jesse Szwedko
* **releasing**: Prepare v0.30.0 release [38c3f0b](answerbook/vector@38c3f0b) - Jesse Szwedko
* **releasing**: Regenerate Kubernetes manifests for 0.21.2 (vectordotdev#17108) [fd13d64](answerbook/vector@fd13d64) - GitHub
* **releasing**: Regenerate manifests for 0.21.1 chart (vectordotdev#17187) [1f0de6b](answerbook/vector@1f0de6b) - GitHub
* **releasing**: Regenerate manifests for 0.22.0 chart (vectordotdev#17135) [e7ea0a8](answerbook/vector@e7ea0a8) - GitHub
* **releasing**: update patch release template with extra step details [27c3526](answerbook/vector@27c3526) - GitHub
* Remove skaffold from project (vectordotdev#17145) [d245927](answerbook/vector@d245927) - GitHub
* remove transform type coercion (vectordotdev#17411) [b6c7e0a](answerbook/vector@b6c7e0a) - GitHub
* Revert transform definitions (vectordotdev#17146) [05a3f44](answerbook/vector@05a3f44) - GitHub
* **socket source**: Remove deprecated `max_length` setting from `tcp` and `unix` modes. (vectordotdev#17162) [9ecfc8c](answerbook/vector@9ecfc8c) - GitHub
* **syslog source**: remove the remove of source_ip (vectordotdev#17184) [5dff0ed](answerbook/vector@5dff0ed) - GitHub
* **topology**: Transform outputs hash table of OutputId -> Definition (vectordotdev#17059) [1bdb24d](answerbook/vector@1bdb24d) - GitHub
* Upgrade `VRL` to `0.3.0` (vectordotdev#17325) [4911d36](answerbook/vector@4911d36) - GitHub

### Features

* adds 'metric_name' field to internal logs for the tag_cardinality_limit component (vectordotdev#17295) [4317340](answerbook/vector@4317340) - GitHub
* **codecs**: Add full codec support to AWS S3 source/sink (vectordotdev#17098) [d648c86](answerbook/vector@d648c86) - GitHub
* **kubernetes_logs**: use kube-apiserver cache for list requests (vectordotdev#17095) [e46fae7](answerbook/vector@e46fae7) - GitHub
* Merge with upstream v0.30.0 [6b93177](answerbook/vector@6b93177) - GitHub [LOG-17997](https://logdna.atlassian.net/browse/LOG-17997)
* **new sink**: Initial `datadog_events` sink (vectordotdev#7678) [fef3810](answerbook/vector@fef3810) - Jesse Szwedko
* Update VRL library [6ace1e6](answerbook/vector@6ace1e6) - Jorge Bay

### Miscellaneous

* Merge branch 'master' [d4b35bb](answerbook/vector@d4b35bb) - Jorge Bay
* Merge tag 'v0.30.0' into update-upstream [ee2f300](answerbook/vector@ee2f300) - Jorge Bay
* Merge commit '9031d0faa2811187874364e1b5a3305c9ed0c0da' into update-upstream [c12faae](answerbook/vector@c12faae) - Jorge Bay
* Improve tokio::select behavior for kafka source and finalizers (vectordotdev#17380) [d4df21c](answerbook/vector@d4df21c) - GitHub
* Prepare v0.29.1 release [21beed7](answerbook/vector@21beed7) - Kyle Criddle
* Add a quickfix to handle special capitalization cases (vectordotdev#17141) [ba63e21](answerbook/vector@ba63e21) - GitHub
* Adjust doc comment locations (vectordotdev#17154) [730c938](answerbook/vector@730c938) - GitHub
* **amqp sink**: Support AMQ Properties (content-type) in AMQP sink (vectordotdev#17174) [c10d30b](answerbook/vector@c10d30b) - GitHub
* **aws provider**: Let `region` be configured for default authentication (vectordotdev#17414) [c81ad30](answerbook/vector@c81ad30) - GitHub
* **core**: add unit test (ignored) for support for encoding special chars in `ProxyConfig` (vectordotdev#17148) [5247972](answerbook/vector@5247972) - GitHub
* **loki sink**: Fix formatting in labels example (vectordotdev#17396) [f3734e8](answerbook/vector@f3734e8) - GitHub
* **observability**: Log underlying error for unhandled HTTP errors (vectordotdev#17327) [bf8376c](answerbook/vector@bf8376c) - GitHub
* **observability**: Update internal log rate limiting messages (vectordotdev#17394) [1951535](answerbook/vector@1951535) - GitHub
* **pulsar sink**: Refactor to use StreamSink (vectordotdev#14345) [1e97a2f](answerbook/vector@1e97a2f) - GitHub
* **topology**: Add source id to metadata (vectordotdev#17369) [c683999](answerbook/vector@c683999) - GitHub
* **vdev**: Load compose files and inject network block (vectordotdev#17025) [5d88655](answerbook/vector@5d88655) - GitHub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergilbert spencergilbert spencergilbert approved these changes

@bruceg bruceg bruceg approved these changes

Assignees
No one assigned
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Influxdb_logs should encode when there's not tags at all
3 participants
@juvenn @spencergilbert @bruceg