Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codecs): Add full codec support to AWS S3 source/sink #17098

Merged
merged 11 commits into from
Apr 28, 2023

Conversation

fuchsnj
Copy link
Member

@fuchsnj fuchsnj commented Apr 10, 2023

This adds codec support to the AWS S3 source and sink.

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 630e429
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/644c05d6521be30008169806

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 630e429
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/644c05d66c62310008a17dd2

@github-actions github-actions bot added domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources labels Apr 10, 2023
@github-actions
Copy link

Regression Detector Results

Run ID: 08ba3e2d-4282-40bb-8b58-1fdeb4a4ce8e
Baseline: 38607cd
Comparison: 43f5bc3
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean Δ mean % confidence
http_text_to_http_json ingress throughput -1.6MiB/CPU-s -6.27 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_loki ingress throughput 201.15KiB/CPU-s 2.37 100.00% 8.27MiB/CPU-s 478.83KiB/CPU-s 6.18KiB/CPU-s 0.0 0.056506 8.47MiB/CPU-s 303.47KiB/CPU-s 3.92KiB/CPU-s 0.0 0.034982 False False
syslog_humio_logs ingress throughput 176.67KiB/CPU-s 1.92 100.00% 8.97MiB/CPU-s 324.98KiB/CPU-s 4.19KiB/CPU-s 0.0 0.035381 9.14MiB/CPU-s 252.01KiB/CPU-s 3.25KiB/CPU-s 0.0 0.026919 False False
datadog_agent_remap_blackhole_acks ingress throughput 414.01KiB/CPU-s 1.28 100.00% 31.71MiB/CPU-s 1022.8KiB/CPU-s 13.2KiB/CPU-s 0.0 0.031497 32.11MiB/CPU-s 508.44KiB/CPU-s 6.56KiB/CPU-s 0.0 0.01546 False False
otlp_http_to_blackhole ingress throughput 7.9KiB/CPU-s 0.49 100.00% 1.57MiB/CPU-s 103.04KiB/CPU-s 1.33KiB/CPU-s 0.0 0.064127 1.58MiB/CPU-s 99.69KiB/CPU-s 1.29KiB/CPU-s 0.0 0.061739 False False
datadog_agent_remap_datadog_logs ingress throughput 121.06KiB/CPU-s 0.36 100.00% 32.98MiB/CPU-s 1.64MiB/CPU-s 21.64KiB/CPU-s 0.0 0.049666 33.1MiB/CPU-s 894.84KiB/CPU-s 11.55KiB/CPU-s 0.0 0.026403 False False
datadog_agent_remap_datadog_logs_acks ingress throughput 74.28KiB/CPU-s 0.23 99.73% 32.15MiB/CPU-s 1.35MiB/CPU-s 17.91KiB/CPU-s 0.0 0.042146 32.22MiB/CPU-s 1.3MiB/CPU-s 17.14KiB/CPU-s 0.0 0.040256 False False
enterprise_http_to_http ingress throughput 8.39KiB/CPU-s 0.06 95.87% 13.62MiB/CPU-s 281.73KiB/CPU-s 3.64KiB/CPU-s 0.0 0.020204 13.62MiB/CPU-s 148.33KiB/CPU-s 1.91KiB/CPU-s 0.0 0.010631 False False
splunk_hec_indexer_ack_blackhole ingress throughput 2.04KiB/CPU-s 0.01 34.01% 13.62MiB/CPU-s 258.57KiB/CPU-s 3.34KiB/CPU-s 0.0 0.018545 13.62MiB/CPU-s 249.03KiB/CPU-s 3.21KiB/CPU-s 0.0 0.017858 False False
fluent_elasticsearch ingress throughput -65.39B/CPU-s -0.00 9.43% 45.41MiB/CPU-s 29.63KiB/CPU-s 387.53B/CPU-s 0.0 0.000637 45.41MiB/CPU-s 30.06KiB/CPU-s 392.97B/CPU-s 0.0 0.000646 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput 89.21B/CPU-s 0.00 1.52% 13.62MiB/CPU-s 249.67KiB/CPU-s 3.22KiB/CPU-s 0.0 0.017904 13.62MiB/CPU-s 251.14KiB/CPU-s 3.24KiB/CPU-s 0.0 0.018009 False False
http_to_http_noack ingress throughput 28.35B/CPU-s 0.00 0.33% 13.61MiB/CPU-s 371.64KiB/CPU-s 4.79KiB/CPU-s 0.0 0.026668 13.61MiB/CPU-s 371.13KiB/CPU-s 4.79KiB/CPU-s 0.0 0.026631 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput -111.33B/CPU-s -0.00 1.29% 13.61MiB/CPU-s 362.42KiB/CPU-s 4.67KiB/CPU-s 0.0 0.025995 13.61MiB/CPU-s 372.44KiB/CPU-s 4.8KiB/CPU-s 0.0 0.026714 False False
http_to_http_json ingress throughput -7.18KiB/CPU-s -0.05 86.17% 13.61MiB/CPU-s 257.54KiB/CPU-s 3.32KiB/CPU-s 0.0 0.018479 13.6MiB/CPU-s 273.16KiB/CPU-s 3.52KiB/CPU-s 0.0 0.01961 False False
syslog_log2metric_humio_metrics ingress throughput -24.71KiB/CPU-s -0.37 100.00% 6.58MiB/CPU-s 204.49KiB/CPU-s 2.64KiB/CPU-s 0.0 0.030355 6.55MiB/CPU-s 300.15KiB/CPU-s 3.87KiB/CPU-s 0.0 0.044719 False False
datadog_agent_remap_blackhole ingress throughput -180.06KiB/CPU-s -0.57 100.00% 30.82MiB/CPU-s 1.13MiB/CPU-s 14.93KiB/CPU-s 0.0 0.036671 30.64MiB/CPU-s 1.35MiB/CPU-s 17.86KiB/CPU-s 0.0 0.044112 False False
syslog_log2metric_splunk_hec_metrics ingress throughput -60.21KiB/CPU-s -0.63 100.00% 9.31MiB/CPU-s 331.63KiB/CPU-s 4.28KiB/CPU-s 0.0 0.034768 9.26MiB/CPU-s 340.04KiB/CPU-s 4.39KiB/CPU-s 0.0 0.035876 False False
otlp_grpc_to_blackhole ingress throughput -9.38KiB/CPU-s -0.88 100.00% 1.05MiB/CPU-s 45.51KiB/CPU-s 601.45B/CPU-s 0.0 0.042457 1.04MiB/CPU-s 56.18KiB/CPU-s 742.46B/CPU-s 0.0 0.052873 False False
splunk_hec_route_s3 ingress throughput -129.07KiB/CPU-s -1.07 100.00% 11.75MiB/CPU-s 642.36KiB/CPU-s 8.29KiB/CPU-s 0.0 0.053382 11.62MiB/CPU-s 606.29KiB/CPU-s 7.82KiB/CPU-s 0.0 0.050931 False False
syslog_splunk_hec_logs ingress throughput -104.61KiB/CPU-s -1.13 100.00% 9.0MiB/CPU-s 271.58KiB/CPU-s 3.5KiB/CPU-s 0.0 0.029462 8.9MiB/CPU-s 352.36KiB/CPU-s 4.55KiB/CPU-s 0.0 0.038665 False False
http_to_http_acks ingress throughput -102.15KiB/CPU-s -1.88 95.47% 5.31MiB/CPU-s 2.73MiB/CPU-s 36.09KiB/CPU-s 0.0 0.514069 5.21MiB/CPU-s 2.73MiB/CPU-s 36.06KiB/CPU-s 0.0 0.523476 True False
syslog_regex_logs2metric_ddmetrics ingress throughput -83.53KiB/CPU-s -2.21 100.00% 3.7MiB/CPU-s 419.59KiB/CPU-s 5.42KiB/CPU-s 0.0 0.11078 3.62MiB/CPU-s 472.45KiB/CPU-s 6.1KiB/CPU-s 0.0 0.127549 True True
socket_to_socket_blackhole ingress throughput -364.0KiB/CPU-s -2.61 100.00% 13.63MiB/CPU-s 283.01KiB/CPU-s 3.65KiB/CPU-s 0.0 0.02027 13.28MiB/CPU-s 195.37KiB/CPU-s 2.52KiB/CPU-s 0.0 0.014368 False False
http_text_to_http_json ingress throughput -1.6MiB/CPU-s -6.27 100.00% 25.53MiB/CPU-s 806.46KiB/CPU-s 10.41KiB/CPU-s 0.0 0.030844 23.93MiB/CPU-s 768.99KiB/CPU-s 9.93KiB/CPU-s 0.0 0.031377 False False
file_to_blackhole egress throughput -1.08MiB/CPU-s -14.87 100.00% 7.3MiB/CPU-s 3.94MiB/CPU-s 138.78KiB/CPU-s 0.0 0.53931 6.21MiB/CPU-s 4.53MiB/CPU-s 131.12KiB/CPU-s 1.039169 0.728839 True True

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Apr 11, 2023

Datadog Report

Branch report: fuchsnj/aws_s3_codecs
Commit report: ca2a5ca

vector: 1 Failed (1 Known Flaky), 0 New Flaky, 2143 Passed, 0 Skipped, 8m 4.57s Wall Time

❌ Failed Tests (1)

  • sources::aws_s3::integration_tests::handles_errored_status - vector - ❄️ Known flaky - Details

    Expand for error
     Test has failed
    

@github-actions
Copy link

Regression Detector Results

Run ID: 73c5d636-37f5-463c-ab3d-ad096c091a82
Baseline: 1bdb24d
Comparison: 2966a2d
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
file_to_blackhole egress throughput 484.11KiB/CPU-s 7.71 99.00% 6.13MiB/CPU-s 4.56MiB/CPU-s 131.38KiB/CPU-s 0.0 0.743204 6.6MiB/CPU-s 4.33MiB/CPU-s 134.15KiB/CPU-s 0.182983 0.655655 True True
syslog_log2metric_humio_metrics ingress throughput 249.32KiB/CPU-s 3.81 100.00% 6.39MiB/CPU-s 258.7KiB/CPU-s 3.34KiB/CPU-s 0.0 0.039535 6.63MiB/CPU-s 163.35KiB/CPU-s 2.11KiB/CPU-s 0.0 0.024048 False False
splunk_hec_route_s3 ingress throughput 147.92KiB/CPU-s 1.24 100.00% 11.65MiB/CPU-s 691.39KiB/CPU-s 8.92KiB/CPU-s 0.0 0.05793 11.8MiB/CPU-s 660.78KiB/CPU-s 8.53KiB/CPU-s 0.0 0.054688 False False
syslog_log2metric_splunk_hec_metrics ingress throughput 99.08KiB/CPU-s 1.03 100.00% 9.41MiB/CPU-s 221.1KiB/CPU-s 2.85KiB/CPU-s 0.0 0.022952 9.5MiB/CPU-s 264.24KiB/CPU-s 3.41KiB/CPU-s 0.0 0.027151 False False
syslog_loki ingress throughput 50.03KiB/CPU-s 0.57 100.00% 8.59MiB/CPU-s 205.19KiB/CPU-s 2.65KiB/CPU-s 0.0 0.023322 8.64MiB/CPU-s 198.52KiB/CPU-s 2.56KiB/CPU-s 0.0 0.022435 False False
datadog_agent_remap_datadog_logs_acks ingress throughput 189.77KiB/CPU-s 0.57 100.00% 32.67MiB/CPU-s 1.21MiB/CPU-s 16.04KiB/CPU-s 0.0 0.037167 32.85MiB/CPU-s 1.24MiB/CPU-s 16.36KiB/CPU-s 0.0 0.037695 False False
datadog_agent_remap_datadog_logs ingress throughput 142.26KiB/CPU-s 0.42 100.00% 33.19MiB/CPU-s 1.43MiB/CPU-s 18.95KiB/CPU-s 0.0 0.043208 33.33MiB/CPU-s 1.16MiB/CPU-s 15.27KiB/CPU-s 0.0 0.034664 False False
http_to_http_acks ingress throughput 19.43KiB/CPU-s 0.36 29.59% 5.26MiB/CPU-s 2.72MiB/CPU-s 35.89KiB/CPU-s 0.0 0.516076 5.28MiB/CPU-s 2.76MiB/CPU-s 36.48KiB/CPU-s 0.0 0.522613 True False
syslog_humio_logs ingress throughput 23.56KiB/CPU-s 0.25 100.00% 9.07MiB/CPU-s 238.62KiB/CPU-s 3.08KiB/CPU-s 0.0 0.025683 9.1MiB/CPU-s 354.34KiB/CPU-s 4.57KiB/CPU-s 0.0 0.038042 False False
enterprise_http_to_http ingress throughput 4.06KiB/CPU-s 0.03 75.20% 13.62MiB/CPU-s 226.42KiB/CPU-s 2.92KiB/CPU-s 0.0 0.016233 13.62MiB/CPU-s 150.67KiB/CPU-s 1.95KiB/CPU-s 0.0 0.010799 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput 377.36B/CPU-s 0.00 4.74% 13.61MiB/CPU-s 334.16KiB/CPU-s 4.31KiB/CPU-s 0.0 0.02397 13.61MiB/CPU-s 345.15KiB/CPU-s 4.45KiB/CPU-s 0.0 0.024757 False False
fluent_elasticsearch ingress throughput -277.46B/CPU-s -0.00 38.24% 45.41MiB/CPU-s 29.83KiB/CPU-s 390.04B/CPU-s 0.0 0.000641 45.41MiB/CPU-s 30.29KiB/CPU-s 395.92B/CPU-s 0.0 0.000651 False False
http_to_http_json ingress throughput 307.0B/CPU-s 0.00 5.76% 13.62MiB/CPU-s 229.6KiB/CPU-s 2.96KiB/CPU-s 0.0 0.01646 13.62MiB/CPU-s 225.04KiB/CPU-s 2.9KiB/CPU-s 0.0 0.016133 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -2.26KiB/CPU-s -0.02 35.50% 13.62MiB/CPU-s 259.52KiB/CPU-s 3.35KiB/CPU-s 0.0 0.018612 13.61MiB/CPU-s 276.73KiB/CPU-s 3.57KiB/CPU-s 0.0 0.019849 False False
splunk_hec_indexer_ack_blackhole ingress throughput -2.12KiB/CPU-s -0.02 35.96% 13.62MiB/CPU-s 244.89KiB/CPU-s 3.16KiB/CPU-s 0.0 0.017559 13.62MiB/CPU-s 252.69KiB/CPU-s 3.26KiB/CPU-s 0.0 0.018121 False False
http_to_http_noack ingress throughput -4.1KiB/CPU-s -0.03 47.41% 13.61MiB/CPU-s 333.43KiB/CPU-s 4.3KiB/CPU-s 0.0 0.023919 13.61MiB/CPU-s 373.65KiB/CPU-s 4.82KiB/CPU-s 0.0 0.026812 False False
syslog_splunk_hec_logs ingress throughput -6.24KiB/CPU-s -0.07 78.77% 9.04MiB/CPU-s 233.13KiB/CPU-s 3.01KiB/CPU-s 0.0 0.025185 9.03MiB/CPU-s 310.11KiB/CPU-s 4.0KiB/CPU-s 0.0 0.033523 False False
datadog_agent_remap_blackhole ingress throughput -43.37KiB/CPU-s -0.14 97.41% 30.81MiB/CPU-s 1.06MiB/CPU-s 14.03KiB/CPU-s 0.0 0.034445 30.77MiB/CPU-s 1.02MiB/CPU-s 13.5KiB/CPU-s 0.0 0.033202 False False
syslog_regex_logs2metric_ddmetrics ingress throughput -11.74KiB/CPU-s -0.31 84.10% 3.68MiB/CPU-s 463.52KiB/CPU-s 5.98KiB/CPU-s 0.0 0.12286 3.67MiB/CPU-s 449.26KiB/CPU-s 5.8KiB/CPU-s 0.0 0.119453 True True
datadog_agent_remap_blackhole_acks ingress throughput -140.32KiB/CPU-s -0.43 100.00% 31.64MiB/CPU-s 1.08MiB/CPU-s 14.31KiB/CPU-s 0.0 0.034221 31.51MiB/CPU-s 826.54KiB/CPU-s 10.67KiB/CPU-s 0.0 0.025616 False False
http_text_to_http_json ingress throughput -147.38KiB/CPU-s -0.56 100.00% 25.84MiB/CPU-s 735.34KiB/CPU-s 9.49KiB/CPU-s 0.0 0.027792 25.69MiB/CPU-s 674.19KiB/CPU-s 8.7KiB/CPU-s 0.0 0.025623 False False
otlp_grpc_to_blackhole ingress throughput -6.29KiB/CPU-s -0.59 100.00% 1.05MiB/CPU-s 49.18KiB/CPU-s 649.88B/CPU-s 0.0 0.045805 1.04MiB/CPU-s 43.66KiB/CPU-s 577.01B/CPU-s 0.0 0.040902 False False
otlp_http_to_blackhole ingress throughput -44.75KiB/CPU-s -2.76 100.00% 1.58MiB/CPU-s 101.85KiB/CPU-s 1.31KiB/CPU-s 0.0 0.062821 1.54MiB/CPU-s 120.91KiB/CPU-s 1.56KiB/CPU-s 0.0 0.076691 False False
socket_to_socket_blackhole ingress throughput -463.05KiB/CPU-s -3.24 100.00% 13.95MiB/CPU-s 249.52KiB/CPU-s 3.22KiB/CPU-s 0.0 0.01747 13.49MiB/CPU-s 227.41KiB/CPU-s 2.93KiB/CPU-s 0.0 0.016456 False False

@fuchsnj fuchsnj added the ci-condition: integration tests enable Run integration tests on this PR label Apr 12, 2023
@github-actions
Copy link

Regression Detector Results

Run ID: 54b84156-a53d-4912-8c1a-0f731d098680
Baseline: 7a40c81
Comparison: b402f2b
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs ingress throughput 794.32KiB/CPU-s 2.42 100.00% 32.01MiB/CPU-s 1.86MiB/CPU-s 24.57KiB/CPU-s 0.0 0.058087 32.78MiB/CPU-s 1.12MiB/CPU-s 14.76KiB/CPU-s 0.0 0.034072 False False
datadog_agent_remap_datadog_logs_acks ingress throughput 745.22KiB/CPU-s 2.32 100.00% 31.41MiB/CPU-s 1.58MiB/CPU-s 20.91KiB/CPU-s 0.0 0.050386 32.13MiB/CPU-s 1.17MiB/CPU-s 15.43KiB/CPU-s 0.0 0.036337 False False
datadog_agent_remap_blackhole ingress throughput 614.17KiB/CPU-s 1.98 100.00% 30.31MiB/CPU-s 1.14MiB/CPU-s 15.09KiB/CPU-s 0.0 0.037699 30.91MiB/CPU-s 1.05MiB/CPU-s 13.9KiB/CPU-s 0.0 0.034025 False False
syslog_log2metric_humio_metrics ingress throughput 88.54KiB/CPU-s 1.34 100.00% 6.44MiB/CPU-s 248.05KiB/CPU-s 3.2KiB/CPU-s 0.0 0.037629 6.52MiB/CPU-s 349.54KiB/CPU-s 4.51KiB/CPU-s 0.0 0.052322 False False
splunk_hec_route_s3 ingress throughput 96.09KiB/CPU-s 0.81 100.00% 11.58MiB/CPU-s 613.09KiB/CPU-s 7.91KiB/CPU-s 0.0 0.051698 11.67MiB/CPU-s 675.63KiB/CPU-s 8.72KiB/CPU-s 0.0 0.056513 False False
datadog_agent_remap_blackhole_acks ingress throughput 82.96KiB/CPU-s 0.26 99.98% 31.03MiB/CPU-s 1.31MiB/CPU-s 17.33KiB/CPU-s 0.0 0.042261 31.11MiB/CPU-s 1.09MiB/CPU-s 14.4KiB/CPU-s 0.0 0.035022 False False
http_text_to_http_json ingress throughput 64.05KiB/CPU-s 0.24 100.00% 25.59MiB/CPU-s 620.26KiB/CPU-s 8.0KiB/CPU-s 0.0 0.023666 25.65MiB/CPU-s 627.54KiB/CPU-s 8.1KiB/CPU-s 0.0 0.023886 False False
enterprise_http_to_http ingress throughput 8.3KiB/CPU-s 0.06 94.54% 13.62MiB/CPU-s 298.12KiB/CPU-s 3.85KiB/CPU-s 0.0 0.02138 13.62MiB/CPU-s 151.89KiB/CPU-s 1.96KiB/CPU-s 0.0 0.010887 False False
fluent_elasticsearch ingress throughput 377.17B/CPU-s 0.00 50.03% 45.41MiB/CPU-s 30.1KiB/CPU-s 393.65B/CPU-s 0.0 0.000647 45.41MiB/CPU-s 30.34KiB/CPU-s 396.54B/CPU-s 0.0 0.000652 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput -373.66B/CPU-s -0.00 4.62% 13.61MiB/CPU-s 345.77KiB/CPU-s 4.46KiB/CPU-s 0.0 0.024802 13.61MiB/CPU-s 344.47KiB/CPU-s 4.44KiB/CPU-s 0.0 0.024709 False False
http_to_http_json ingress throughput -601.62B/CPU-s -0.00 10.77% 13.62MiB/CPU-s 247.35KiB/CPU-s 3.19KiB/CPU-s 0.0 0.017733 13.62MiB/CPU-s 228.1KiB/CPU-s 2.94KiB/CPU-s 0.0 0.016354 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -1.08KiB/CPU-s -0.01 17.06% 13.61MiB/CPU-s 270.34KiB/CPU-s 3.49KiB/CPU-s 0.0 0.01939 13.61MiB/CPU-s 277.25KiB/CPU-s 3.58KiB/CPU-s 0.0 0.019887 False False
splunk_hec_indexer_ack_blackhole ingress throughput -1.79KiB/CPU-s -0.01 29.84% 13.62MiB/CPU-s 251.03KiB/CPU-s 3.24KiB/CPU-s 0.0 0.018002 13.61MiB/CPU-s 260.35KiB/CPU-s 3.36KiB/CPU-s 0.0 0.018673 False False
http_to_http_noack ingress throughput -3.86KiB/CPU-s -0.03 43.78% 13.61MiB/CPU-s 349.59KiB/CPU-s 4.51KiB/CPU-s 0.0 0.025082 13.61MiB/CPU-s 379.79KiB/CPU-s 4.9KiB/CPU-s 0.0 0.027257 False False
syslog_loki ingress throughput -10.17KiB/CPU-s -0.12 94.48% 8.37MiB/CPU-s 286.69KiB/CPU-s 3.7KiB/CPU-s 0.0 0.033446 8.36MiB/CPU-s 294.7KiB/CPU-s 3.8KiB/CPU-s 0.0 0.034422 False False
syslog_log2metric_splunk_hec_metrics ingress throughput -40.71KiB/CPU-s -0.43 100.00% 9.15MiB/CPU-s 339.03KiB/CPU-s 4.38KiB/CPU-s 0.0 0.036181 9.11MiB/CPU-s 279.95KiB/CPU-s 3.61KiB/CPU-s 0.0 0.030007 False False
syslog_regex_logs2metric_ddmetrics ingress throughput -18.83KiB/CPU-s -0.50 98.38% 3.69MiB/CPU-s 415.56KiB/CPU-s 5.36KiB/CPU-s 0.0 0.109929 3.67MiB/CPU-s 441.73KiB/CPU-s 5.7KiB/CPU-s 0.0 0.117435 True True
otlp_http_to_blackhole ingress throughput -13.31KiB/CPU-s -0.82 100.00% 1.58MiB/CPU-s 106.3KiB/CPU-s 1.37KiB/CPU-s 0.0 0.065829 1.56MiB/CPU-s 99.72KiB/CPU-s 1.29KiB/CPU-s 0.0 0.062264 False False
syslog_humio_logs ingress throughput -99.6KiB/CPU-s -1.06 100.00% 9.13MiB/CPU-s 256.92KiB/CPU-s 3.32KiB/CPU-s 0.0 0.027469 9.04MiB/CPU-s 266.75KiB/CPU-s 3.44KiB/CPU-s 0.0 0.028826 False False
syslog_splunk_hec_logs ingress throughput -118.08KiB/CPU-s -1.27 100.00% 9.08MiB/CPU-s 245.04KiB/CPU-s 3.16KiB/CPU-s 0.0 0.026343 8.97MiB/CPU-s 264.31KiB/CPU-s 3.41KiB/CPU-s 0.0 0.028781 False False
otlp_grpc_to_blackhole ingress throughput -16.93KiB/CPU-s -1.56 100.00% 1.06MiB/CPU-s 41.69KiB/CPU-s 551.01B/CPU-s 0.0 0.038426 1.04MiB/CPU-s 43.05KiB/CPU-s 569.04B/CPU-s 0.0 0.040309 False False
http_to_http_acks ingress throughput -109.0KiB/CPU-s -2.01 96.67% 5.29MiB/CPU-s 2.74MiB/CPU-s 36.17KiB/CPU-s 0.0 0.516918 5.19MiB/CPU-s 2.74MiB/CPU-s 36.25KiB/CPU-s 0.0 0.528679 True False
socket_to_socket_blackhole ingress throughput -327.24KiB/CPU-s -2.34 100.00% 13.64MiB/CPU-s 348.17KiB/CPU-s 4.49KiB/CPU-s 0.0 0.024917 13.32MiB/CPU-s 454.2KiB/CPU-s 5.86KiB/CPU-s 0.0 0.033285 False False
file_to_blackhole egress throughput -787.72KiB/CPU-s -11.36 100.00% 6.77MiB/CPU-s 4.58MiB/CPU-s 137.44KiB/CPU-s 1.972556 0.676378 6.0MiB/CPU-s 4.39MiB/CPU-s 124.37KiB/CPU-s 0.0 0.731613 True True

@github-actions
Copy link

Regression Detector Results

Run ID: 15cba42c-f48e-47c0-8491-b2ff9a14f048
Baseline: 5247972
Comparison: ab2d6b8
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
file_to_blackhole egress throughput 557.36KiB/CPU-s 9.16 99.71% 5.94MiB/CPU-s 4.76MiB/CPU-s 131.38KiB/CPU-s 0.0 0.80078 6.49MiB/CPU-s 4.73MiB/CPU-s 133.04KiB/CPU-s 0.0 0.728651 True True
syslog_log2metric_splunk_hec_metrics ingress throughput 310.13KiB/CPU-s 3.32 100.00% 9.12MiB/CPU-s 368.97KiB/CPU-s 4.76KiB/CPU-s 0.0 0.039506 9.42MiB/CPU-s 234.32KiB/CPU-s 3.02KiB/CPU-s 0.0 0.024282 False False
http_text_to_http_json ingress throughput 831.13KiB/CPU-s 3.28 100.00% 24.74MiB/CPU-s 819.28KiB/CPU-s 10.58KiB/CPU-s 0.0 0.032334 25.55MiB/CPU-s 654.68KiB/CPU-s 8.45KiB/CPU-s 0.0 0.025017 False False
datadog_agent_remap_datadog_logs ingress throughput 559.92KiB/CPU-s 1.66 100.00% 32.87MiB/CPU-s 1.35MiB/CPU-s 17.86KiB/CPU-s 0.0 0.041129 33.42MiB/CPU-s 1.05MiB/CPU-s 13.87KiB/CPU-s 0.0 0.031411 False False
http_to_http_json ingress throughput 25.64KiB/CPU-s 0.18 100.00% 13.58MiB/CPU-s 291.65KiB/CPU-s 3.76KiB/CPU-s 0.0 0.020975 13.6MiB/CPU-s 263.86KiB/CPU-s 3.4KiB/CPU-s 0.0 0.018942 False False
enterprise_http_to_http ingress throughput 8.5KiB/CPU-s 0.06 95.94% 13.62MiB/CPU-s 283.43KiB/CPU-s 3.66KiB/CPU-s 0.0 0.020327 13.62MiB/CPU-s 152.17KiB/CPU-s 1.96KiB/CPU-s 0.0 0.010906 False False
otlp_http_to_blackhole ingress throughput 422.84B/CPU-s 0.03 17.54% 1.57MiB/CPU-s 110.31KiB/CPU-s 1.42KiB/CPU-s 0.0 0.068516 1.57MiB/CPU-s 93.14KiB/CPU-s 1.2KiB/CPU-s 0.0 0.057833 False False
splunk_hec_indexer_ack_blackhole ingress throughput 1.21KiB/CPU-s 0.01 20.52% 13.62MiB/CPU-s 258.21KiB/CPU-s 3.33KiB/CPU-s 0.0 0.018518 13.62MiB/CPU-s 250.14KiB/CPU-s 3.23KiB/CPU-s 0.0 0.017938 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput -311.91B/CPU-s -0.00 3.78% 13.61MiB/CPU-s 344.53KiB/CPU-s 4.44KiB/CPU-s 0.0 0.024712 13.61MiB/CPU-s 359.85KiB/CPU-s 4.64KiB/CPU-s 0.0 0.025811 False False
fluent_elasticsearch ingress throughput 52.24B/CPU-s 0.00 7.55% 45.41MiB/CPU-s 29.66KiB/CPU-s 387.82B/CPU-s 0.0 0.000638 45.41MiB/CPU-s 29.99KiB/CPU-s 392.12B/CPU-s 0.0 0.000645 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -2.39KiB/CPU-s -0.02 37.27% 13.62MiB/CPU-s 262.78KiB/CPU-s 3.39KiB/CPU-s 0.0 0.018846 13.61MiB/CPU-s 276.73KiB/CPU-s 3.57KiB/CPU-s 0.0 0.019849 False False
datadog_agent_remap_datadog_logs_acks ingress throughput -7.06KiB/CPU-s -0.02 27.04% 32.68MiB/CPU-s 1.18MiB/CPU-s 15.65KiB/CPU-s 0.0 0.03624 32.68MiB/CPU-s 1015.86KiB/CPU-s 13.11KiB/CPU-s 0.0 0.030357 False False
http_to_http_noack ingress throughput -10.25KiB/CPU-s -0.07 88.50% 13.61MiB/CPU-s 302.06KiB/CPU-s 3.9KiB/CPU-s 0.0 0.021666 13.6MiB/CPU-s 403.46KiB/CPU-s 5.2KiB/CPU-s 0.0 0.028959 False False
splunk_hec_route_s3 ingress throughput -21.8KiB/CPU-s -0.19 90.68% 11.51MiB/CPU-s 696.42KiB/CPU-s 8.99KiB/CPU-s 0.0 0.059103 11.48MiB/CPU-s 726.31KiB/CPU-s 9.37KiB/CPU-s 0.0 0.061753 False False
http_to_http_acks ingress throughput -21.62KiB/CPU-s -0.40 32.81% 5.23MiB/CPU-s 2.7MiB/CPU-s 35.69KiB/CPU-s 0.0 0.516541 5.21MiB/CPU-s 2.76MiB/CPU-s 36.5KiB/CPU-s 0.0 0.530417 True False
syslog_humio_logs ingress throughput -61.75KiB/CPU-s -0.66 100.00% 9.1MiB/CPU-s 163.93KiB/CPU-s 2.12KiB/CPU-s 0.0 0.017589 9.04MiB/CPU-s 289.76KiB/CPU-s 3.74KiB/CPU-s 0.0 0.031296 False False
syslog_loki ingress throughput -57.66KiB/CPU-s -0.67 100.00% 8.39MiB/CPU-s 300.51KiB/CPU-s 3.88KiB/CPU-s 0.0 0.034987 8.33MiB/CPU-s 304.88KiB/CPU-s 3.93KiB/CPU-s 0.0 0.035736 False False
otlp_grpc_to_blackhole ingress throughput -11.59KiB/CPU-s -1.07 100.00% 1.06MiB/CPU-s 45.66KiB/CPU-s 603.43B/CPU-s 0.0 0.042029 1.05MiB/CPU-s 44.3KiB/CPU-s 585.43B/CPU-s 0.0 0.041215 False False
syslog_regex_logs2metric_ddmetrics ingress throughput -56.42KiB/CPU-s -1.50 100.00% 3.67MiB/CPU-s 401.26KiB/CPU-s 5.18KiB/CPU-s 0.0 0.106706 3.62MiB/CPU-s 392.15KiB/CPU-s 5.06KiB/CPU-s 0.0 0.105872 True True
syslog_splunk_hec_logs ingress throughput -141.28KiB/CPU-s -1.53 100.00% 8.99MiB/CPU-s 237.52KiB/CPU-s 3.06KiB/CPU-s 0.0 0.025798 8.85MiB/CPU-s 200.61KiB/CPU-s 2.59KiB/CPU-s 0.0 0.022129 False False
datadog_agent_remap_blackhole ingress throughput -520.2KiB/CPU-s -1.66 100.00% 30.69MiB/CPU-s 1.01MiB/CPU-s 13.29KiB/CPU-s 0.0 0.032778 30.18MiB/CPU-s 1.23MiB/CPU-s 16.19KiB/CPU-s 0.0 0.040592 False False
datadog_agent_remap_blackhole_acks ingress throughput -572.73KiB/CPU-s -1.79 100.00% 31.17MiB/CPU-s 1.33MiB/CPU-s 17.63KiB/CPU-s 0.0 0.042783 30.61MiB/CPU-s 939.76KiB/CPU-s 12.13KiB/CPU-s 0.0 0.029983 False False
syslog_log2metric_humio_metrics ingress throughput -157.84KiB/CPU-s -2.39 100.00% 6.45MiB/CPU-s 314.81KiB/CPU-s 4.06KiB/CPU-s 0.0 0.047682 6.29MiB/CPU-s 311.35KiB/CPU-s 4.02KiB/CPU-s 0.0 0.048312 False False
socket_to_socket_blackhole ingress throughput -577.59KiB/CPU-s -4.08 100.00% 13.84MiB/CPU-s 303.23KiB/CPU-s 3.91KiB/CPU-s 0.0 0.021399 13.27MiB/CPU-s 365.6KiB/CPU-s 4.72KiB/CPU-s 0.0 0.026897 False False

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Apr 18, 2023
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Apr 18, 2023

Datadog Report

Branch report: fuchsnj/aws_s3_codecs
Commit report: 83b8d57

vector: 0 Failed, 0 New Flaky, 2153 Passed, 0 Skipped, 56m 5.97s Wall Time

@github-actions
Copy link

Regression Detector Results

Run ID: 3f901c3c-df67-4d0b-bcb8-d5dc5f7798a0
Baseline: 05a3f44
Comparison: 21d76aa
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_splunk_hec_logs ingress throughput 263.52KiB/CPU-s 2.97 100.00% 8.66MiB/CPU-s 222.23KiB/CPU-s 2.87KiB/CPU-s 0.0 0.025072 8.91MiB/CPU-s 198.46KiB/CPU-s 2.56KiB/CPU-s 0.0 0.021743 False False
socket_to_socket_blackhole ingress throughput 255.97KiB/CPU-s 1.92 100.00% 13.02MiB/CPU-s 445.87KiB/CPU-s 5.75KiB/CPU-s 0.0 0.03344 13.27MiB/CPU-s 335.84KiB/CPU-s 4.33KiB/CPU-s 0.0 0.024713 False False
splunk_hec_route_s3 ingress throughput 144.92KiB/CPU-s 1.25 100.00% 11.33MiB/CPU-s 737.32KiB/CPU-s 9.51KiB/CPU-s 0.0 0.063545 11.47MiB/CPU-s 690.93KiB/CPU-s 8.92KiB/CPU-s 0.0 0.058812 False False
syslog_log2metric_splunk_hec_metrics ingress throughput 111.86KiB/CPU-s 1.21 100.00% 9.05MiB/CPU-s 226.61KiB/CPU-s 2.92KiB/CPU-s 0.0 0.024446 9.16MiB/CPU-s 361.19KiB/CPU-s 4.66KiB/CPU-s 0.0 0.038501 False False
datadog_agent_remap_blackhole ingress throughput 314.92KiB/CPU-s 1.04 100.00% 29.71MiB/CPU-s 1.28MiB/CPU-s 16.95KiB/CPU-s 0.0 0.0432 30.01MiB/CPU-s 1.78MiB/CPU-s 23.59KiB/CPU-s 0.0 0.059463 False False
syslog_loki ingress throughput 79.16KiB/CPU-s 0.94 100.00% 8.2MiB/CPU-s 348.94KiB/CPU-s 4.5KiB/CPU-s 0.0 0.041554 8.28MiB/CPU-s 376.36KiB/CPU-s 4.86KiB/CPU-s 0.0 0.044401 False False
file_to_blackhole egress throughput 65.82KiB/CPU-s 0.89 25.39% 7.2MiB/CPU-s 4.05MiB/CPU-s 142.91KiB/CPU-s 0.0 0.562551 7.26MiB/CPU-s 4.09MiB/CPU-s 144.48KiB/CPU-s 0.0 0.563391 True True
datadog_agent_remap_datadog_logs ingress throughput 259.83KiB/CPU-s 0.79 100.00% 32.09MiB/CPU-s 1.36MiB/CPU-s 18.03KiB/CPU-s 0.0 0.042533 32.34MiB/CPU-s 1.27MiB/CPU-s 16.76KiB/CPU-s 0.0 0.03922 False False
syslog_regex_logs2metric_ddmetrics ingress throughput 24.33KiB/CPU-s 0.68 99.99% 3.49MiB/CPU-s 363.66KiB/CPU-s 4.69KiB/CPU-s 0.0 0.101694 3.52MiB/CPU-s 300.37KiB/CPU-s 3.88KiB/CPU-s 0.0 0.083426 True True
datadog_agent_remap_datadog_logs_acks ingress throughput 163.04KiB/CPU-s 0.50 100.00% 32.08MiB/CPU-s 1.21MiB/CPU-s 16.04KiB/CPU-s 0.0 0.037844 32.24MiB/CPU-s 1.1MiB/CPU-s 14.5KiB/CPU-s 0.0 0.034035 False False
otlp_http_to_blackhole ingress throughput 7.23KiB/CPU-s 0.46 99.97% 1.55MiB/CPU-s 109.54KiB/CPU-s 1.41KiB/CPU-s 0.0 0.068926 1.56MiB/CPU-s 109.98KiB/CPU-s 1.42KiB/CPU-s 0.0 0.068893 False False
http_to_http_json ingress throughput 53.14KiB/CPU-s 0.38 100.00% 13.57MiB/CPU-s 302.96KiB/CPU-s 3.91KiB/CPU-s 0.0 0.021803 13.62MiB/CPU-s 229.28KiB/CPU-s 2.96KiB/CPU-s 0.0 0.016437 False False
otlp_grpc_to_blackhole ingress throughput 2.95KiB/CPU-s 0.29 99.98% 1.01MiB/CPU-s 45.72KiB/CPU-s 604.37B/CPU-s 0.0 0.044217 1.01MiB/CPU-s 39.98KiB/CPU-s 528.51B/CPU-s 0.0 0.038551 False False
http_to_http_acks ingress throughput 9.88KiB/CPU-s 0.19 15.24% 5.21MiB/CPU-s 2.74MiB/CPU-s 36.19KiB/CPU-s 0.0 0.525841 5.22MiB/CPU-s 2.76MiB/CPU-s 36.49KiB/CPU-s 0.0 0.529234 True False
enterprise_http_to_http ingress throughput 4.34KiB/CPU-s 0.03 77.98% 13.62MiB/CPU-s 229.61KiB/CPU-s 2.96KiB/CPU-s 0.0 0.016462 13.62MiB/CPU-s 150.04KiB/CPU-s 1.94KiB/CPU-s 0.0 0.010754 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput 273.4B/CPU-s 0.00 4.44% 13.62MiB/CPU-s 264.48KiB/CPU-s 3.41KiB/CPU-s 0.0 0.018968 13.62MiB/CPU-s 261.49KiB/CPU-s 3.37KiB/CPU-s 0.0 0.018753 False False
splunk_hec_indexer_ack_blackhole ingress throughput 173.8B/CPU-s 0.00 2.79% 13.61MiB/CPU-s 267.06KiB/CPU-s 3.44KiB/CPU-s 0.0 0.019154 13.61MiB/CPU-s 264.99KiB/CPU-s 3.42KiB/CPU-s 0.0 0.019006 False False
fluent_elasticsearch ingress throughput 306.57B/CPU-s 0.00 42.02% 45.41MiB/CPU-s 30.32KiB/CPU-s 396.3B/CPU-s 0.0 0.000652 45.41MiB/CPU-s 29.58KiB/CPU-s 386.56B/CPU-s 0.0 0.000636 False False
http_to_http_noack ingress throughput -6.0KiB/CPU-s -0.04 61.09% 13.61MiB/CPU-s 354.79KiB/CPU-s 4.58KiB/CPU-s 0.0 0.025456 13.6MiB/CPU-s 406.89KiB/CPU-s 5.25KiB/CPU-s 0.0 0.029206 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput -6.07KiB/CPU-s -0.04 62.33% 13.61MiB/CPU-s 363.17KiB/CPU-s 4.68KiB/CPU-s 0.0 0.026047 13.61MiB/CPU-s 388.55KiB/CPU-s 5.01KiB/CPU-s 0.0 0.02788 False False
datadog_agent_remap_blackhole_acks ingress throughput -145.45KiB/CPU-s -0.47 100.00% 30.31MiB/CPU-s 1.6MiB/CPU-s 21.12KiB/CPU-s 0.0 0.052715 30.17MiB/CPU-s 952.33KiB/CPU-s 12.29KiB/CPU-s 0.0 0.030822 False False
syslog_log2metric_humio_metrics ingress throughput -61.11KiB/CPU-s -0.95 100.00% 6.31MiB/CPU-s 187.43KiB/CPU-s 2.42KiB/CPU-s 0.0 0.029003 6.25MiB/CPU-s 234.62KiB/CPU-s 3.03KiB/CPU-s 0.0 0.036652 False False
syslog_humio_logs ingress throughput -95.23KiB/CPU-s -1.05 100.00% 8.82MiB/CPU-s 205.43KiB/CPU-s 2.65KiB/CPU-s 0.0 0.022736 8.73MiB/CPU-s 404.73KiB/CPU-s 5.22KiB/CPU-s 0.0 0.045271 False False
http_text_to_http_json ingress throughput -328.58KiB/CPU-s -1.30 100.00% 24.65MiB/CPU-s 728.39KiB/CPU-s 9.4KiB/CPU-s 0.0 0.028859 24.33MiB/CPU-s 594.63KiB/CPU-s 7.68KiB/CPU-s 0.0 0.02387 False False

@fuchsnj fuchsnj marked this pull request as ready for review April 18, 2023 14:30
@fuchsnj fuchsnj requested review from a team and spencergilbert as code owners April 18, 2023 14:30
@fuchsnj fuchsnj requested a review from a team April 18, 2023 14:30
src/codecs/decoding/decoder.rs Outdated Show resolved Hide resolved
src/sources/aws_s3/mod.rs Show resolved Hide resolved
src/sources/aws_s3/sqs.rs Outdated Show resolved Hide resolved
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for what appears to be a leftover allow

src/sources/aws_s3/mod.rs Show resolved Hide resolved
src/sources/aws_s3/sqs.rs Outdated Show resolved Hide resolved
src/codecs/decoding/decoder.rs Outdated Show resolved Hide resolved
src/sources/aws_s3/sqs.rs Outdated Show resolved Hide resolved
deserializer: Deserializer,
log_namespace: LogNamespace,
/// The framer being used.
pub framer: Framer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes generally look good, but I'm missing what is special about the aws_s3 source that required these to be public where they weren't before. What necessitated this change (same with newline_delimited.rs above)?

Copy link
Member Author

@fuchsnj fuchsnj Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Decoder, the way S3 utilizes the decoder is a bit unique since it also allows a "multiline" config. The framing and decoding are done separately with the "multiline" code happening in the middle. So the code needed access to the individual parts.

For newline_delimited.rs, this is the first source that uses this as the default. This default was kept for backwards compatibility since it was previously hard-coded.

I could have added methods to access / modify these values instead of making them public, but since these types are simple data containers, it doesn't matter too much.

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Apr 28, 2023

Datadog Report

Branch report: fuchsnj/aws_s3_codecs
Commit report: c860447

vector: 0 Failed, 0 New Flaky, 2164 Passed, 0 Skipped, 10m 44.26s Wall Time

@github-actions
Copy link

Regression Detector Results

Run ID: e31df4b0-8302-4fa3-b6f5-be6c8f75ba57
Baseline: d286d16
Comparison: 630e429
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
otlp_http_to_blackhole ingress throughput +2.71 [+2.53, +2.88] 100.00%
http_to_http_acks ingress throughput +1.76 [+0.52, +3.00] 93.05%
datadog_agent_remap_blackhole_acks ingress throughput +1.24 [+1.14, +1.34] 100.00%
socket_to_socket_blackhole ingress throughput +1.01 [+0.95, +1.07] 100.00%
syslog_splunk_hec_logs ingress throughput +0.82 [+0.76, +0.89] 100.00%
http_to_http_json ingress throughput +0.64 [+0.59, +0.69] 100.00%
http_to_http_noack ingress throughput +0.06 [+0.00, +0.12] 80.33%
file_to_blackhole ingress throughput +0.05 [+0.00, +0.10] 82.74%
enterprise_http_to_http ingress throughput +0.04 [+0.01, +0.08] 89.74%
splunk_hec_route_s3 ingress throughput +0.01 [-0.12, +0.14] 9.63%
splunk_hec_indexer_ack_blackhole ingress throughput +0.01 [-0.04, +0.05] 13.11%
fluent_elasticsearch ingress throughput +0.00 [-0.00, +0.00] 41.90%
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.07, +0.06] 5.43%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.05, +0.04] 16.20%
syslog_humio_logs ingress throughput -0.20 [-0.28, -0.11] 99.70%
datadog_agent_remap_datadog_logs_acks ingress throughput -0.36 [-0.45, -0.26] 100.00%
otlp_grpc_to_blackhole ingress throughput -0.52 [-0.64, -0.40] 100.00%
datadog_agent_remap_blackhole ingress throughput -1.10 [-1.20, -1.00] 100.00%
syslog_log2metric_splunk_hec_metrics ingress throughput -1.10 [-1.16, -1.05] 100.00%
http_text_to_http_json ingress throughput -1.42 [-1.47, -1.36] 100.00%
datadog_agent_remap_datadog_logs ingress throughput -1.46 [-1.59, -1.34] 100.00%
syslog_loki ingress throughput -1.76 [-1.85, -1.67] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput -3.00 [-3.25, -2.75] 100.00%
syslog_log2metric_humio_metrics ingress throughput -4.93 [-5.05, -4.81] 100.00%

@fuchsnj fuchsnj merged commit d648c86 into master Apr 28, 2023
@fuchsnj fuchsnj deleted the fuchsnj/aws_s3_codecs branch April 28, 2023 20:52
aholmberg pushed a commit to aholmberg/vector that referenced this pull request Feb 14, 2024
# [1.13.0](answerbook/vector@v1.12.1...v1.13.0) (2023-09-13)

### Bug Fixes

* **appsignal sink**: Add TLS config option (vectordotdev#17122) [198068c](answerbook/vector@198068c) - GitHub
* **buffers**: correctly handle partial writes in reader seek during initialization (vectordotdev#17099) [a791595](answerbook/vector@a791595) - GitHub
* **config**: recurse through schema refs when determining eligibility for unevaluated properties (vectordotdev#17150) [71d1bf6](answerbook/vector@71d1bf6) - GitHub
* **docker_logs source**: Support tcp schema [e1c0c02](answerbook/vector@e1c0c02) - GitHub
* **elasticsearch sink**:  Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (vectordotdev#17226) (vectordotdev#17227) [9b6ef24](answerbook/vector@9b6ef24) - GitHub
* **gcp_stackdriver_metrics sink**: Call function to regenerate auth token (vectordotdev#17297) [bf7904b](answerbook/vector@bf7904b) - GitHub
* **influxdb_logs**: encode influx line when no tags present (vectordotdev#17029) [c3aa14f](answerbook/vector@c3aa14f) - GitHub
* **reduce transform**: Revert flushing on interval change to `expire_metrics_ms` (vectordotdev#17084) [e86b155](answerbook/vector@e86b155) - GitHub
* **releasing**: Fix globbing of release artifacts for GitHub (vectordotdev#17114) [7fe089c](answerbook/vector@7fe089c) - GitHub
* **schemas**: Dont panic with non object field kinds (vectordotdev#17140) [1e43208](answerbook/vector@1e43208) - GitHub

### Chores

* (syslog source): add source_ip to some syslog tests (vectordotdev#17235) [29c34c0](answerbook/vector@29c34c0) - GitHub
* add note to DEVELOPING.md re panics (vectordotdev#17277) [03e905e](answerbook/vector@03e905e) - GitHub
* Add UX note about encoding of log_schema keys (vectordotdev#17266) [dc6e54c](answerbook/vector@dc6e54c) - GitHub
* **administration**: add `appsignal` to codeowners (vectordotdev#17127) [7b15d19](answerbook/vector@7b15d19) - GitHub
* **buffer**: tidy up some of the module level docs for `disk_v2` (vectordotdev#17093) [edaa612](answerbook/vector@edaa612) - GitHub
* **ci**: bump docker/metadata-action from 4.3.0 to 4.4.0 (vectordotdev#17170) [854d71e](answerbook/vector@854d71e) - GitHub
* **ci**: Disable `appsignal` integration test until CA issues are resolved (vectordotdev#17109) [f3b5d42](answerbook/vector@f3b5d42) - GitHub
* **ci**: Disable scheduled runs of Baseline Timings workflow (vectordotdev#17281) [4335b0a](answerbook/vector@4335b0a) - GitHub
* **ci**: Fix event assertions for `aws_ec2_metadata` transform (vectordotdev#17413) [da36fb6](answerbook/vector@da36fb6) - GitHub
* **ci**: Increase timeout for integration tests (vectordotdev#17326) [e1f125a](answerbook/vector@e1f125a) - GitHub
* **ci**: Increase timeout for integration tests to 30m (vectordotdev#17350) [5d3f619](answerbook/vector@5d3f619) - GitHub
* **ci**: re-enable `appsignal` integration test (vectordotdev#17111) [48fc574](answerbook/vector@48fc574) - GitHub
* **ci**: Remove ci-sweep tasks (vectordotdev#17415) [5c33f99](answerbook/vector@5c33f99) - GitHub
* **ci**: remove unnecessary dep install (vectordotdev#17128) [f56d1ef](answerbook/vector@f56d1ef) - GitHub
* **ci**: Try to fix apt retries (vectordotdev#17393) [6b3db04](answerbook/vector@6b3db04) - GitHub
* **ci**: update unsupported ubuntu version runners (vectordotdev#17113) [e7c4815](answerbook/vector@e7c4815) - GitHub
* **ci**: use python v3.8 in ubuntu 20.04 runner (vectordotdev#17116) [7a40c81](answerbook/vector@7a40c81) - GitHub
* **config**: begin laying out primitives for programmatically querying schema (vectordotdev#17130) [aad8115](answerbook/vector@aad8115) - GitHub
* **config**: emit human-friendly version of enum variant/property names in schema (vectordotdev#17171) [3b38ba8](answerbook/vector@3b38ba8) - GitHub
* **config**: improve config schema output with more precise `unevaluatedProperties` + schema ref flattening (vectordotdev#17026) [2d72f82](answerbook/vector@2d72f82) - GitHub
* **deps**: Add 3rd party license file and CI checks (vectordotdev#17344) [7350e1a](answerbook/vector@7350e1a) - GitHub
* **deps**: bump anyhow from 1.0.70 to 1.0.71 (vectordotdev#17300) [6a5af3b](answerbook/vector@6a5af3b) - GitHub
* **deps**: bump assert_cmd from 2.0.10 to 2.0.11 (vectordotdev#17290) [c4784fd](answerbook/vector@c4784fd) - GitHub
* **deps**: bump async-compression from 0.3.15 to 0.4.0 (vectordotdev#17365) [b9aac47](answerbook/vector@b9aac47) - GitHub
* **deps**: bump async-graphql from 5.0.7 to 5.0.8 (vectordotdev#17357) [05a4f17](answerbook/vector@05a4f17) - GitHub
* **deps**: bump async-graphql-warp from 5.0.7 to 5.0.8 (vectordotdev#17367) [693584e](answerbook/vector@693584e) - GitHub
* **deps**: bump async-stream from 0.3.4 to 0.3.5 (vectordotdev#17076) [c29c817](answerbook/vector@c29c817) - GitHub
* **deps**: bump aws-sigv4 from 0.55.0 to 0.55.1 (vectordotdev#17138) [dbb3f25](answerbook/vector@dbb3f25) - GitHub
* **deps**: bump axum from 0.6.12 to 0.6.18 (vectordotdev#17257) [41ac76e](answerbook/vector@41ac76e) - GitHub
* **deps**: bump cached from 0.42.0 to 0.43.0 (vectordotdev#17118) [f90b3b3](answerbook/vector@f90b3b3) - GitHub
* **deps**: bump chrono-tz from 0.8.1 to 0.8.2 (vectordotdev#17088) [623b838](answerbook/vector@623b838) - GitHub
* **deps**: bump clap_complete from 4.2.0 to 4.2.1 (vectordotdev#17229) [d286d16](answerbook/vector@d286d16) - GitHub
* **deps**: bump clap_complete from 4.2.1 to 4.2.2 (vectordotdev#17359) [565668e](answerbook/vector@565668e) - GitHub
* **deps**: bump clap_complete from 4.2.2 to 4.2.3 (vectordotdev#17383) [111cd07](answerbook/vector@111cd07) - GitHub
* **deps**: bump console-subscriber from 0.1.8 to 0.1.9 (vectordotdev#17358) [97b862c](answerbook/vector@97b862c) - GitHub
* **deps**: bump directories from 5.0.0 to 5.0.1 (vectordotdev#17271) [be69f5f](answerbook/vector@be69f5f) - GitHub
* **deps**: bump dunce from 1.0.3 to 1.0.4 (vectordotdev#17244) [cfc387d](answerbook/vector@cfc387d) - GitHub
* **deps**: bump enumflags2 from 0.7.5 to 0.7.6 (vectordotdev#17079) [cbc17be](answerbook/vector@cbc17be) - GitHub
* **deps**: bump enumflags2 from 0.7.6 to 0.7.7 (vectordotdev#17206) [c80c5eb](answerbook/vector@c80c5eb) - GitHub
* **deps**: bump flate2 from 1.0.25 to 1.0.26 (vectordotdev#17320) [ef13370](answerbook/vector@ef13370) - GitHub
* **deps**: bump getrandom from 0.2.8 to 0.2.9 (vectordotdev#17101) [d53240b](answerbook/vector@d53240b) - GitHub
* **deps**: bump h2 from 0.3.18 to 0.3.19 (vectordotdev#17388) [6088abd](answerbook/vector@6088abd) - GitHub
* **deps**: bump hashlink from 0.8.1 to 0.8.2 (vectordotdev#17419) [01b3cd7](answerbook/vector@01b3cd7) - GitHub
* **deps**: bump hyper from 0.14.25 to 0.14.26 (vectordotdev#17347) [c43dcfd](answerbook/vector@c43dcfd) - GitHub
* **deps**: bump inventory from 0.3.5 to 0.3.6 (vectordotdev#17401) [5b5ad16](answerbook/vector@5b5ad16) - GitHub
* **deps**: bump libc from 0.2.140 to 0.2.141 (vectordotdev#17104) [dd9608a](answerbook/vector@dd9608a) - GitHub
* **deps**: bump libc from 0.2.141 to 0.2.142 (vectordotdev#17273) [bc618a2](answerbook/vector@bc618a2) - GitHub
* **deps**: bump libc from 0.2.142 to 0.2.143 (vectordotdev#17338) [6afe206](answerbook/vector@6afe206) - GitHub
* **deps**: bump libc from 0.2.143 to 0.2.144 (vectordotdev#17346) [99b8dc1](answerbook/vector@99b8dc1) - GitHub
* **deps**: bump memmap2 from 0.5.10 to 0.6.0 (vectordotdev#17355) [dae0c6a](answerbook/vector@dae0c6a) - GitHub
* **deps**: bump memmap2 from 0.6.0 to 0.6.1 (vectordotdev#17364) [58ba741](answerbook/vector@58ba741) - GitHub
* **deps**: bump metrics, metrics-tracing-context, metrics-util (vectordotdev#17336) [9a723e3](answerbook/vector@9a723e3) - GitHub
* **deps**: bump mlua from 0.8.8 to 0.8.9 (vectordotdev#17423) [57f8bd4](answerbook/vector@57f8bd4) - GitHub
* **deps**: bump mock_instant from 0.2.1 to 0.3.0 (vectordotdev#17210) [40c9afc](answerbook/vector@40c9afc) - GitHub
* **deps**: bump mongodb from 2.4.0 to 2.5.0 (vectordotdev#17337) [64f4f69](answerbook/vector@64f4f69) - GitHub
* **deps**: bump nkeys from 0.2.0 to 0.3.0 (vectordotdev#17421) [3320eda](answerbook/vector@3320eda) - GitHub
* **deps**: bump notify from 5.1.0 to 6.0.0 (vectordotdev#17422) [58603b9](answerbook/vector@58603b9) - GitHub
* **deps**: bump num_enum from 0.5.11 to 0.6.0 (vectordotdev#17106) [42f298b](answerbook/vector@42f298b) - GitHub
* **deps**: bump num_enum from 0.6.0 to 0.6.1 (vectordotdev#17272) [f696e7b](answerbook/vector@f696e7b) - GitHub
* **deps**: bump opendal from 0.30.5 to 0.31.0 (vectordotdev#17119) [8762563](answerbook/vector@8762563) - GitHub
* **deps**: bump opendal from 0.31.0 to 0.33.2 (vectordotdev#17286) [3d41931](answerbook/vector@3d41931) - GitHub
* **deps**: bump opendal from 0.33.2 to 0.34.0 (vectordotdev#17354) [ae602da](answerbook/vector@ae602da) - GitHub
* **deps**: bump openssl from 0.10.48 to 0.10.50 (vectordotdev#17087) [9a56ed8](answerbook/vector@9a56ed8) - GitHub
* **deps**: bump openssl from 0.10.50 to 0.10.52 (vectordotdev#17299) [0ecceb3](answerbook/vector@0ecceb3) - GitHub
* **deps**: bump pin-project from 1.0.12 to 1.1.0 (vectordotdev#17385) [e8d3002](answerbook/vector@e8d3002) - GitHub
* **deps**: bump prettydiff from 0.6.2 to 0.6.4 (vectordotdev#17089) [e090610](answerbook/vector@e090610) - GitHub
* **deps**: bump prettydiff from 0.6.2 to 0.6.4 (vectordotdev#17315) [a1ec68d](answerbook/vector@a1ec68d) - GitHub
* **deps**: bump proc-macro2 from 1.0.55 to 1.0.56 (vectordotdev#17103) [6f74523](answerbook/vector@6f74523) - GitHub
* **deps**: bump proc-macro2 from 1.0.56 to 1.0.57 (vectordotdev#17400) [a6e1ae7](answerbook/vector@a6e1ae7) - GitHub
* **deps**: bump prost-build from 0.11.8 to 0.11.9 (vectordotdev#17260) [a88aba4](answerbook/vector@a88aba4) - GitHub
* **deps**: bump quote from 1.0.26 to 1.0.27 (vectordotdev#17348) [f81ff18](answerbook/vector@f81ff18) - GitHub
* **deps**: bump rdkafka from 0.29.0 to 0.30.0 (vectordotdev#17387) [9703188](answerbook/vector@9703188) - GitHub
* **deps**: bump regex from 1.7.3 to 1.8.1 (vectordotdev#17222) [410aa3c](answerbook/vector@410aa3c) - GitHub
* **deps**: bump reqwest from 0.11.16 to 0.11.17 (vectordotdev#17316) [09176ec](answerbook/vector@09176ec) - GitHub
* **deps**: bump security-framework from 2.8.2 to 2.9.0 (vectordotdev#17386) [1287168](answerbook/vector@1287168) - GitHub
* **deps**: bump serde from 1.0.159 to 1.0.160 (vectordotdev#17270) [036ad4a](answerbook/vector@036ad4a) - GitHub
* **deps**: bump serde from 1.0.160 to 1.0.162 (vectordotdev#17317) [79e97a2](answerbook/vector@79e97a2) - GitHub
* **deps**: bump serde from 1.0.162 to 1.0.163 (vectordotdev#17366) [9852c17](answerbook/vector@9852c17) - GitHub
* **deps**: bump serde_json from 1.0.95 to 1.0.96 (vectordotdev#17258) [7570bb3](answerbook/vector@7570bb3) - GitHub
* **deps**: bump serde_with from 2.3.1 to 2.3.2 (vectordotdev#17090) [adbf4d5](answerbook/vector@adbf4d5) - GitHub
* **deps**: bump serde_yaml from 0.9.19 to 0.9.21 (vectordotdev#17120) [d6f2625](answerbook/vector@d6f2625) - GitHub
* **deps**: bump socket2 from 0.4.7 to 0.5.2 (vectordotdev#17121) [db39d83](answerbook/vector@db39d83) - GitHub
* **deps**: bump socket2 from 0.5.2 to 0.5.3 (vectordotdev#17384) [ac51b8a](answerbook/vector@ac51b8a) - GitHub
* **deps**: bump syslog from 6.0.1 to 6.1.0 (vectordotdev#17301) [61e6154](answerbook/vector@61e6154) - GitHub
* **deps**: bump tokio from 1.27.0 to 1.28.0 (vectordotdev#17231) [8067f84](answerbook/vector@8067f84) - GitHub
* **deps**: bump tokio from 1.28.0 to 1.28.1 (vectordotdev#17368) [ae6a51b](answerbook/vector@ae6a51b) - GitHub
* **deps**: bump tokio-stream from 0.1.12 to 0.1.14 (vectordotdev#17339) [80c8247](answerbook/vector@80c8247) - GitHub
* **deps**: bump tokio-tungstenite from 0.18.0 to 0.19.0 (vectordotdev#17404) [ae1dd6e](answerbook/vector@ae1dd6e) - GitHub
* **deps**: bump tonic from 0.8.3 to 0.9.1 (vectordotdev#17077) [eafba69](answerbook/vector@eafba69) - GitHub
* **deps**: bump tonic from 0.9.1 to 0.9.2 (vectordotdev#17221) [aa9cbd0](answerbook/vector@aa9cbd0) - GitHub
* **deps**: bump tonic-build from 0.8.4 to 0.9.2 (vectordotdev#17274) [e0a07c6](answerbook/vector@e0a07c6) - GitHub
* **deps**: bump tracing-subscriber from 0.3.16 to 0.3.17 (vectordotdev#17268) [1406c08](answerbook/vector@1406c08) - GitHub
* **deps**: bump typetag from 0.2.7 to 0.2.8 (vectordotdev#17302) [c8e0e5f](answerbook/vector@c8e0e5f) - GitHub
* **deps**: bump uuid from 1.3.0 to 1.3.1 (vectordotdev#17091) [9cc2f1d](answerbook/vector@9cc2f1d) - GitHub
* **deps**: bump uuid from 1.3.0 to 1.3.2 (vectordotdev#17256) [bc6f7fd](answerbook/vector@bc6f7fd) - GitHub
* **deps**: bump uuid from 1.3.2 to 1.3.3 (vectordotdev#17403) [3a3fe63](answerbook/vector@3a3fe63) - GitHub
* **deps**: bump warp from 0.3.4 to 0.3.5 (vectordotdev#17288) [d8c1f12](answerbook/vector@d8c1f12) - GitHub
* **deps**: bump wasm-bindgen from 0.2.84 to 0.2.85 (vectordotdev#17356) [ea24b4d](answerbook/vector@ea24b4d) - GitHub
* **deps**: bump wasm-bindgen from 0.2.85 to 0.2.86 (vectordotdev#17402) [0518176](answerbook/vector@0518176) - GitHub
* **deps**: bump wiremock from 0.5.17 to 0.5.18 (vectordotdev#17092) [51312aa](answerbook/vector@51312aa) - GitHub
* **deps**: Fix up missing license (vectordotdev#17379) [a2b8903](answerbook/vector@a2b8903) - GitHub
* **deps**: Reset dependencies bumped by a61dea1 (vectordotdev#17100) [887d6d7](answerbook/vector@887d6d7) - GitHub
* **deps**: true up cargo.lock (vectordotdev#17149) [10fce65](answerbook/vector@10fce65) - GitHub
* **deps**: Update h2 (vectordotdev#17189) [a2882f3](answerbook/vector@a2882f3) - GitHub
* **deps**: Upgrade cue to 0.5.0 (vectordotdev#17204) [d396320](answerbook/vector@d396320) - GitHub
* **deps**: Upgrade Debian to bullseye for distroless image (vectordotdev#17160) [c304a8c](answerbook/vector@c304a8c) - GitHub
* **deps**: Upgrade rust to 1.69.0 (vectordotdev#17194) [ef15696](answerbook/vector@ef15696) - GitHub
* **dev**: Add note about generating licenses to CONTRIBUTING.md (vectordotdev#17410) [539f379](answerbook/vector@539f379) - GitHub
* **dev**: ignore `.helix` dir (vectordotdev#17203) [32a935b](answerbook/vector@32a935b) - GitHub
* **dev**: Install the correct `mold` based on CPU architecture (vectordotdev#17248) [4b80c71](answerbook/vector@4b80c71) - GitHub
* **dev**: remove editors from gitignore (vectordotdev#17267) [61c0d76](answerbook/vector@61c0d76) - GitHub
* **docs**: Add Enterprise link and update Support link (vectordotdev#17408) [5184d50](answerbook/vector@5184d50) - GitHub
* **docs**: Add missing 0.28.2 version [38607cd](answerbook/vector@38607cd) - Jesse Szwedko
* **docs**: Clarify `key_field` for `sample` and `throttle` transforms (vectordotdev#17372) [d1e5588](answerbook/vector@d1e5588) - GitHub
* **docs**: Document event type conditions (vectordotdev#17311) [a9c8dc8](answerbook/vector@a9c8dc8) - GitHub
* **docs**: make doc style edits (vectordotdev#17155) [65a8856](answerbook/vector@65a8856) - GitHub
* **docs**: Remove trailing, unmatched quote (vectordotdev#17163) [3c92556](answerbook/vector@3c92556) - GitHub
* **docs**: Remove unneeded `yaml` dependency from website (vectordotdev#17215) [752d424](answerbook/vector@752d424) - GitHub
* **docs**: Update component statuses 2023Q2 (vectordotdev#17362) [22cda94](answerbook/vector@22cda94) - GitHub
* **docs**: update the `v0.28.0` upgrade guide with note about `datadog_logs` sink `hostname` key (vectordotdev#17156) [c169131](answerbook/vector@c169131) - GitHub
* **external docs**: correctly mark some sinks as stateful (vectordotdev#17085) [64d560d](answerbook/vector@64d560d) - GitHub
* **loki sink**: warn on label expansions and collisions (vectordotdev#17052) [f06692b](answerbook/vector@f06692b) - GitHub
* **pulsar**: pulsar-rs bump to v5.1.1 (vectordotdev#17159) [68b54a9](answerbook/vector@68b54a9) - GitHub
* Re-add transform definitions (vectordotdev#17152) [9031d0f](answerbook/vector@9031d0f) - GitHub
* Regen docs for sample and throttle (vectordotdev#17390) [6c57ca0](answerbook/vector@6c57ca0) - GitHub
* **releasing**: Add known issues fixed by 0.29.1 (vectordotdev#17218) [40d543a](answerbook/vector@40d543a) - GitHub
* **releasing**: Bump Vector version to 0.30.0 (vectordotdev#17134) [3834612](answerbook/vector@3834612) - GitHub
* **releasing**: Fix homebrew release script (vectordotdev#17131) [cfbf233](answerbook/vector@cfbf233) - Jesse Szwedko
* **releasing**: Fix release channels (vectordotdev#17133) [58b44e8](answerbook/vector@58b44e8) - Jesse Szwedko
* **releasing**: Prepare v0.28.2 release [a61dea1](answerbook/vector@a61dea1) - Jesse Szwedko
* **releasing**: Prepare v0.29.0 release [4bf6805](answerbook/vector@4bf6805) - Jesse Szwedko
* **releasing**: Prepare v0.30.0 release [38c3f0b](answerbook/vector@38c3f0b) - Jesse Szwedko
* **releasing**: Regenerate Kubernetes manifests for 0.21.2 (vectordotdev#17108) [fd13d64](answerbook/vector@fd13d64) - GitHub
* **releasing**: Regenerate manifests for 0.21.1 chart (vectordotdev#17187) [1f0de6b](answerbook/vector@1f0de6b) - GitHub
* **releasing**: Regenerate manifests for 0.22.0 chart (vectordotdev#17135) [e7ea0a8](answerbook/vector@e7ea0a8) - GitHub
* **releasing**: update patch release template with extra step details [27c3526](answerbook/vector@27c3526) - GitHub
* Remove skaffold from project (vectordotdev#17145) [d245927](answerbook/vector@d245927) - GitHub
* remove transform type coercion (vectordotdev#17411) [b6c7e0a](answerbook/vector@b6c7e0a) - GitHub
* Revert transform definitions (vectordotdev#17146) [05a3f44](answerbook/vector@05a3f44) - GitHub
* **socket source**: Remove deprecated `max_length` setting from `tcp` and `unix` modes. (vectordotdev#17162) [9ecfc8c](answerbook/vector@9ecfc8c) - GitHub
* **syslog source**: remove the remove of source_ip (vectordotdev#17184) [5dff0ed](answerbook/vector@5dff0ed) - GitHub
* **topology**: Transform outputs hash table of OutputId -> Definition (vectordotdev#17059) [1bdb24d](answerbook/vector@1bdb24d) - GitHub
* Upgrade `VRL` to `0.3.0` (vectordotdev#17325) [4911d36](answerbook/vector@4911d36) - GitHub

### Features

* adds 'metric_name' field to internal logs for the tag_cardinality_limit component (vectordotdev#17295) [4317340](answerbook/vector@4317340) - GitHub
* **codecs**: Add full codec support to AWS S3 source/sink (vectordotdev#17098) [d648c86](answerbook/vector@d648c86) - GitHub
* **kubernetes_logs**: use kube-apiserver cache for list requests (vectordotdev#17095) [e46fae7](answerbook/vector@e46fae7) - GitHub
* Merge with upstream v0.30.0 [6b93177](answerbook/vector@6b93177) - GitHub [LOG-17997](https://logdna.atlassian.net/browse/LOG-17997)
* **new sink**: Initial `datadog_events` sink (vectordotdev#7678) [fef3810](answerbook/vector@fef3810) - Jesse Szwedko
* Update VRL library [6ace1e6](answerbook/vector@6ace1e6) - Jorge Bay

### Miscellaneous

* Merge branch 'master' [d4b35bb](answerbook/vector@d4b35bb) - Jorge Bay
* Merge tag 'v0.30.0' into update-upstream [ee2f300](answerbook/vector@ee2f300) - Jorge Bay
* Merge commit '9031d0faa2811187874364e1b5a3305c9ed0c0da' into update-upstream [c12faae](answerbook/vector@c12faae) - Jorge Bay
* Improve tokio::select behavior for kafka source and finalizers (vectordotdev#17380) [d4df21c](answerbook/vector@d4df21c) - GitHub
* Prepare v0.29.1 release [21beed7](answerbook/vector@21beed7) - Kyle Criddle
* Add a quickfix to handle special capitalization cases (vectordotdev#17141) [ba63e21](answerbook/vector@ba63e21) - GitHub
* Adjust doc comment locations (vectordotdev#17154) [730c938](answerbook/vector@730c938) - GitHub
* **amqp sink**: Support AMQ Properties (content-type) in AMQP sink (vectordotdev#17174) [c10d30b](answerbook/vector@c10d30b) - GitHub
* **aws provider**: Let `region` be configured for default authentication (vectordotdev#17414) [c81ad30](answerbook/vector@c81ad30) - GitHub
* **core**: add unit test (ignored) for support for encoding special chars in `ProxyConfig` (vectordotdev#17148) [5247972](answerbook/vector@5247972) - GitHub
* **loki sink**: Fix formatting in labels example (vectordotdev#17396) [f3734e8](answerbook/vector@f3734e8) - GitHub
* **observability**: Log underlying error for unhandled HTTP errors (vectordotdev#17327) [bf8376c](answerbook/vector@bf8376c) - GitHub
* **observability**: Update internal log rate limiting messages (vectordotdev#17394) [1951535](answerbook/vector@1951535) - GitHub
* **pulsar sink**: Refactor to use StreamSink (vectordotdev#14345) [1e97a2f](answerbook/vector@1e97a2f) - GitHub
* **topology**: Add source id to metadata (vectordotdev#17369) [c683999](answerbook/vector@c683999) - GitHub
* **vdev**: Load compose files and inject network block (vectordotdev#17025) [5d88655](answerbook/vector@5d88655) - GitHub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants