Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't work with some special FTP response #25

Merged
merged 6 commits into from
Dec 27, 2022

Conversation

veeso
Copy link
Owner

@veeso veeso commented Dec 27, 2022

ISSUE 24 - Can't read some special FTP response

Fixes #24

Description

  • Don't use read to string from stream, but read line
  • Response body is now bytes

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I linted my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no C-bindings
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: functions which use streams

@veeso veeso linked an issue Dec 27, 2022 that may be closed by this pull request
@veeso veeso self-assigned this Dec 27, 2022
@veeso veeso added the bug Something isn't working label Dec 27, 2022
@veeso veeso merged commit 4c8c5b6 into main Dec 27, 2022
@veeso veeso deleted the 24-cant-work-with-some-sepecial-ftp-response branch December 27, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't work with some sepecial ftp response
1 participant