This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix retries option is not fully respected, fix not to throw error cau… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkzawa
requested review from
lucleray,
styfle and
TooTallNate
and removed request for
lucleray and
styfle
nkzawa
force-pushed
the
fix-retry-count-and-error
branch
from
5e3d2e8 to
f7b66ae
Compare
|
Looks good! Not entirely sure about:
Having a 12s delay was intentional (see #26), but I concede that it's not a one size fits all solution. |
|
@lucleray I don't know the reason of the PR but feel even |
|
@lucleray I'm still skeptical about waiting for that long by default, but reverted for now. Can you review again? |
nkzawa
force-pushed
the
fix-retry-count-and-error
branch
from
b4a9a12 to
f1bc660
Compare
lucleray
reviewed
Mar 2, 2020
lucleray
reviewed
Mar 2, 2020
lucleray
approved these changes
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sed by error status
retriesoption - 1 times. This PR fixes to respect the option.retriesoption from5to4because of the above problem and waiting for12960is too long.res.status >= 500. It used to happen when the last error is likeECONNREFUSEDbut the main error (the most frequent error) isres.status >= 500)