This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Retry on 429 and respect the Retry-After header #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkzawa
force-pushed
the
429-and-retry-after
branch
from
9818691 to
94a5ad4
Compare
nkzawa
force-pushed
the
fix-retry-count-and-error
branch
from
5e3d2e8 to
f7b66ae
Compare
nkzawa
force-pushed
the
429-and-retry-after
branch
from
94a5ad4 to
edaed29
Compare
lucleray
reviewed
Feb 26, 2020
| if ((res.status >= 500 && res.status < 600) || res.status === 429) { | ||
| // NOTE: doesn't support http-date format | ||
| const retryAfter = parseInt(res.headers.get('retry-after'), 10); | ||
| if (retryAfter) { |
There was a problem hiding this comment.
Can we add a maximum value for retryAfter? (ie. not retry if retryAfter is 2 hours). Maybe ~20s?
There was a problem hiding this comment.
Added the maxRetryAfter option which defaults to 20.
javivelasco
reviewed
Feb 26, 2020
nkzawa
force-pushed
the
429-and-retry-after
branch
from
edaed29 to
b38cac9
Compare
nkzawa
force-pushed
the
429-and-retry-after
branch
from
779ee71 to
3c148f9
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #30
It doesn't support
Retry-After: <http-date>for now