Upgrade to xterm 3.6.0 for column selection. Refs #2697 #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stanzilla
reviewed
Aug 17, 2018
yarn.lock
Outdated
| resolved "https://registry.yarnpkg.com/xterm/-/xterm-3.4.1.tgz#12452979ea2db3371f8195832d7407abba988980" | ||
| xterm@3.5.1: | ||
| version "3.5.1" | ||
| resolved "https://purecloud.artifactoryonline.com/purecloud/api/npm/inin-internal-npm/xterm/-/xterm-3.5.1.tgz#d2e62ab26108a771b7bd1b7be4f6578fb4aff922" |
There was a problem hiding this comment.
Updated - thanks for the catch 👍
jocull
force-pushed
the
issue-2697-column-selection
branch
2 times, most recently
from
17c0aeb to
7972bcd
Compare
|
You can probably update to 3.6 just as easily, it was mostly a stability release https://github.com/xtermjs/xterm.js/releases/tag/3.6.0 |
|
I’m not opposed. I only did 3.5.1 this time because 3.5 was minimum with the needed feature and may as well pick up the .1 for any bug fixes :) Tests did not complain and everything seemed fine with 3.5.1 - not sure if there’s anything else that really needs to be done. |
jocull
force-pushed
the
issue-2697-column-selection
branch
from
7972bcd to
62aa1fc
Compare
jocull
changed the title
|
merging this will allow us to use font ligatures again on Hyper, see https://github.com/tolbertam/hyper-font-ligatures |
|
I would actually wait for 3.7.0 as there was a pretty bad perf regression in either 3.5 or 3.6: xtermjs/xterm.js#1620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the xterm version bump required to enable the column selection feature. See #2697 for more details. I did not add anything for the
macOptionClickForcesSelectionoption mentioned, but it seems to work out-of-the-box just fine on my mac.