-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade xterm to 3.7.0 Refs: #3178 #3214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Also closes #3178 |
This one should take precedence over #3178 👍 |
Awesome, thank you @xbtsw |
@albinekb There's no merge button available for me. Please kindly merge. |
Would love to see this merged and published, as it will fix issues like jestjs/jest#6494. |
Yes, we need to merge this ASAP. |
What is the status on this? |
Waiting on someone else to approve, then we can merge. I have tested on macOS 10.12 and it works as expected. |
Can someone take a look at this? It's one line to approve 😓 |
It doesn't work as expected with many opened panes. How to reproduce:
I think there is some problem with term reattachment and listeners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate characters when many panes opened
#2697 and #2793 both need a new version of xterm, and 3.7.0 just got released.