Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stdlib package re from Python #51

Closed
nicasioca opened this issue Feb 22, 2021 · 2 comments
Closed

Port stdlib package re from Python #51

nicasioca opened this issue Feb 22, 2021 · 2 comments

Comments

@nicasioca
Copy link

Port the standard library for regular expressions from Python https://github.com/python/cpython/blob/3.9/Lib/re.py, like was done for the requests package https://github.com/verygoodsecurity/starlarky/blob/master/larky/src/main/resources/stdlib/urllib/request.star.

I'm assuming it would be part of "starlarky/larky/src/main/resources/stdlib/" (https://github.com/verygoodsecurity/starlarky/tree/master/larky/src/main/resources/stdlib).

@nicasioca
Copy link
Author

nicasioca commented Feb 22, 2021

I pushed the customer expectation out to next week, so beginning of March sometime. Thanks!
https://vgs.zendesk.com/agent/tickets/4648

@mahmoudimus
Copy link
Contributor

@nicasioca - please check #55 to see if this solves your problem.

mahmoudimus added a commit that referenced this issue Mar 30, 2021
* Checkpoint

* Fixes #28

* Add struct constructor enhancement and allow EvalException to propogate upwards

* Fixes #51

* Updated larky to use re2.split() to match the python re module

* wrap regular expression in namedtuple

* regular expression tests fully working

* Allow building java 1.8 with java 11 and allow building with java8 as well

* Restructure the larky project. Fixes #18.
la-luo pushed a commit to la-luo/starlarky that referenced this issue Sep 8, 2021
* Checkpoint

* Fixes verygoodsecurity#28

* Add struct constructor enhancement and allow EvalException to propogate upwards

* Fixes verygoodsecurity#51

* Updated larky to use re2.split() to match the python re module

* wrap regular expression in namedtuple

* regular expression tests fully working

* Allow building java 1.8 with java 11 and allow building with java8 as well

* Restructure the larky project. Fixes verygoodsecurity#18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants