Update Larky to enable parity with python stdlib (first pass) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslepakurov
approved these changes
Mar 2, 2021
mahmoudimus
changed the title
Merged
mahmoudimus
added a commit
that referenced
this pull request
Mar 30, 2021
* Checkpoint * Fixes #28 * Add struct constructor enhancement and allow EvalException to propogate upwards * Fixes #51 * Updated larky to use re2.split() to match the python re module * wrap regular expression in namedtuple * regular expression tests fully working * Allow building java 1.8 with java 11 and allow building with java8 as well * Restructure the larky project. Fixes #18.
la-luo
pushed a commit
to la-luo/starlarky
that referenced
this pull request
Sep 8, 2021
* Checkpoint * Fixes verygoodsecurity#28 * Add struct constructor enhancement and allow EvalException to propogate upwards * Fixes verygoodsecurity#51 * Updated larky to use re2.split() to match the python re module * wrap regular expression in namedtuple * regular expression tests fully working * Allow building java 1.8 with java 11 and allow building with java8 as well * Restructure the larky project. Fixes verygoodsecurity#18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the:
json.decodeandjson.encodeto python compatjson.loadsandjson.dumps#28)