Fix Failing CI setup #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmoudimus
added a commit
that referenced
this pull request
Mar 30, 2021
* use detected.name and detected.arch instead of .classifier which has better luck * Update reflect-config with new module structure from Larky * Missed larky.modules in front of larky.types Larky
la-luo
pushed a commit
to la-luo/starlarky
that referenced
this pull request
Sep 8, 2021
* use detected.name and detected.arch instead of .classifier which has better luck * Update reflect-config with new module structure from Larky * Missed larky.modules in front of larky.types Larky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our circleci setup is failing currently because of a minor problem that I ran into with os-maven-plugin when working on #55. After upgrading it to 1.7.0, I couldn't use
${os.detected.classifier}any longer so I had to pass a flag to maven locally. This transient change was probably due to a misconfigured environment on my part, so to fix it, I had found a workaround to the traditional way of installing this maven plugin. I set it up to use a<plugin/>instead of<extension/>. The goals this plugin ran on are not the same ones that we use in our circleci setup.This PR fixes the issue by reverting this change back to an
<extension/>and uses${os.detected.name}-${os.detected.arch}instead of${os.detected.classifier}which worked better for us.