Merge pull request #1130 from taichi-ishitani/fix_panic_on_check_ver_ref

Fix panic on `check_var_ref` checker
veryl-lang · Dec 9, 2024 · b3cc767 · b3cc767
2 parents ec030bd + 74a22eb
commit b3cc767
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/crates/analyzer/src/handlers/check_var_ref.rs b/crates/analyzer/src/handlers/check_var_ref.rs
@@ -184,11 +184,9 @@ impl VerylGrammarTrait for CheckVarRef<'_> {
                             Direction::Output => ExpressionTargetType::OutputPort,
                             Direction::Inout => ExpressionTargetType::InoutPort,
                             Direction::Ref => ExpressionTargetType::RefPort,
-                            _ => unreachable!(),
+                            _ => return Ok(()),
                         },
-                        _ => {
-                            return Ok(());
-                        }
+                        _ => return Ok(()),
                     };
                     self.add_expression(&path, r#type);
                 }

diff --git a/crates/analyzer/src/tests.rs b/crates/analyzer/src/tests.rs
@@ -2217,6 +2217,26 @@ fn invalid_factor_kind() {
 
     let errors = analyze(code);
     assert!(matches!(errors[0], AnalyzerError::InvalidFactor { .. }));
+
+    let code = r#"
+    interface InterfaceA {
+        var a: logic;
+        modport master {
+            a: input,
+        }
+    }
+    module ModuleA (
+        b: modport InterfaceA::master,
+    ) {
+        var a: logic;
+        always_comb {
+            a = b;
+        }
+    }
+    "#;
+
+    let errors = analyze(code);
+    assert!(matches!(errors[0], AnalyzerError::InvalidFactor { .. }));
 }
 
 #[test]