Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on check_var_ref checker #1130

Merged

Conversation

taichi-ishitani
Copy link
Contributor

@taichi-ishitani taichi-ishitani commented Dec 7, 2024

fix #1127
fix #1128

@taichi-ishitani
Copy link
Contributor Author

@nananapo

I think this PR can also be the fix for #1128.
Can you check if this PR acually resolves #1128?

@nananapo
Copy link
Contributor

nananapo commented Dec 7, 2024

OK

#1127

Error:
  × veryl check failed

Error: invalid_assignment (https://doc.veryl-lang.org/book/07_appendix/02_semantic_error.html#invalid_assignment)

  × a can't be assigned because it is instance
    ╭─[/home/kanataso/Documents/test/a.veryl:14:9]
 13 │     always_comb {
 14 │         a = b;
    ·         ┬
    ·         ╰── Error location
 15 │     }
    ╰────
  help: remove the assignment

Error: invalid_factor (https://doc.veryl-lang.org/book/07_appendix/02_semantic_error.html#invalid_factor)

  × b of kind "port" cannot be used as a factor in an expression
    ╭─[/home/kanataso/Documents/test/a.veryl:14:13]
 13 │     always_comb {
 14 │         a = b;
    ·             ┬
    ·             ╰── Error location
 15 │     }
    ╰────
  help: remove port from expression

#1128

Error:
  × veryl check failed

Error: invalid_factor (https://doc.veryl-lang.org/book/07_appendix/02_semantic_error.html#invalid_factor)

  × a of kind "port" cannot be used as a factor in an expression
    ╭─[/home/kanataso/Documents/test/a.veryl:24:28]
 23 │     }
 24 │     let _b: logic = myfunc(a);
    ·                            ┬
    ·                            ╰── Error location
 25 │ }
    ╰────
  help: remove port from expression

@taichi-ishitani taichi-ishitani force-pushed the fix_panic_on_check_ver_ref branch from 9376cce to 1ef2e38 Compare December 9, 2024 00:21
@taichi-ishitani taichi-ishitani force-pushed the fix_panic_on_check_ver_ref branch from 1ef2e38 to 74a22eb Compare December 9, 2024 00:28
@dalance dalance merged commit b3cc767 into veryl-lang:master Dec 9, 2024
7 checks passed
@taichi-ishitani taichi-ishitani deleted the fix_panic_on_check_ver_ref branch December 9, 2024 00:47
@dalance dalance added this to the v0.13.4 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic by passing modport interface to function panic by interface assign
3 participants