Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify Xandra query options #47

Closed
noaccOS opened this issue Jan 29, 2024 · 1 comment · Fixed by #48
Closed

Cannot specify Xandra query options #47

noaccOS opened this issue Jan 29, 2024 · 1 comment · Fixed by #48

Comments

@noaccOS
Copy link
Contributor

noaccOS commented Jan 29, 2024

Describe the bug
Xandra query options (eg :uuid_format) no longer work, crashing with ** (NimbleOptions.ValidationError) unknown options [:uuid_format], valid options are: [:compressor, :force, :tracing, :custom_payload, :telemetry_metadata, :timeout].

I believe this is because the same options are passed to Xandra.prepare and Xandra.execute, and with whatyouhide/xandra@f9c34be Xandra.prepare does no longer validate valid prepare options only.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a query with any custom option from Xandra.execute
  2. The error gets thrown

Expected behavior
Valid options are passed to Xandra.execute

Desktop (please complete the following information):

  • OS: NixOS 24.05 (Uakari)
  • Elixir: 1.16.0-OTP25
  • exandra: 0.10.1
  • xandra: 0.18.1
@whatyouhide whatyouhide changed the title Cannot specify xandra query options Cannot specify Xandra query options Jan 29, 2024
@whatyouhide
Copy link
Collaborator

Ah yes you caught it right away. I likely won't have time to fix this in Exandra until the weekend, any chance you want to give a PR a try? 👼

noaccOS added a commit to noaccOS/exandra that referenced this issue Feb 14, 2024
noaccOS added a commit to noaccOS/exandra that referenced this issue Feb 15, 2024
noaccOS added a commit to noaccOS/exandra that referenced this issue Feb 15, 2024
With this the :timeout option is also available to xandra functions
instead of being dropped.

Fixes vinniefranco#47
noaccOS added a commit to noaccOS/exandra that referenced this issue Feb 15, 2024
With this the :timeout option is also available to xandra functions
instead of being dropped.

Fixes vinniefranco#47
whatyouhide added a commit that referenced this issue Feb 15, 2024
Fixes #47.

With this, the ":timeout" option is also available to Xandra functions
instead of being dropped.

Co-authored-by: Andrea Leopardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants