Split Xandra prepare and execute options #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Feb 14, 2024
lib/exandra.ex
Outdated
| @@ -218,6 +218,34 @@ defmodule Exandra do | |||
| Xandra.Cluster | |||
| ) | |||
|
|
|||
| @xandra_prepare_opts [ | |||
There was a problem hiding this comment.
Instead of duplicating these lists and the logic here, can we create a Xandra.Connection.split_prepare_and_execute_options/1 and use that here?
There was a problem hiding this comment.
Done
Also fixed :telemetry_metadata and tests failing due to duplicate keys
noaccOS
force-pushed
the
fix/query-opts
branch
2 times, most recently
from
94ec441 to
4fa83eb
Compare
With this the :timeout option is also available to xandra functions instead of being dropped. Fixes vinniefranco#47
noaccOS
force-pushed
the
fix/query-opts
branch
from
4fa83eb to
0e941ae
Compare
whatyouhide
approved these changes
Feb 15, 2024
whatyouhide
reviewed
Feb 15, 2024
|
Thanks @noaccOS 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47