Update documentation and add initial project configurations #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Jan 20, 2024
CHANGELOG.md
Outdated
| @@ -2,28 +2,28 @@ | |||
|
|
|||
| ## v0.10.1 | |||
|
|
|||
| * Fix a bug with `nil` decimals that happens on Ecto 3.11+. | |||
There was a problem hiding this comment.
Can you please remove these whitespace changes? They're not necessary, and in addition I prefer the spaces there 🙃
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
Comment on lines
28
to
38
|
|
||
| - OS: [e.g. iOS] | ||
| - Browser [e.g. chrome, safari] | ||
| - Version [e.g. 22] | ||
|
|
||
| **Smartphone (please complete the following information):** | ||
| - Device: [e.g. iPhone6] | ||
| - OS: [e.g. iOS8.1] | ||
| - Browser [e.g. stock browser, safari] | ||
| - Version [e.g. 22] | ||
|
|
||
| - Device: [e.g. iPhone6] | ||
| - OS: [e.g. iOS8.1] | ||
| - Browser [e.g. stock browser, safari] | ||
| - Version [e.g. 22] |
There was a problem hiding this comment.
These are unnecessary changes, could you revert them?
README.md
Outdated
Comment on lines
35
to
37
| use Ecto.Repo, | ||
| otp_app: :my_app, | ||
| adapter: Exandra |
There was a problem hiding this comment.
Can you revert this change, as it's unnecessary?
README.md
Outdated
| @@ -61,7 +84,7 @@ field :features, :map | |||
|
|
|||
| you can pass the field as an Elixir map when setting it, and Exandra will convert it to a map | |||
| on the way from the database. Because Exandra uses JSON for this, you'll have to pay attention | |||
| to things such as atom keys (which can be used when writing, but will be strings when reading) | |||
| to things such as atom keys (which can be used when writing but will be strings when reading) | |||
There was a problem hiding this comment.
This is an unnecessary change, could you remove it?
README.md
Outdated
| @@ -133,7 +157,7 @@ defmodule AddUsers do | |||
| end | |||
| ``` | |||
|
|
|||
| > #### Cassandra and Scylla Types {: .info} | |||
| > ### Cassandra and Scylla Types {: .info} | |||
There was a problem hiding this comment.
Can you revert this change, as it's subjective?
|
@whatyouhide I've made the requested revisions and would appreciate your review. |
|
Thank you @Himanshu21git 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
Test Results: