Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update vitepress #11720

Merged
merged 5 commits into from
Jan 26, 2023
Merged

docs: update vitepress #11720

merged 5 commits into from
Jan 26, 2023

Conversation

kiaking
Copy link
Contributor

@kiaking kiaking commented Jan 17, 2023

Description

This PR updates VitePress to the latest version. With this release, VitePress contains a huge refinement on styles.

Vite docs are mostly unaffected, but I've deleted no longer required .dark scoped CSS variables, and made button white text to be pure white for better readability.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

Thanks! I noticed a minor change that seems unintentional.

  • Is this bottom border intended to be non-transparent even if the page isn't scrolled? The header itself is transparent when the page isn't scrolled.
    image

  • The scrollbar on the sidebar looks a bit strange.
    This PR
    image
    The previous version
    image

patak-dev
patak-dev previously approved these changes Jan 18, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely effect with the header for the landing! I wonder if the black border could also be transparent instead of solid when you are at the top.

The new theme is 🔥

@kiaking
Copy link
Contributor Author

kiaking commented Jan 18, 2023

@sapphi-red

The scrollbar on the sidebar looks a bit strange.

Thanks for catching this! This is happening because I've changed how header is structured, and now the header title section has BG color and probably hiding the sidebar underneath.

I think I can fix this. I'll update VitePress with this fix and update this PR.


@patak-dev

I wonder if the black border could also be transparent instead of solid when you are at the top.

The border was intended, but now I'm rethinking it 🤔

When I did this, I though especially in dark mode, this black "gutter" like border has cool sharp looking, like it got paper cut kinda, with consistency of following sections have the same border.

However, now that I think of, yea it would probably be cleaner, and when user scrolls, then that's the time they see further section and gets the "consistency" I was talking about.

So, I'll update VitePress to adjust this as well and update this PR 🔥

@kiaking
Copy link
Contributor Author

kiaking commented Jan 20, 2023

@patak-dev @sapphi-red Fixed both of the issue and updated the VitePress. It should be fixed. Can you guys please check it again 🙏

@sapphi-red
Copy link
Member

sapphi-red commented Jan 20, 2023

Thanks! It looks really nice. ✨

It seems there's three places with a transparent 1px line (at the bottom part of the header, on the left of the vite logo, and on the right of the …). You can see the line by scrolling down and then hovering on the stackblitz sponsor panel.
image
image

@kiaking
Copy link
Contributor Author

kiaking commented Jan 20, 2023

Ah, damn, thank for the check! It happens on specific viewport 😅 I'll fix it!

@kiaking
Copy link
Contributor Author

kiaking commented Jan 20, 2023

OK, I think it's fixed 👀

Screen Shot 2023-01-20 at 20 22 15

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Jan 20, 2023
sapphi-red
sapphi-red previously approved these changes Jan 20, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀 🚀 🚀

bluwy
bluwy previously approved these changes Jan 23, 2023
@patak-dev patak-dev dismissed stale reviews from bluwy and sapphi-red via 4d77c9b January 26, 2023 09:51
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The netlify build is failing but I think it's fine. I guess it's failing because the base commit is before my fix commit.

@patak-dev patak-dev merged commit c5b935a into vitejs:main Jan 26, 2023
@sapphi-red sapphi-red mentioned this pull request Jan 26, 2023
9 tasks
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants