-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update vitepress #11720
docs: update vitepress #11720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely effect with the header for the landing! I wonder if the black border could also be transparent instead of solid when you are at the top.
The new theme is 🔥
Thanks for catching this! This is happening because I've changed how header is structured, and now the header title section has BG color and probably hiding the sidebar underneath. I think I can fix this. I'll update VitePress with this fix and update this PR.
The border was intended, but now I'm rethinking it 🤔 When I did this, I though especially in dark mode, this black "gutter" like border has cool sharp looking, like it got paper cut kinda, with consistency of following sections have the same border. However, now that I think of, yea it would probably be cleaner, and when user scrolls, then that's the time they see further section and gets the "consistency" I was talking about. So, I'll update VitePress to adjust this as well and update this PR 🔥 |
@patak-dev @sapphi-red Fixed both of the issue and updated the VitePress. It should be fixed. Can you guys please check it again 🙏 |
Ah, damn, thank for the check! It happens on specific viewport 😅 I'll fix it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The netlify build is failing but I think it's fine. I guess it's failing because the base commit is before my fix commit.
Description
This PR updates VitePress to the latest version. With this release, VitePress contains a huge refinement on styles.
Vite docs are mostly unaffected, but I've deleted no longer required
.dark
scoped CSS variables, and made button white text to be pure white for better readability.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).