Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: restore locale links #11819

Merged
merged 1 commit into from
Jan 26, 2023
Merged

docs: restore locale links #11819

merged 1 commit into from
Jan 26, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 26, 2023 •
edited
Loading

Description

Follow up to #11720.

I noticed the locale links now disappeared: https://main.vitejs.dev/
image

This PR fixes that.

refs vuejs/vitepress#1339

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Jan 26, 2023
bluwy
bluwy approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@patak-dev patak-dev merged commit 49203a7 into vitejs:main Jan 26, 2023
@sapphi-red sapphi-red deleted the docs/fix-locale-links branch January 26, 2023 11:07
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
docs: restore locale links (vitejs#11819)
093b193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @bluwy @patak-dev