feat(vite): prevent outputting empty js files #3129
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the suggestion from #3127 which is to prevent outputting empty js files in some cases.
It does this by analyzing the entry js chunk to determine if it contains any imports, any modules that have content (ignoring css files and vite/dynamic-import-polyfill). If there are no modules that have content, then the chunk is no longer written to disk, and the
<script>
for the entry file is no longer inlined.Additional context
This is probably not in a mergeable state since I am having issues running the test suite on my development vm. It does however work when linked into the marko/vite project.I will work on getting the tests running properly.I was able to get the tests working, and seems all existing tests pass, also the CI is happy. However I'm not sure where would make the most sense in this codebase to add a test for this. Would appreciate some pointers 😄
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).