-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html): Inline entry chunk into html when possible #4555
Conversation
On the first look, it's LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this feat with the team today and it looks good, and it is great that it also gives Vite Zero JS support. Thanks for this PR @andylizi, I think that @DylanPiercey and the marko team would be very happy to see this merged.
Thanks for implementing this feature @andylizi, we have merged this PR in preparations for vite 2.6-beta |
Description
This PR implements the solution described in #4554. Please see over there for details.
Additional context
About possible breakage: I've been doing some testing recently, looking through the plugin list in awesome-vite and such, and I haven't found any plugin that would be affected by this change. As for existing projects, I think most of them probably won't depend on the old behaviour.
Fixes #4554, fixes #3127, closes #3129.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).