Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Styles of Error.tsx shifted in tailwindcss #537

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

DhairyaMajmudar
Copy link
Contributor

Task Done

  • Rewritten vanilla CSS styles into tailwind utility classes.
  • Converted HTML button into ShandCn button
  • deleted error.css file.
  • corrected import path of Error.tsx file in PublicRoute.tsx file.

closes #535
related to #536

Screenshot

image

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but left a question to be answered before merging this PR.

Comment on lines 46 to 49
<Route
path="/macrobench/queries/compare"
element={<MacroQueriesComparePage />}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this change is done by prettier extension of vscode. This is not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted back that change 👍🏻

website/src/utils/Error.tsx Outdated Show resolved Hide resolved
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@frouioui frouioui merged commit 85cc5af into vitessio:main Apr 30, 2024
5 of 6 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the tailwind/error branch May 1, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: converting error.css file into tailwind classes
2 participants