Feat: Converting HTML buttons into Shadcn Buttons #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
reviewed
Apr 29, 2024
There was a problem hiding this comment.
The changes introduced here are causing issues when running in dark mode, the text is black on a black background. Let's keep it as it was with white text.
There was a problem hiding this comment.
Same issue happens in white mode, where the text is white on a white background.
There was a problem hiding this comment.
I have committed some changes pls. once have a look.
There was a problem hiding this comment.
I am still seeing the same issue on both Safari and Google Chrome.
There was a problem hiding this comment.
Sure thing, I will look into this again for a better solution.
There was a problem hiding this comment.
@frouioui I have committed the changes : )
pls. once check.
frouioui
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files Changed
website/src/common/Dropdown.tsxwebsite/src/pages/MacroQueriesComparePage/components/QueryPlan.tsxCloses #534
Task done
Converted the HTML button into ShadCn Button components.