Fix: lint/format fixes in several files #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some conflicts on this branch after merging #536 |
Signed-off-by: Dhairya Majmudar <[email protected]>
|
Yes I have resolved that confilict. |
frouioui
requested changes
Apr 30, 2024
Comment on lines
+112
to
+128
| <<<<<<< HEAD | ||
| function Row({ title, value, fmt }) { | ||
| var valFmt = value.center; | ||
| if (fmt == "time") { | ||
| valFmt = secondToMicrosecond(value.center); | ||
| } else if (fmt == "memory") { | ||
| valFmt = formatByte(value.center); | ||
| } | ||
| ======= | ||
| function Row({ title, value, fmt }:RowProps) { | ||
| var valFmt = value.center | ||
| if (fmt == "time") { | ||
| valFmt = secondToMicrosecond(value.center) | ||
| } else if (fmt == "memory") { | ||
| valFmt = formatByte(value.center) | ||
| } | ||
| >>>>>>> 85cc5af151fab94e3a4fbf022d03bf596ae36e8f |
There was a problem hiding this comment.
Something bad has happened with a merge here, the frontend do not start with those.
There was a problem hiding this comment.
Its running fine on my side 🤔
There was a problem hiding this comment.
It should not, normally. But anyway these merge hints have to be removed
|
I have opened a new PR to resolve all these conflicts. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Formats the code files.
Issue Number:
#539
Screenshots/videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
Code files are now formatted