Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to enable graceful stop of the grpc server on sigterm #3055

Merged
merged 2 commits into from
Aug 14, 2017

Conversation

bbeaudreault
Copy link
Contributor

Added this as an option instead of all the time, but if you'd like we can make it all the time.

Also, they improved the gracefulstop in grpc-go 1.5.1. How do we know what version we are on, and should we upgrade? In the vendor.json I just see a bunch of sha's so hard to know.

I'm testing this in our env now.

@bbeaudreault
Copy link
Contributor Author

bbeaudreault commented Aug 12, 2017

GracefulStop was added in grpc/grpc-go#147 -- the idea is to send a GOAWAY to clients, accept no new connections, then allow connections to drain.

@sougou
Copy link
Contributor

sougou commented Aug 14, 2017

I think this should be always on. I don't see any harm.

@bbeaudreault
Copy link
Contributor Author

removed the option

@sougou
Copy link
Contributor

sougou commented Aug 14, 2017

LGTM

Approved with PullApprove

@sougou sougou merged commit 9110ad1 into vitessio:master Aug 14, 2017
@michael-berlin
Copy link
Contributor

Also, they improved the gracefulstop in grpc-go 1.5.1. How do we know what version we are on, and should we upgrade? In the vendor.json I just see a bunch of sha's so hard to know.

You can only tell based on the "revisionTime" which version it might be.

  {
  	"checksumSHA1": "s1JlLSFF6wZ4vHgsQGbwX1svcuw=",
  	"path": "google.golang.org/grpc",
  	"revision": "93166a0b0b28148e988c11f4f15a9d92cdc3414a",
  	"revisionTime": "2017-07-10T22:34:07Z"
  },

July 10, so probably not so old :)

If the grpc repo uses tags or branches, we could use these instead with govendor and that should be written to the vendor.json file.

Example: govendor fetch golang.org/x/net/context@=v1 # Get the tag or branch named "v1".

(see: https://github.com/kardianos/govendor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants