Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

[ i18n sprint ] Move translations from language specific lib-home-page templates to properties. #115

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Oct 7, 2022

Companion PR
#What does this pull request do?#
Moves translations from language specific lib-home-page templates to properties.
#How to test#
Open home page, view list of research types

Copy link
Contributor

@bkampe bkampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations are fine

Copy link

@AnnaGuillaumet AnnaGuillaumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that all?

es/webapp/src/main/webapp/i18n/vivo_all_es.properties Outdated Show resolved Hide resolved
es/webapp/src/main/webapp/i18n/vivo_all_es.properties Outdated Show resolved Hide resolved
es/webapp/src/main/webapp/i18n/vivo_all_es.properties Outdated Show resolved Hide resolved
@chenejac chenejac requested a review from brianjlowe October 18, 2022 12:16
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me.
@litvinovg please adopt Anna's corrections for Spanish.

@chenejac chenejac requested review from hudajkhan and removed request for brianjlowe and AnnaGuillaumet November 4, 2022 09:39
@litvinovg litvinovg requested review from bkampe and chenejac November 7, 2022 10:45
@chenejac chenejac merged commit 684d29c into vivo-project:i18n-redesign Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants