Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ i18n sprint ] Move translations from language specific lib-home-page templates to properties. #3780

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

litvinovg
Copy link
Collaborator

@litvinovg litvinovg commented Oct 7, 2022

Companion PR
#What does this pull request do?#
Moved translations from language specific lib-home-page templates to properties.
Redesigned research statistic on home page.
#How to test#
For themes wilma, nemo, tenderfoot:
Open home page, view list of research types

@chenejac chenejac requested review from mmannings and gneissone and removed request for mmannings October 25, 2022 08:31
@chenejac chenejac requested review from hudajkhan and bkampe November 4, 2022 09:37
Copy link
Contributor

@bkampe bkampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like it should.
Maybe the design/arrangement could be improved a little bit.

@litvinovg
Copy link
Collaborator Author

Works like it should. Maybe the design/arrangement could be improved a little bit.

I will try to prepare a solution with a better look

@litvinovg litvinovg requested review from bkampe and chenejac November 7, 2022 10:45
Copy link
Contributor

@bkampe bkampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and is looking good.

@litvinovg litvinovg requested a review from chenejac November 8, 2022 12:23
@chenejac chenejac merged commit b53b3da into vivo-project:i18n-redesign Nov 8, 2022
@chenejac chenejac mentioned this pull request Dec 20, 2022
ghost pushed a commit that referenced this pull request Feb 23, 2023
…e templates to properties. (#3780)

* Improved lib-home-page

* fix

* Redesigned research statistics view

* deleted closing tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants