Replacement of language comparisons using '=' by the 'langMatches' #3789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3767 Problems associated with the use of sparqlContentTripleSource in the applicationSetup.n3 configuration file:
What does this pull request do?
This PR fixes the language context management issue in the Capability Map when using VIVO which uses AWS-Neptune TripleStore
What's new?
As described in the issue, VIVO's CapabilityMap using AWS-Neptune as a TripleStore is not working properly. The malfunction is related to the disfunction of the expertise search bar. The cause of this malfunction is that, unlike the other triple stores, the linguistic value of the tags is stored in lower case. For example: the term "Label"@en-CA is actually stored in AWS-Neptune as "Label"@en-ca.
The solution is to modify the SPARQL queries in the Java code so that the filters process the language parameters regardless of case sensitivity.
How should this be tested?
VIVO installation using AWS-Neptune
Installing AWS-Neptune
To reproduce the BUG, it is absolutely necessary to install an instance of AWS-Neptune.
The following documentation Setting up Neptune allows to install a Neptune instance.
Installing VIVO (master branch)
After starting VIVO, you can download the sample data contained at:
-VIVO Sample data Repo
Upload files:
Observe the problem
Browse the CapabilityMap and try to search for an expertise. You will see that it is not possible to perform a search.
Evaluate the RP
Additional Notes:
see also:
Interested parties
@VIVO-project/vivo-committers