[Issue 3767] Replacement of language comparisons using '=' by the 'langMatches' (without whitespace changes) #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
chenejac
previously approved these changes
Feb 10, 2023
ghost
commented
Feb 13, 2023
| @@ -479,7 +482,7 @@ private static OntModel initializeFakeDisplayModel() { | |||
| Property saveToVarProperty = m | |||
| .getProperty(DisplayVocabulary.SAVE_TO_VAR); | |||
|
|
|||
| m.add(dataGetter, queryProperty, QUERY_STRING_LANG); //UQAM-Optimization Using query with linguistic context | |||
| m.add(dataGetter, queryProperty, QUERY_STRING_LANG("en-US")); //UQAM-Optimization Using query with linguistic context | |||
There was a problem hiding this comment.
I am wondering, is this correct to use a hard coded en-US. The calling method initializeFakeDisplayModel and the method QUERY_STRING_LANG are both static and cannot reference the non-static class member langCtx. Previously it appeared to template the SPARQL query using a data context map with langCtx.
I have approved this previously but on second thought, am not sure it is correct. Yet the class name does not indicate anything of importance and the comments appear to indicate specfic use casees.
chenejac
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also: PR3789