Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar fixes in initialSiteConfig.ttl #4043

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

hauschke
Copy link
Member

VIVO GitHub issue: #4042

What does this pull request do?

Fixes grammar and phrasing in initialSiteConfig.ttl, and removes some unnecessary spaces in another file.

How should this be tested?

A technical syntax check should be technically sufficient. A native German speaker should review the PR on the content side.

Interested parties

@VIVO-project/vivo-committers @matthiasluehr @tawahle @bkampe @markuskotte

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Natural language knowledge
    1. German

Reviewers' report template

Please update the following template which should be used by reviewers.

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@hauschke
Copy link
Member Author

Thanks, @Zack-83.

@chenejac: German language is approved by a German native speaker. Now only a technical review has to be done.

@chenejac chenejac self-requested a review February 4, 2025 08:48
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reviewed by a native German speaker. I can confirm there is no any technical mistake in the PR. Thanks for the contribution.

@chenejac chenejac merged commit da24c1d into vivo-project:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants