Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating from base #5

Merged
merged 232 commits into from
Nov 8, 2019
Merged

updating from base #5

merged 232 commits into from
Nov 8, 2019

Conversation

vladgurgov
Copy link
Owner

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

derberbaby and others added 30 commits August 11, 2019 10:56
Fill in missing semicolons from TDID support update, which may be impacting TDID collection due to pb minification.  Also updating for consistency with remainder of adapter.
* Remove useless bidderCode in bid response

* send all the available sizes in the bid request

* Use the banner sizes if given

* avoid compatibility issue with old bid format
* update maintainer email

* Add TTD unified id

* Remove console.log

* Remove trailing spaces
* Add bid adapter for Sublime

* Fix tests for sublimeBidAdapter

* Fix tests for sublimeBidAdapter

* fix(sublime-adapter): fixes to submit sublimePrebidAdapter

* fix(sublime-adapter): fixes to submit sublimePrebidAdapter

* Remove callback and fix tests

* Update adapter to version 0.4.0

- Support of multiple bid request
- Remove pixel call
- Remove tag
- Refactor
- Update test

* Rearrange constant and import alphabetically

* sublimeBidAdapter: remove deprecated method getTopWindowUrl
* Identity Link - Use ats library for retrieving envelope

* Identity Link - add withCredentials options

* Identity Link - renamed file identityLinkSystem to identityLinkIdSystem
…s to our integration (prebid#4083)

* OPT-1949 Update prebid.js to pass in window.href & add keyword process to our integration

* OPT-1949 remove kw custom value from test

* OPT-1949 fix test

* OPT-1949 specify url value
… keys (prebid#4086)

* ensure native keys are not seen as custom keys

* add unit test for native keys
* Create cosmosBidAdapter.js

Implemented cosmos adapter

* Create cosmosBidAdapter.md

Document file for cosmos

* Create cosmos_sample.html

Test File

* Deleted cosmos_sample.html

* Added unittesting.
* reorganize e2e/ tests into separate directories

* new test page for e2e-banner testing

* add test to check if Banner Ad is getting loaded

* change location of the spec files to reflect change in test/e2e directory structure

* add test case to check for generation of valid targeting keys
* add meazy bid adapter

* fix dealid

* jsnellbaker review

* jsnellbaker review

* jsnellbaker review
* Livewrapped bid and analytics adapter

* Fixed some tests for browser compatibility

* Fixed some tests for browser compatibility

* Changed analytics adapter code name

* Fix double quote in debug message

* modified how gdpr is being passed

* Added support for Publisher Common ID Module

* Corrections for ttr in analytics

* ANalytics updates

* Auction start time stamp changed

* Detect recovered ad blocked requests
Make it possible to pass dynamic parameters to adapter

* Collect info on ad units receiving any valid bid
* s2sTesting: random number moved to global

We got a request that if if 10% of bidderA and 10% of bidderB should be server-side, they should be the same 10% of requests.

This is a simple approach to the change that implies that the same page experience only throws one random number for the purposes of s2sTesting. i.e. if there are dynamic ads on the page, all newly created ads on the page will continue to use the same number. This is ok from the purposes of the s2sTesting module.

* Added get for randNum + fix lint & tests

* update to remove getter

* remove log

* update test
* handle no bid in rdn adapter
* Add support for multi-format ad units. Add favoredMediaType property to params.

* Add tests for gdpr consent.

* Add adId to outbids

* Modify media type resolving

* Refactor multi-format ad units handler.

* Add 9MediaOnline bidder adaptor
mamatic and others added 29 commits October 30, 2019 14:07
* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* update to skip broken circleci tests

* skip all
* 7xbid adapter

* fix error when cli build

* remove unneeded params

* Empty commit

* Empty commit
* adding DMX

test @97%, two files added one updated

* Update districtm_spec.js

* Update districtmDMX.js

* adding all districtm needed file

* remove legacy file

* remove typo || 0 in the test method

* force default to return a valid width and height

* update unit test code for failing test

* changed class for an object

* remove package-lock.json

* change file name for dmx adapter

* renamed files

* restaure package-lock.json

* update to last package-lock state

* update gdpr user consent

* fix sizes issue

* Documentation updates

Adding the readme.md info

* update file name and update unit testing import file location

* current machine state

* lint correction

* remove variable assigment duplicate

* remove none ssl element from all request]
* Add a new ucfunnel Adapter and test page

* Add a new ucfunnel Adapter and test page

* 1. Use prebid lib in the repo to keep updated
2. Replace var with let
3. Put JSON.parse(JSON.stringify()) into try catch block

* utils.getTopWindowLocation is a function

* Change to modules from adapters

* Migrate to module design

* [Dev Fix] Remove width and height which can be got from ad unit id

* Update ucfunnelBidAdapter to fit into new spec

* Correct the endpoint. Fix the error of query string

* Add test case for ucfunnelBidAdapter

* Fix lint error

* Update version number

* Combine all checks on bid request

* Add GDPR support for ucfunnel adapter

* Add in-stream video and native support for ucfunnel adapter

* Remove demo page. Add more test cases.

* Change request method from POST to GET

* Remove unnecessary comment

* Support vastXml and vastUrl for video request

* update TTL to 30 mins

* Avoid using arrow function which is not discuraged in mocha

* ucfunnel tdid support

* ucfunnel adapter support supply chain
…nts (prebid#4303)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* added semi-colon

* update eid source to use domain

* update video oRTB with liveintent segments

* update pbs adapter with liveintent segments support

* update rp adapter liveintent support for fastlane

* reverted package lock, fix for unintentional update

* added unit tests for fastlane.json and ortb, fix to join segments with commas

* fix obj property path data.tpid

* update remove unnecessary function call

* re-ordering query string params
…vailable (prebid#4396)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* moving originalCurrency declaration from currency to bidderFactory

* added a comment

* trying to re-run the CI job

* added unit test case

* trying to re-run the CI job
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* inventory_id and placement

* removed unnecessary file

* lint error

* Update oneVideoBidAdapter.js

* lint error fix
* Added Y1 Analytics Adapter

* rename y1AnalyticsAdapter in yieldoneAnalyticsAdapter

* Yieldone Bid Adapter: fixes from lint check

* Yieldone Analytics Adapter: fix endpoint protocol

* Added spec file for yieldone Analytics Adapter

* Add adUnitName to analytics data for Yieldone Analytics Adapter

* Fix yieldone Analytics Adapter to log only id from adUnitPath

* Fix bug with timeout event in Yieldone Analytics Adapter
* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

* modified api url

* fix

* fixed the secure api call

* rolled back video event callback till we support it

* updated doc with video details

* added bid won and timeout pixel

* added testcase for bid events

* modified testcase

* fixed the url logged

* tag param values passed ot renderer

* added a conditioal check

* changes to support new param to adserver for purpose of tracking

* passed param to renderer

* missing variable defined

* added protocol to url

* fixed test for protocol

* changed urls to secure only
* Update underdogmedia adapter for pbjs 3.0

* Ensure request to endpoint is secure

* Update prebid version

* Lint fix
* Consumable: Clean up tests.

* Consumable: Update use of deprecated function.

* Consumable: Read sizes from mediaTypes.banner.sizes.

* Consumable: Fix lint violation.
* Add CriteoId module

* Update the return type of getId in Criteo Id module

Changes:
- Use of url parsing function from url lib
- Update the return type of getId()
- Update the jsdoc to reflect the real return types

* Fix failing tests for Criteo user module

* Add CriteoIdSystem submodule to .submodule.json.
* Adpod deal support

* Replacing filterBids with minTier

* fix potential issue
* real time data module,
browsi sub module for real time data,
new hook bidsBackCallback,
fix for config unsubscribe

* change timeout&primary ad server only to auctionDelay
update docs

* support multiple providers

* change promise to callbacks
configure submodule on submodules.json

* bug fixes

* use Prebid ajax

* tests fix
* Removed usage of deprecated functions
* Removed beacons
* Banner sizes now reads from bidRequest.mediaTypes.banner.sizes instead of bidRequest.sizes
* Updated tests to reflect changes.
* adds digitrust module, mods gdpr from bool to int

* update unit test

* only send gdprconsent if present

* uses mediaTypes before trying bidRequest sizes

* removes use of deprecated method
@vladgurgov vladgurgov merged commit 64d3801 into add-1ad4good-bidder Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.