Skip to content

Commit

Permalink
addressing review comments #1
Browse files Browse the repository at this point in the history
  • Loading branch information
vlntb committed Nov 19, 2024
1 parent 4b875e9 commit 666d9ea
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions include/xrpl/basics/IntrusivePointer.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct StaticCastTagSharedIntrusive
};

/** Tag to create an intrusive pointer from another intrusive pointer by using a
static cast. This is useful to create an intrusive pointer to a derived
dynamic cast. This is useful to create an intrusive pointer to a derived
class from an intrusive pointer to a base class. If the cast fails an empty
(null) intrusive pointer is created.
*/
Expand Down Expand Up @@ -198,6 +198,16 @@ class SharedIntrusive
friend SharedIntrusive<TT>
make_SharedIntrusive(Args&&... args);

template <class TT>
friend class SharedIntrusive;

template <class TT>
friend class SharedWeakUnion;

template <class TT>
friend class WeakIntrusive;

private:
/** Return the raw pointer held by this object. */
T*
unsafeGetRawPtr() const;
Expand All @@ -223,7 +233,6 @@ class SharedIntrusive
T*
unsafeExchange(T* p);

private:
/** pointer to the type with an intrusive count */
T* ptr_{nullptr};
};
Expand Down

0 comments on commit 666d9ea

Please sign in to comment.