Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to async action monitoring design #5700

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Minor updates to async action monitoring design #5700

merged 1 commit into from
Dec 22, 2022

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Dec 15, 2022 •
edited
Loading

Signed-off-by: Scott Seago [email protected]

Thank you for contributing to Velero!

  1. clarification around Cancel() return values
  2. updates to itemoperation json upload to account for progress
  3. update to OperationProgress struct to avoid duplicate parameter
  4. update new B/R phase name to WaitingForPluginOperationsPartiallyFailed for consistency

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago sseago added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 15, 2022
@github-actions github-actions bot added the Area/Design Design Documents label Dec 15, 2022
@sseago
Minor updates to async action monitoring design:
69da593 
1) clarification around Cancel() return values
2) updates to itemoperation json upload to account for progress
3) update to OperationProgress struct to avoid duplicate parameter
4) update new B/R phase name to WaitingForPluginOperationsPartiallyFailed for consistency
Signed-off-by: Scott Seago <[email protected]>
@reasonerjt reasonerjt self-assigned this Dec 19, 2022
@sseago sseago mentioned this pull request Dec 20, 2022
Merged
@reasonerjt reasonerjt merged commit 5442770 into vmware-tanzu:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reasonerjt reasonerjt reasonerjt approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@Lyndon-Li Lyndon-Li Awaiting requested review from Lyndon-Li

Assignees

@sseago sseago

@reasonerjt reasonerjt

Labels
Area/Design Design Documents kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sseago @reasonerjt @shubham-pampattiwar