-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup/restore phases for async plugin operations #5710
Conversation
93e5e3e
to
67aeb10
Compare
Codecov Report
@@ Coverage Diff @@
## main #5710 +/- ##
==========================================
- Coverage 40.92% 40.89% -0.03%
==========================================
Files 239 239
Lines 20630 20630
==========================================
- Hits 8442 8437 -5
- Misses 11571 11576 +5
Partials 617 617
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
67aeb10
to
76898a1
Compare
Hi @sseago, are there plans to also expose the list/names of plugins on which it is waiting? |
@anshulahuja98 Yes -- this is probably something we'll end up putting in the |
@anshulahuja98 See #5700 -- the information available for each operation will include the following: |
# The current phase of the latest scheduled backup. Valid values are New, FailedValidation, InProgress, Completed, PartiallyFailed, Failed. | ||
# The current phase of the latest scheduled backup. | ||
# Valid values are New, FailedValidation, InProgress, WaitingForPluginOperations, | ||
# WaitingForPluginOperationsPartiallyFailed, Completed, PartiallyFailed, Failed. | ||
phase: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sseago I believe this phase is the current phase of the schedule and not backup. Schedule phase is different from backup phase https://github.com/vmware-tanzu/velero/blob/main/pkg/apis/velero/v1/schedule_types.go#L67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham-pampattiwar Oh, you're right The doc is wrong here -- it says that phase is the phase of the backup, but it's not, it's hte schedule phase. I'll update the comments to reflect this.
Signed-off-by: Scott Seago <[email protected]>
76898a1
to
2abb176
Compare
@blackpiglet @shubham-pampattiwar I fixed a problem with the schedule docs. The prior content was incorrect, listing Backup phases (which I modified in the first iteration of this PR), but schedules have their own independent list of phases, so I've updated the schedule doc to reflect that. If you could review again with the changes, that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sseago LGTM!
Thank you for contributing to Velero!
Please add a summary of your change
Adds new backup and restore phases to support async plugin operations:
Does your change fix a particular issue?
Fixes #5491 #5492
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.