Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup/restore phases for async plugin operations #5710

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Dec 19, 2022

Thank you for contributing to Velero!

Please add a summary of your change

Adds new backup and restore phases to support async plugin operations:

  • WaitingForPluginOperations
  • WaitingForPluginOperationsPartiallyFailed

Does your change fix a particular issue?

Fixes #5491 #5492

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • [x ] Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #5710 (2abb176) into main (55873c1) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5710      +/-   ##
==========================================
- Coverage   40.92%   40.89%   -0.03%     
==========================================
  Files         239      239              
  Lines       20630    20630              
==========================================
- Hits         8442     8437       -5     
- Misses      11571    11576       +5     
  Partials      617      617              
Impacted Files Coverage Δ
pkg/uploader/provider/kopia.go 52.84% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anshulahuja98
Copy link
Collaborator

Hi @sseago, are there plans to also expose the list/names of plugins on which it is waiting?
Otherwise from the status it is difficult to debug which plugin is taking time or could potentially be down.
Is that part of intended design - if not does it make sense to add names?

@sseago
Copy link
Collaborator Author

sseago commented Dec 20, 2022

@anshulahuja98 Yes -- this is probably something we'll end up putting in the velero describe output for backup/restore. describe already pulls from object storage to get warning/error, so this would be one more thing to pull in. That way velero describe backup --details would list the operations and their current status/progress.

@sseago
Copy link
Collaborator Author

sseago commented Dec 20, 2022

@anshulahuja98 See #5700 -- the information available for each operation will include the following:
plugin, item ID, operation ID, and progress information for that operation.

blackpiglet
blackpiglet previously approved these changes Dec 21, 2022
# The current phase of the latest scheduled backup. Valid values are New, FailedValidation, InProgress, Completed, PartiallyFailed, Failed.
# The current phase of the latest scheduled backup.
# Valid values are New, FailedValidation, InProgress, WaitingForPluginOperations,
# WaitingForPluginOperationsPartiallyFailed, Completed, PartiallyFailed, Failed.
phase: ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sseago I believe this phase is the current phase of the schedule and not backup. Schedule phase is different from backup phase https://github.com/vmware-tanzu/velero/blob/main/pkg/apis/velero/v1/schedule_types.go#L67

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham-pampattiwar Oh, you're right The doc is wrong here -- it says that phase is the phase of the backup, but it's not, it's hte schedule phase. I'll update the comments to reflect this.

@sseago
Copy link
Collaborator Author

sseago commented Dec 21, 2022

@blackpiglet @shubham-pampattiwar I fixed a problem with the schedule docs. The prior content was incorrect, listing Backup phases (which I modified in the first iteration of this PR), but schedules have their own independent list of phases, so I've updated the schedule doc to reflect that. If you could review again with the changes, that would be great.

Copy link
Collaborator

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sseago LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new backup phases for item action progress monitoring
6 participants