Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.9: Use updated PVB/PVR for patching Failed Phase during startup #5829

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Feb 3, 2023

Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

same as #5828 for release-1.9

Fixes #5827

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup-release-1.9 branch from c83034b to fff2bdf Compare February 3, 2023 19:45
@kaovilai kaovilai changed the base branch from main to release-1.9 February 3, 2023 19:46
@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup-release-1.9 branch from fff2bdf to 153e16f Compare February 3, 2023 19:47
@github-actions github-actions bot removed has-unit-tests has-e2e-tests Documentation Dependencies Pull requests that update a dependency file labels Feb 3, 2023
@kaovilai kaovilai changed the title Use updated PVB/PVR for patching Failed Phase during startup release-1.9: Use updated PVB/PVR for patching Failed Phase during startup Feb 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5829 (153e16f) into release-1.9 (dd66088) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release-1.9    #5829      +/-   ##
===============================================
+ Coverage        41.62%   41.69%   +0.07%     
===============================================
  Files              214      214              
  Lines            18599    18586      -13     
===============================================
+ Hits              7741     7749       +8     
+ Misses           10274    10254      -20     
+ Partials           584      583       -1     
Impacted Files Coverage Δ
pkg/cmd/cli/restic/server.go 12.96% <0.00%> (+0.23%) ⬆️
pkg/controller/pod_volume_backup_controller.go 45.02% <0.00%> (+0.95%) ⬆️
pkg/controller/pod_volume_restore_controller.go 23.30% <0.00%> (+0.44%) ⬆️
pkg/restore/restore.go 64.40% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup-release-1.9 branch from 153e16f to fce15cf Compare February 6, 2023 20:15
sseago
sseago previously approved these changes Feb 6, 2023
@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup-release-1.9 branch from 699b484 to 07c7692 Compare February 7, 2023 15:53
@Lyndon-Li Lyndon-Li merged commit 0b8ed72 into vmware-tanzu:release-1.9 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InProgress PodVolumeBackup/PodVolumeRestore are not marked as failed when node-agent restarts
5 participants