-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-1.9: Use updated PVB/PVR for patching Failed Phase during startup #5829
Merged
Lyndon-Li
merged 2 commits into
vmware-tanzu:release-1.9
from
kaovilai:pvb-pvr-should-fail-during-startup-release-1.9
Feb 8, 2023
Merged
release-1.9: Use updated PVB/PVR for patching Failed Phase during startup #5829
Lyndon-Li
merged 2 commits into
vmware-tanzu:release-1.9
from
kaovilai:pvb-pvr-should-fail-during-startup-release-1.9
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dependencies
Pull requests that update a dependency file
Documentation
has-changelog
has-e2e-tests
has-unit-tests
labels
Feb 3, 2023
kaovilai
force-pushed
the
pvb-pvr-should-fail-during-startup-release-1.9
branch
from
February 3, 2023 19:45
c83034b
to
fff2bdf
Compare
kaovilai
force-pushed
the
pvb-pvr-should-fail-during-startup-release-1.9
branch
from
February 3, 2023 19:47
fff2bdf
to
153e16f
Compare
github-actions
bot
removed
has-unit-tests
has-e2e-tests
Documentation
Dependencies
Pull requests that update a dependency file
labels
Feb 3, 2023
kaovilai
changed the title
Use updated PVB/PVR for patching Failed Phase during startup
release-1.9: Use updated PVB/PVR for patching Failed Phase during startup
Feb 3, 2023
Codecov Report
@@ Coverage Diff @@
## release-1.9 #5829 +/- ##
===============================================
+ Coverage 41.62% 41.69% +0.07%
===============================================
Files 214 214
Lines 18599 18586 -13
===============================================
+ Hits 7741 7749 +8
+ Misses 10274 10254 -20
+ Partials 584 583 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
pvb-pvr-should-fail-during-startup-release-1.9
branch
from
February 6, 2023 20:15
153e16f
to
fce15cf
Compare
sseago
previously approved these changes
Feb 6, 2023
Lyndon-Li
reviewed
Feb 7, 2023
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
pvb-pvr-should-fail-during-startup-release-1.9
branch
from
February 7, 2023 15:53
699b484
to
07c7692
Compare
sseago
approved these changes
Feb 7, 2023
Lyndon-Li
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior
same as #5828 for release-1.9
Fixes #5827
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.