forked from vmware-tanzu/velero
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oadp-1.1: OADP-1256 Use updated PVB/PVR for patching Failed Phase during startup #238
Closed
kaovilai
wants to merge
32
commits into
openshift:oadp-1.1
from
kaovilai:pvb-pvr-should-fail-during-startup-oadp-1.1
Closed
oadp-1.1: OADP-1256 Use updated PVB/PVR for patching Failed Phase during startup #238
kaovilai
wants to merge
32
commits into
openshift:oadp-1.1
from
kaovilai:pvb-pvr-should-fail-during-startup-oadp-1.1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 00c1eb6) version bump; update restic branch/build;rebase log 1.6.0-rc.1 (cherry picked from commit 05bae5e) Fixed version tag for velero 1.6.0 (not rc1) (cherry picked from commit 8022187) Point back to konveyor-dev for restic (cherry picked from commit 8436504) Don't use builder from docker.io (cherry picked from commit 1f9a6f4)
(cherry picked from commit 56ef807)
(cherry picked from commit ccb545f) Update PR-BZ automation mapping (#84) (cherry picked from commit aa2b019) Update PR-BZ automation (#92) Co-authored-by: Rayford Johnson <[email protected]> (cherry picked from commit ecc563f) Add publish workflow (vmware-tanzu#108) (cherry picked from commit f87b779)
Signed-off-by: Norwin Schnyder <[email protected]>
Added support for restic volume checksum verification. This adds another pod annotation ('backup.velero.io/verify-volumes') which is used to identify which volumes on the pod should get the '--verify' flag passed to restic when restoring. Stdout and stderr are logged to the restic pod logs. The PodVolumeRestore CRD has three new status fields: Errors, VerifyErrors, and ResticPod, which contain the number of total errors reported, the number of verify errors reported, and the name of the restic pod that ran the restore (to allow for the user to look in the pod logs for more detailed output). The Restore CRD has two new Status fields: PodVolumeRestoreErrors and PodVolumeRestoreVerifyErrors, which contain a slice of ObjectReferences listing which PodVolumeRestores contained errors or verify errors. There is not yet support built into restore describe to see the restore fields via the velero client. Also, the restic daemonset will need to have an env variable set for POD_NAME. (cherry picked from commit da2df66) (cherry picked from commit 5a05c6b) Signed-off-by: Scott Seago <[email protected]> Refactored restic verify to use output annotations rather than (vmware-tanzu#146) adding new status fields. This removes the CRD changes from upstream. making sure pvr errors are getting reported correctly
(cherry picked from commit 6d7629c)
…-tanzu#179) * improve datamover backup performance * remove minor logs * remove unrelated changes * add vol-snap-mover deps * fix logrusr dep issue * fix via go mod tidy Co-authored-by: Shubham Pampattiwar <[email protected]>
…tanzu#183) * make datamover timeout configurable * conform to time string as duration Co-authored-by: Shubham Pampattiwar <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
changed the title
Use updated PVB/PVR for patching Failed Phase during startup
oadp-1.1: Use updated PVB/PVR for patching Failed Phase during startup
Feb 6, 2023
kaovilai
changed the title
oadp-1.1: Use updated PVB/PVR for patching Failed Phase during startup
oadp-1.1: OADP-1256 Use updated PVB/PVR for patching Failed Phase during startup
Feb 6, 2023
Signed-off-by: Tiger Kaovilai <[email protected]>
sseago
approved these changes
Feb 7, 2023
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Feb 8, 2023
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing since upstream fix was rebased to this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior
Signed-off-by: Tiger Kaovilai [email protected]
cherrypick from vmware-tanzu#5829
OADP-1256
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.