Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oadp-1.1: OADP-1256 Use updated PVB/PVR for patching Failed Phase during startup #238

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Feb 6, 2023

Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

Signed-off-by: Tiger Kaovilai [email protected]

cherrypick from vmware-tanzu#5829
OADP-1256

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

dymurray and others added 30 commits January 24, 2023 13:02
(cherry picked from commit 00c1eb6)

version bump; update restic branch/build;rebase log 1.6.0-rc.1

(cherry picked from commit 05bae5e)

Fixed version tag for velero 1.6.0 (not rc1)

(cherry picked from commit 8022187)

Point back to konveyor-dev for restic

(cherry picked from commit 8436504)

Don't use builder from docker.io

(cherry picked from commit 1f9a6f4)
(cherry picked from commit ccb545f)

Update PR-BZ automation mapping (#84)

(cherry picked from commit aa2b019)

Update PR-BZ automation (#92)

Co-authored-by: Rayford Johnson <[email protected]>
(cherry picked from commit ecc563f)

Add publish workflow (vmware-tanzu#108)

(cherry picked from commit f87b779)
Added support for restic volume checksum verification.
This adds another pod annotation ('backup.velero.io/verify-volumes')
which is used to identify which volumes on the pod should get the
'--verify' flag passed to restic when restoring.

Stdout and stderr are logged to the restic pod logs. The PodVolumeRestore
CRD has three new status fields: Errors, VerifyErrors, and ResticPod,
which contain the number of total errors reported, the number of verify
errors reported, and the name of the restic pod that ran the restore
(to allow for the user to look in the pod logs for more detailed output).

The Restore CRD has two new Status fields: PodVolumeRestoreErrors
and PodVolumeRestoreVerifyErrors, which contain a slice of ObjectReferences
listing which PodVolumeRestores contained errors or verify errors.

There is not yet support built into restore describe to see the restore fields
via the velero client. Also, the restic daemonset will need to have an env
variable set for POD_NAME.

(cherry picked from commit da2df66)
(cherry picked from commit 5a05c6b)
Signed-off-by: Scott Seago <[email protected]>

Refactored restic verify to use output annotations rather than (vmware-tanzu#146)

adding new status fields. This removes the CRD changes from upstream.

making sure pvr errors are getting reported correctly
…-tanzu#179)

* improve datamover backup performance

* remove minor logs

* remove unrelated changes

* add vol-snap-mover deps

* fix logrusr dep issue

* fix via go mod tidy

Co-authored-by: Shubham Pampattiwar <[email protected]>
…tanzu#183)

* make datamover timeout configurable

* conform to time string as duration

Co-authored-by: Shubham Pampattiwar <[email protected]>
Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai changed the title Use updated PVB/PVR for patching Failed Phase during startup oadp-1.1: Use updated PVB/PVR for patching Failed Phase during startup Feb 6, 2023
@kaovilai kaovilai changed the title oadp-1.1: Use updated PVB/PVR for patching Failed Phase during startup oadp-1.1: OADP-1256 Use updated PVB/PVR for patching Failed Phase during startup Feb 6, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sseago
Copy link

sseago commented Feb 9, 2023

Closing since upstream fix was rebased to this branch

@sseago sseago closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants