-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only get VolumeSnapshotClass when DataUpload exists. #7974
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7974 +/- ##
==========================================
+ Coverage 59.02% 59.09% +0.07%
==========================================
Files 364 364
Lines 30272 30340 +68
==========================================
+ Hits 17867 17929 +62
- Misses 10959 10968 +9
+ Partials 1446 1443 -3 ☔ View full report in Codecov by Sentry. |
Don't we also need VSClass for CSI snapshot backups without datamover? |
Yes, but for the CSI plugin scenario, because the VolumeSnapshot-related CRs are persisted, so VolumeSnapshotClasses are already passed in by parameters. velero/internal/volume/volumes_information.go Lines 321 to 340 in 1ec52be
|
b7146cb
to
6882824
Compare
Signed-off-by: Xun Jiang <[email protected]>
@kaovilai @shubham-pampattiwar |
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7823
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.