Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifact-manager,installer,maven] (#328) Remove vrang.project.id and vrang_project_id configuration properties #498

Merged
merged 18 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
16.20.2
2 changes: 1 addition & 1 deletion common/artifact-manager/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.16</version>
<version>1.7.29</version>
</dependency>
<dependency>
<groupId>net.minidev</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ public class ConfigurationVraNg extends Configuration {
* param CSP_HOST.
*/
public static final String CSP_HOST = "csp.host";
/**
* param PROJECT_ID.
*/
public static final String PROJECT_ID = "project.id";
/**
* param DATA_COLLECTION_DELAY_SECONDS.
*/
Expand Down Expand Up @@ -131,13 +127,6 @@ public String getAuthHost() {
}
}

/**
* @return String
*/
public String getProjectId() {
return this.properties.getProperty(PROJECT_ID);
}

/**
* @return String
*/
Expand Down Expand Up @@ -251,8 +240,8 @@ public void validate(boolean domainOptional) throws ConfigurationException {
message.append("Port ");
}

if (StringUtils.isEmpty(getProjectId()) && StringUtils.isEmpty(getProjectName())) {
message.append("Project name/Project id ");
if (StringUtils.isEmpty(getProjectName())) {
message.append("Project name ");
}

if (StringUtils.isEmpty(getOrgId()) && StringUtils.isEmpty(getOrgName())) {
Expand All @@ -274,7 +263,8 @@ public void validate(boolean domainOptional) throws ConfigurationException {
public void deprecationWarnings() {
String[] deprecatedFlags = new String[] {
"bp.ignore.versions",
"bp.release"
"bp.release",
"project.id"
};

for (String flag : deprecatedFlags) {
Expand Down
Loading
Loading