Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[artifact-manager,installer,maven] (#328) Remove vrang.project.id and vrang_project_id configuration properties #498

Merged
merged 18 commits into from
Nov 12, 2024
Merged

[artifact-manager,installer,maven] (#328) Remove vrang.project.id and vrang_project_id configuration properties #498

merged 18 commits into from
Nov 12, 2024

Conversation

Michaelpalacce
Copy link
Collaborator

@Michaelpalacce Michaelpalacce commented Nov 11, 2024 •
edited
Loading

Description

vrang.project.id has been entirely deprecated and instead vrang.project.name should be used

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Pending

Release Notes

Pending

Related issues and PRs

@Michaelpalacce
refactor!: Removed vrang.project.id from all the pom files

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
92d6730 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
docs: Removed vrang.project.id from the documentation
5dea692 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
refactor(Installer)!: No longer works with vrang.project.id
66abf2a 
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
refactor(restClients)!: No longer work with project.id
cf27581 
- RestClientCs will no longer add the projectId to the filter by default
  if name is missing
- RestClientVraNgPrimitive no longer will get the projectId from the
  config if the value is present, but will always work with the
  projectName
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
891bce3 
…re-aria into feature/328-remove-duplicate-settings

Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce Michaelpalacce added lang/java Related to Java Code area/artifact-manager Relates to the `artifact-manager` maven module area/installer Relates to the solution installer version/major Introduces a breaking change kind/refactor Refactoring of existing features area/maven Relates to maven changes labels Nov 11, 2024
@github-actions github-actions bot added the kind/feature New Feature to the project label Nov 11, 2024
@VenelinBakalov VenelinBakalov changed the title [artifact-manager,installer,maven] (#328) vrang.project.id can no longer be used [artifact-manager,installer,maven] (#328) Remove vrang.project.id configuration property Nov 11, 2024
@VenelinBakalov VenelinBakalov removed the kind/feature New Feature to the project label Nov 11, 2024
@VenelinBakalov
Copy link
Collaborator

Looks good, I guess we can remove org.id as well in a separate PR to make things more strucutred?

@Michaelpalacce
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
7a3fa78 
…re-aria into feature/328-remove-duplicate-settings

Signed-off-by: Stefan Genov <[email protected]>
@github-actions github-actions bot added the kind/feature New Feature to the project label Nov 11, 2024
@Michaelpalacce
Copy link
Collaborator Author

Looks good, I guess we can remove org.id as well in a separate PR to make things more strucutred?

Ahm, actuallyyyyy I forgot about that one 😄 Yeah, lets do it in a separate PR

VenelinBakalov
VenelinBakalov requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@VenelinBakalov VenelinBakalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to also remove vrang_org_id for the installer

@Michaelpalacce Michaelpalacce marked this pull request as ready for review November 11, 2024 13:49
@Michaelpalacce Michaelpalacce requested a review from a team as a code owner November 11, 2024 13:49
@Michaelpalacce
Revert "chore: ignore flakes"
8413911 
This reverts commit b4b34f1.

Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
fix(logging): Reverting latest log4j bump
357f21d 
-it broke logging
Signed-off-by: Stefan Genov <[email protected]>
@Michaelpalacce
Copy link
Collaborator Author

@VenelinBakalov Opened a new pr for org id, can you review again?

@Michaelpalacce Michaelpalacce merged commit 3c023c7 into main Nov 12, 2024
11 checks passed
@VenelinBakalov VenelinBakalov removed the kind/feature New Feature to the project label Nov 12, 2024
@VenelinBakalov VenelinBakalov changed the title [artifact-manager,installer,maven] (#328) Remove vrang.project.id configuration property [artifact-manager,installer,maven] (#328) Remove vrang.project.id and vrang_project_id configuration properties Nov 12, 2024
Michaelpalacce added a commit that referenced this pull request Nov 12, 2024
@Michaelpalacce
Merge pull request #500 from vmware/refactor/498-remove-org-id
79340ce 
[maven,artifact-manager,installer] (#498) Remove `vrang.org.id` and `vrang_org_id` configuration properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinBakalov VenelinBakalov

Assignees
No one assigned
Labels
area/artifact-manager Relates to the `artifact-manager` maven module area/installer Relates to the solution installer area/maven Relates to maven changes kind/refactor Refactoring of existing features lang/java Related to Java Code version/major Introduces a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michaelpalacce @VenelinBakalov