Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifact-manager,installer,maven] (#328) Remove vrang.project.id and vrang_project_id configuration properties #498

Merged
merged 18 commits into from
Nov 12, 2024
Merged

[artifact-manager,installer,maven] (#328) Remove vrang.project.id and vrang_project_id configuration properties #498

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
92d6730
refactor!: Removed `vrang.project.id` from all the pom files
Michaelpalacce Nov 11, 2024
5dea692
docs: Removed `vrang.project.id` from the documentation
Michaelpalacce Nov 11, 2024
66abf2a
refactor(Installer)!: No longer works with `vrang.project.id`
Michaelpalacce Nov 11, 2024
cf27581
refactor(restClients)!: No longer work with project.id
Michaelpalacce Nov 11, 2024
891bce3
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
Michaelpalacce Nov 11, 2024
7a3fa78
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
Michaelpalacce Nov 11, 2024
9e83419
docs: added method documentations
Michaelpalacce Nov 11, 2024
cc5be95
docs: fixed docs
Michaelpalacce Nov 11, 2024
bdf8f97
feat: `vrang.project.id` added to deprecation warnings
Michaelpalacce Nov 11, 2024
a546183
docs: Release
Michaelpalacce Nov 11, 2024
3d2840f
lint: Removed trailing space
Michaelpalacce Nov 11, 2024
29bb671
lint: Trailing space removed
Michaelpalacce Nov 11, 2024
6019f62
feat: Added a `.node-version` file for `fnm`
Michaelpalacce Nov 11, 2024
b4b34f1
chore: ignore flakes
Michaelpalacce Nov 11, 2024
8413911
Revert "chore: ignore flakes"
Michaelpalacce Nov 11, 2024
357f21d
fix(logging): Reverting latest log4j bump
Michaelpalacce Nov 11, 2024
82c07f3
docs: Added `environment.properties` details
Michaelpalacce Nov 12, 2024
a4fdbad
Merge branch 'main' of https://github.com/vmware/build-tools-for-vmwa…
Michaelpalacce Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions ...manager/src/main/java/com/vmware/pscoe/iac/artifact/configuration/ConfigurationVraNg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ public class ConfigurationVraNg extends Configuration {
* param CSP_HOST.
*/
public static final String CSP_HOST = "csp.host";
/**
* param PROJECT_ID.
*/
public static final String PROJECT_ID = "project.id";
/**
* param DATA_COLLECTION_DELAY_SECONDS.
*/
Expand Down Expand Up @@ -131,13 +127,6 @@ public String getAuthHost() {
}
}

/**
* @return String
*/
public String getProjectId() {
return this.properties.getProperty(PROJECT_ID);
}

/**
* @return String
*/
Expand Down Expand Up @@ -251,8 +240,8 @@ public void validate(boolean domainOptional) throws ConfigurationException {
message.append("Port ");
}

if (StringUtils.isEmpty(getProjectId()) && StringUtils.isEmpty(getProjectName())) {
message.append("Project name/Project id ");
if (StringUtils.isEmpty(getProjectName())) {
message.append("Project name ");
}

if (StringUtils.isEmpty(getOrgId()) && StringUtils.isEmpty(getOrgName())) {
Expand All @@ -274,7 +263,8 @@ public void validate(boolean domainOptional) throws ConfigurationException {
public void deprecationWarnings() {
String[] deprecatedFlags = new String[] {
"bp.ignore.versions",
"bp.release"
"bp.release",
"project.id"
};

for (String flag : deprecatedFlags) {
Expand Down
Loading