Add new features for the ui of the vic plugin auto install functionality #1790

lmalvins · 2018-05-24T20:04:09Z

Fix:vmware/vic-ui#465

This PR includes a new modal for plugin installation which includes an ajax call to the server to get the thumbprint.

Installing for the first time and success message

VC validation failed

Wrong credentials

Canceling plugin installation

Succes unit test example (jasmine + karma runner):

Failed unit test example (jasmine + karma runner):

User Statement:

As a user, I want to be able to manage VIC UI plugin auto install.

Details:

Acceptance Criteria:

Add new modal which shows the fingerprint with a cancel and continue button
Add an ajax call to get the thumbprint from vcenter
Add call to the API for plugin install
UX review
Display success/error messages from auto install
Alert to restart services
Add unit testing framework
Add unit tests

ghost

I think we need to revert the changes to the Init* variables, but their than that, this looks good!

ghost · 2018-05-25T02:10:26Z

installer/fileserver/html/index.html

@@ -30,35 +29,38 @@
            </div>
        </header>
        <main class="content-container">
-            <div class="content-area">
-                <div id="getting-started-items-container">
-                    {{if .InitErrorFeedback }}


We need to keep this variable here - it can be populated by messages other than those which you have put here.

ghost · 2018-05-25T02:10:45Z

installer/fileserver/html/index.html

                        <div class="alert-item">
-                            <span class="alert-text">{{ .InitErrorFeedback }}</span>


Same as above.

ghost · 2018-05-25T02:11:00Z

installer/fileserver/html/index.html

                            <div class="alert-actions">
                                <a href="/?login=true" title="Login" class="alert-action">Re-initialize</a>
                            </div>
                        </div>
                    </div>
-                    {{ end }}
-                    {{if .InitSuccessFeedback }}


Same as above, please!

ghost · 2018-05-25T02:11:33Z

installer/fileserver/html/index.html

                        <div class="alert-item">
-                            <span class="alert-text">{{ .InitSuccessFeedback }}</span>


Same as above, please!

ghost · 2018-05-25T02:16:05Z

installer/fileserver/html/index.html

+            $loginSpinner.style.display = '';
+            setTimeout(function() {
+                $vc = document.getElementById('target').value;
+                getThumbprint($vc,function (thumbprint,status) {


Looks good!

ghost

LGTM! Please make sure to squash your changes before merging.

ghost · 2018-05-25T17:38:25Z

installer/fileserver/html/index.html

+                            </div>
+                        </div>
+                        {{ end }}
+                    <div id="feedback-alert-error" class="alert alert-danger mt-0" style="display: none">


Do we still need this?

jak-atx · 2018-05-25T17:54:38Z

installer/fileserver/html/index.html

 </body>

-</html>
+</html>


add line break

jak-atx · 2018-05-25T17:56:12Z

installer/fileserver/html/index.html

+            $pluginSpinner.style.display = '';
+            setTimeout(function() {              
+                $loginForm.submit();
+            });


setTimeout should have a second parameter for the timeout interval

jak-atx · 2018-05-25T17:56:56Z

installer/fileserver/html/index.html

+                $vc = document.getElementById('target').value;
+                getThumbprint($vc,function (thumbprint,status) {
+
+                            if (status ===200){


nit: fix spacing

jak-atx · 2018-05-25T18:14:15Z

installer/fileserver/html/index.html

+    xhr.onreadystatechange = function() {
+        callback(xhr.response,xhr.status);
+    };
+    xhr.send();             


let's make sure we cross-browser test all of this since we aren't using any libraries

jak-atx

Few small comments. Also, the functions in this page should include at least some basic unit testing.

ghost

LGTM with unit tests, one small comment.

ghost · 2018-06-04T16:09:35Z

installer/fileserver/html/index.html

+                        {{if .InitSuccessFeedback }}
+                        <div id="feedback-alert" class="alert alert-success">
+                            <div class="alert-item">
+                                <span class="alert-text">{{ .InitSuccessFeedback }}, please restart the vSphere client services</span>


Please remove the , please restart the vSphere client services, it will be populated on the backend.

lweitzman

Looks good

Introduces caching of the vic-ui plugin artifacts as a component of the ova. Updates the fileserver provisioner to package vic-ui with the correct version numbers. Fixes vmware#1433.

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

vmwclabot added the cla-not-required label May 24, 2018

ghost requested review from a user and jak-atx May 24, 2018 20:06

ghost suggested changes May 25, 2018

View reviewed changes

lmalvins changed the title ~~[WIP] Add new features for the ui of the vic plugin auto install functionality~~ Add new features for the ui of the vic plugin auto install functionality May 25, 2018

ghost approved these changes May 25, 2018

View reviewed changes

jak-atx reviewed May 25, 2018

View reviewed changes

installer/fileserver/html/index.html Outdated

</body>

</html>

</html>

Copy link

jak-atx May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add line break

jak-atx reviewed May 25, 2018

View reviewed changes

jak-atx suggested changes May 25, 2018

View reviewed changes

andrewtchin mentioned this pull request May 25, 2018

Getting Started Page/fileserver updates for VIC UI plugin automated install vmware/vic-ui#465

Closed

8 tasks

ghost approved these changes Jun 4, 2018

View reviewed changes

ghost requested a review from lweitzman June 4, 2018 16:55

ghost force-pushed the feature/auto-vic-ui-plugin branch from 36a27b3 to 5253c52 Compare June 4, 2018 20:24

lweitzman approved these changes Jun 5, 2018

View reviewed changes

Jason Morris and others added 14 commits June 5, 2018 10:47

Provision vic-ui in the ova (vmware#1758)

7820026

Introduces caching of the vic-ui plugin artifacts as a component of the ova. Updates the fileserver provisioner to package vic-ui with the correct version numbers. Fixes vmware#1433.

- Adding new modal for thumbprint validation

ebec98b

Adding callback functionality when make async calls to the server

f3a4af1

Add some refactors and validations for wrong vcenter ip or fqdn

d81c87a

Add blocks with success or failure install messages

9ac7b0a

Removing do not used message feedback alerts

c685878

Fix spacing and adds alert for vSphere client servies restart

084f162

Add little refactors

93a8fcb

Separate the script to a new file and adds reference on index.html page

ee4bdc0

Add nodejs environment with karma runner for jasmine test framework

df9105e

Adds index.html fixture and spec file with the test

01c8f60

Adds gitignore file

63bd524

Adds little refactor

875fbdc

adding input validators with new unit tests

1844734

Removing not necessary lines

c001e6b

lmalvins force-pushed the feature/auto-vic-ui-plugin branch from 2c8d734 to c001e6b Compare June 5, 2018 14:01

Fixing TestGroups.md file

d135954

jak-atx approved these changes Jun 5, 2018

View reviewed changes

ghost merged commit a13a244 into vmware:feature/auto-vic-ui-plugin Jun 5, 2018

ghost pushed a commit that referenced this pull request Jun 6, 2018

Implement fileserver thumbprint verification (#1790)

7f5c5c0

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

ghost pushed a commit that referenced this pull request Jun 6, 2018

Implement fileserver thumbprint verification (#1790)

90a8a83

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit to wjun/vic-product that referenced this pull request Aug 20, 2018

Implement fileserver thumbprint verification (vmware#1790)

5151944

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit to wjun/vic-product that referenced this pull request Aug 22, 2018

Implement fileserver thumbprint verification (vmware#1790)

b1b87ea

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

zjs pushed a commit that referenced this pull request Aug 23, 2018

Implement fileserver thumbprint verification (#1790)

a9d0359

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 27, 2018

Implement fileserver thumbprint verification (#1790)

570e1e2

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun mentioned this pull request Aug 29, 2018

Merge branch Feature/auto-vic-ui-plugin #1979

Merged

wjun pushed a commit that referenced this pull request Aug 29, 2018

Implement fileserver thumbprint verification (#1790)

4655362

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 29, 2018

Implement fileserver thumbprint verification (#1790)

e210b7f

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 30, 2018

Implement fileserver thumbprint verification (#1790)

bbfe684

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 30, 2018

Implement fileserver thumbprint verification (#1790)

0fc3557

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 30, 2018

Implement fileserver thumbprint verification (#1790)

de4a544

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 30, 2018

Implement fileserver thumbprint verification (#1790)

fedc81d

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 31, 2018

Implement fileserver thumbprint verification (#1790)

114ac14

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

wjun pushed a commit that referenced this pull request Aug 31, 2018

Implement fileserver thumbprint verification (#1790)

794661c

Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new features for the ui of the vic plugin auto install functionality #1790

Add new features for the ui of the vic plugin auto install functionality #1790

lmalvins commented May 24, 2018 •

edited

Loading

ghost left a comment

ghost May 25, 2018 •

edited by ghost

Loading

ghost May 25, 2018

ghost May 25, 2018

ghost May 25, 2018

ghost May 25, 2018

ghost left a comment

ghost May 25, 2018

jak-atx May 25, 2018

jak-atx May 25, 2018

jak-atx May 25, 2018

jak-atx May 25, 2018

jak-atx left a comment

ghost left a comment

ghost Jun 4, 2018

lweitzman left a comment

		<div class="alert-item">
		<span class="alert-text">{{ .InitErrorFeedback }}</span>

		<div class="alert-item">
		<span class="alert-text">{{ .InitSuccessFeedback }}</span>

               </body>
-              </html>
+              </html>

Add new features for the ui of the vic plugin auto install functionality #1790

Add new features for the ui of the vic plugin auto install functionality #1790

Conversation

lmalvins commented May 24, 2018 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

ghost May 25, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jak-atx left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lweitzman left a comment

Choose a reason for hiding this comment

lmalvins commented May 24, 2018 •

edited

Loading

ghost May 25, 2018 •

edited by ghost

Loading