Generated vic-machine create command has wrong argument for volume store

[zjs]

VIC version:

1.3.0 OVA RC 4 (UI RC6)

Steps to reproduce:

Use the creation wizard to specify a VCH which has a default volume store (or, perhaps, any volume store).

Actual behavior:

The generated CLI command includes a --volume-stores option.

This will result in an error when executed: Incorrect Usage: flag provided but not defined: -volume-stores.

Expected behavior:

The generated CLI command should include a --volume-store option.

[AngieCris]

Reopen: generated CLI command still has the wrong volume store flag
(cherry-pick PR is missing)

[AngieCris]

@stuclem Can you please document that the generated CLI command has the wrong volume store flag? The workaround is to change --volume-stores to --volume-store. Thanks!

[jooskim]

@stuclem To give you more context on this, commit 10863aa was not cherry-picked onto our releases/1.3.0 branch and thus got omitted in v1.3.0 GA.

[stuclem]

Release note:

• Generated vic-machine command includes incorrect --volume-stores option. #251
  In the Summary page of the Create VCH wizard, if you configured a volume store, the generated vic-machine command includes the option --volume-stores. This is should be --volume-store. Attempting to run the generated command results in the error Incorrect Usage: flag provided but not defined: -volume-stores.

  Workaround: Manually edit the generated command to correct the option name to --volume-store.

@jooskim is this OK?

[jooskim]

@stuclem Looks good!

[zjs]

This is should be

I think there's an extraneous "is" here.

[mdubya66]

Let's get this merged by Jan 17. so it makes it into 1.3.1

[stuclem]

Fixed the extraneous "is" in the RN.

[andrewtchin]

just needs cherry pick pr

[jak-atx]

Merged to master. Cherry-pick PR #303